Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp4189968imw; Thu, 7 Jul 2022 14:23:09 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tCx7vqFEHvnYbzNnpWGXV1biKmGuZa5FTqhnPdnK8Y4g6WnEgUZU1ReAj8UDrbOcRdbkWq X-Received: by 2002:a17:907:7f8e:b0:712:f503:1a56 with SMTP id qk14-20020a1709077f8e00b00712f5031a56mr116767ejc.364.1657228989601; Thu, 07 Jul 2022 14:23:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657228989; cv=none; d=google.com; s=arc-20160816; b=I017dNGs3nb961SKi/DIj5aQEQd8zeV/EYdUdTNyY3ARoBUj9nRXB1cJ9s5XrNKrg2 65qnfXSaMkuUkGInXro6L0W0pO4tYgbvbm4JS+Nd2QTUkGT+R7yM7X3eqLHlyCG6j3uQ hs6suF6oXlqLD10jisPIeZ+mQMWiD6iGvKhjQAEk/uS5vY6f+xC2zdUMihO2ly80BBNt VmLukPKGIbPgCLjzE2j1LeMUP1dJ0EjwKnkDVudg9H0f4XsIE8ST9OcgkOw1HtP5VB+Y C5+2R7uXbIqpGqwOnsPZHHbPL/4HCxJ/Ufd4zootd22TyedJYOG90u5lHq5s/kyNPvMm Wsuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Z0i/FsEtEYZWQoqmAH7Voc71S2cgw06FoAKusiT8OZ4=; b=x+5vE5wcMu+l5ASqQU0raRGg3qfbKuNB1ZqDXo2lZlJsCwv3qLmnAPp0U1dnhMj/yI iqsMINhr8a0+40mJUeuhXEfB1SKhcIfkaD08fLd6pn5Ldj7tBCBt88ZD7sOAmEllVkxO NgUYY74iEiso1A9+uTXuFq1yFeBRMak+z97gPICMfuHiZ7FrP3/Dc5nhITUDF+2HrUv6 Zz7UrILuhnAq6gMt0rHqC0t7SUZvGG4fzhwq9EPe+IZ9kU7IJrF8G3RXwoS5tcC5ExiF tipP/EGS1CBy63RbQd5jd1Mwmt3S7kxOhNttDeOprmZGhuYEU/dJAAgzynU4Z5lejavR a1yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=WoU0PSQ0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s2-20020a170906454200b007262adb2086si46752248ejq.256.2022.07.07.14.22.41; Thu, 07 Jul 2022 14:23:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=WoU0PSQ0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236607AbiGGVIp (ORCPT + 99 others); Thu, 7 Jul 2022 17:08:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236562AbiGGVIm (ORCPT ); Thu, 7 Jul 2022 17:08:42 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0642193D6 for ; Thu, 7 Jul 2022 14:08:41 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id s206so20712676pgs.3 for ; Thu, 07 Jul 2022 14:08:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Z0i/FsEtEYZWQoqmAH7Voc71S2cgw06FoAKusiT8OZ4=; b=WoU0PSQ0Wj5Vhi5VAdOixoxhmqcmoNDkx6vHqBySeC9zqf2nqsQfssDemp0HQ+Ov1B x/J5MxoGXzLdJH5GEyRAbOhWT68fOGc+6rHAXDByBx1OVQfP46gGjK+Mi+BzW6aTzy1J zCmFPJ2SlEc+diWQW3EPCjFu0t4IWIGEdVT9pGCnFTtf0M7aL/JzkavojLQOy4s/UgNF NGApv5Q7B2F5jgchJKAeNIaqUXEoBZLJR5OdL0c5HU9ZNIBlR45kMkufdSbiFomJXlCl /ZAg/DkWLMF98iVndrnP9vxLYNAXMsIgTDVMZU2Ziwpk1aIQXpLAs3/2s4PDhY8kMxbt LAVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Z0i/FsEtEYZWQoqmAH7Voc71S2cgw06FoAKusiT8OZ4=; b=Epiic/ei0PspO3exGpPmcTrC+UfS1wFUY4IgVUsDT7huO9b5W+LhMyHzOMbyXMyYP/ cCUcgaJeVZPFPfJeVUOq1ZNEELVdtjNfO/kTvVT9xoFaYMHd2eyrsCSVCrXHJ7Jhba7C lUi6qCADEOZTrNiYAeLBd0wQPxyfVtedX1QWmVsRfqM19WvCjt1Mc5vTEdvTgEfK5pEo KNitGwmDTINL6dRMTCj8byw+XGGcgQC+Kqd8tl+DcQs9JTSUKhkMZzgNH4AJk+VQUpX9 FYxtiWg/Bgpn0s9ertBYmMIPc9qd3ajxA8zcEWgq7l0hE45VvXEPZcEIut5LtVrB6VOS m9Yw== X-Gm-Message-State: AJIora8F0uR6EropeT+ZKuXIKcuFA7W9b46rxNxToxxX0YeAQoWOGkgZ jbH92PGmv3dm5ClLcIE42nGRxQ== X-Received: by 2002:a05:6a00:13a5:b0:525:1da8:4af4 with SMTP id t37-20020a056a0013a500b005251da84af4mr55191739pfg.43.1657228121170; Thu, 07 Jul 2022 14:08:41 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id m17-20020a170902db1100b0016a275623c1sm20721984plx.219.2022.07.07.14.08.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 14:08:40 -0700 (PDT) Date: Thu, 7 Jul 2022 21:08:36 +0000 From: Sean Christopherson To: Yosry Ahmed Cc: Tejun Heo , Johannes Weiner , Zefan Li , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Oliver Upton , Huang@google.com, Shaoqin , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 2/4] KVM: mmu: add a helper to account memory used by KVM MMU. Message-ID: References: <20220628220938.3657876-1-yosryahmed@google.com> <20220628220938.3657876-3-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220628220938.3657876-3-yosryahmed@google.com> X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 28, 2022, Yosry Ahmed wrote: > Add a helper to account pages used by KVM for page tables in memory > secondary pagetable stats. This function will be used by subsequent > patches in different archs. > > Signed-off-by: Yosry Ahmed > --- > include/linux/kvm_host.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 3b40f8d68fbb1..032821d77e920 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -2241,6 +2241,16 @@ static inline void kvm_handle_signal_exit(struct kvm_vcpu *vcpu) > } > #endif /* CONFIG_KVM_XFER_TO_GUEST_WORK */ > > +/* > + * If more than one page is being (un)accounted, @virt must be the address of > + * the first page of a block of pages what were allocated together (i.e > + * accounted together). Sorry for the belated thoughts... If you spin a v7, can you add a note to call out that mod_lruvec_page_state() is itself thread-safe? Caught my eye because the TDP MMU usage happens while holding mmu_lock for read. > + */ > +static inline void kvm_account_pgtable_pages(void *virt, int nr) > +{ > + mod_lruvec_page_state(virt_to_page(virt), NR_SECONDARY_PAGETABLE, nr); > +} > + > /* > * This defines how many reserved entries we want to keep before we > * kick the vcpu to the userspace to avoid dirty ring full. This > -- > 2.37.0.rc0.161.g10f37bed90-goog >