Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Martin Blumenstingl <martin.blumenstingl@googlemail.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "edumazet@google.com" <edumazet@google.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "shuah@kernel.org" <shuah@kernel.org>
Subject: Re: [PATCH 0/2] selftests: forwarding: Install two missing tests
Thread-Topic: [PATCH 0/2] selftests: forwarding: Install two missing tests
Thread-Index: AQHYkglGod/4OBSADUyoR9bNezs0w61zfM6A
Date:   Thu, 7 Jul 2022 22:25:19 +0000
Message-ID: <20220707222519.movgavbpbptncuu6@skbuf>
References: <20220707135532.1783925-1-martin.blumenstingl@googlemail.com>
In-Reply-To: <20220707135532.1783925-1-martin.blumenstingl@googlemail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tH/o0VqMOdTUg2Z+bvH0QPiRgmS+xMgM0XatjY9mlJalursZ/dHv0Zn/hDrG?=
 =?us-ascii?Q?WsfEB62Kw4zap9ntDrd80sze1EnO/yHifLm6Dmgd4fzChohzHrFBQLDVzQy9?=
 =?us-ascii?Q?OuQ7VnPqzYUT1AGu/3jye+f5I/pFTpR1kWSSFC1qOBBv/mzPstdyz0i/qinD?=
 =?us-ascii?Q?6n3ZzZM8CqyQE4p4LdKqXAj4OXXjUimAbaR787/swZC5Bez7zoQB86Sx9JZv?=
 =?us-ascii?Q?oEn2bGaV402VxSG4JqskaMCytBnrLY86M+Po/s6x91jf13bqXifmMHSeH5y5?=
 =?us-ascii?Q?PEK5EgdDqfPKoBlx9Be7EgTr9vVdueLruos2hsnoGNAAhY54J7ysOpqhFzLt?=
 =?us-ascii?Q?0Shzp1bt1h5pNlwhH1MUeyb28bcJRtJ56qGGNmOJLxtqCaPgZTUWsoQPpLu2?=
 =?us-ascii?Q?ZEZ5v/NbOhg9coLmeyFcALjwBDG/g1IbqUbvWjA/an82VSu6jCq4HBAL8Aj/?=
 =?us-ascii?Q?R+4AbM/OpA3Vb6Ax3/J0QUHjpJbf3r9yCd2a93ara+wDS46FZv5NZPRIIXCi?=
 =?us-ascii?Q?YUR//Hp5LMZULFRZnUvCb2648h9oT6CFPrXeue4zDyoyIbVF5fsMSC3hFLPI?=
 =?us-ascii?Q?HwkkU8Hc21MmuoTKtkOlN7U4qzEReHe1U3SV3Gc8swtag6lcFEdNnux94RyN?=
 =?us-ascii?Q?Cg6IJrWQPpUEkBDHq7hiyZbIuV/0i1cGNT5IEsmMvlvSxqrp6LhsEJ4mQPto?=
 =?us-ascii?Q?Ed0veK3psfowSmZ18UNP60tXjUISUxmaaBWk9cDIQ7zXWG/atbJ0zodAwh6y?=
 =?us-ascii?Q?uXxCNU7a1XsOsoub7gSbB4D4QMj7c0NyH/rkGSJtEKVQ7iIDivfBFgR1NbW1?=
 =?us-ascii?Q?UQ522xP4nmRCc+UOOVVQUTzhI/qD8o1hNr1DdCgBcuhFVPrltfu8HO7EHVce?=
 =?us-ascii?Q?mdq18LWSsEDRj4RfLci7//i9nbXsVodebcyEcqGs3jz27fC1EFTRv5twizLf?=
 =?us-ascii?Q?GKykcIySrkwEbZUNJii+kTDWu5Il63vDsNw4u7N9KLvJSj5Ea6runDy+phPx?=
 =?us-ascii?Q?jIWa5GjgpIq3J7W6NS+uD8HoJ+X3LrpOLZoRa4GTrVYh6J6x6IyZ+xgMgDzG?=
 =?us-ascii?Q?fLIWoY+MAKQKJmpO48olFvbFw7Z3dxHAPKfTV8Z/RnDEe3B7nppJhttfzwPi?=
 =?us-ascii?Q?rZw8SzvWSy2mu2UWB0HuqWOLHSa3QgiHUPu1qn1D+fWYRpTURLB2VcIzLcVT?=
 =?us-ascii?Q?7BMu1eeu1H0pbC1PuD+G0CXl6yeis/ltm5jMULpV/HrITF9wa6z+yuZsbD2F?=
 =?us-ascii?Q?h1xxeJBUFSRj6q/OV7gEXFGOYyDgLjNGgLMUPQUDsrC2Yd9w/44BBwwMAwZR?=
 =?us-ascii?Q?icv7j5ibWfXD2RTnL5aJAedlblZXRym8p/09LQQJ1WwKYBcF0NzLHPrGXbPB?=
 =?us-ascii?Q?WXa4rZ5NQq8fI5TZDNmWsDZXuXtvx+RBK/jO6ZGBCo8rw0tWQRdMl5dB7QGG?=
 =?us-ascii?Q?5Q/k7r8BEWLXIwHZ3zS263nnlA5mgpZj0SxhdByRDj7/mvMInZ6J1EMFI173?=
 =?us-ascii?Q?psWP1JxAZiJ33YA/Vcfb0W2B/Mj/enVhDnv4gFxsgPV6+irq/7ClJNr9kSKJ?=
 =?us-ascii?Q?41NSsxKmnuduVO/5TzQCLK4etYIgJcWiyARX/gU7QMIJCu2VQHO0cJ6tBUdh?=
 =?us-ascii?Q?Qw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2D5D682C0E6F7D43989A29F36680B33D@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ce79f9b-050c-49f1-7da1-08da60679394
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 22:25:19.9601
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uLlSJOAOVgiapTTsfqqrC33pLjsGSX5bpT9JmyYMTIBZ4ii3oqgSuenrC44uTjcLdWZNr6BP2W+vJQ2J155lFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8390
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Martin,

On Thu, Jul 07, 2022 at 03:55:30PM +0200, Martin Blumenstingl wrote:
> For some distributions (e.g. OpenWrt) we don't want to rely on rsync
> to copy the tests to the target as some extra dependencies need to be
> installed. The Makefile in tools/testing/selftests/net/forwarding
> already installs most of the tests.
>=20
> This series adds the two missing tests to the list of installed tests.
> That way a downstream distribution can build a package using this
> Makefile (and add dependencies there as needed).

Just for future reference, the netdev process is to mark patch sets such
as this one with "PATCH net" since they fix a packaging problem with an
rc kernel. There's more information about this in
Documentation/process/maintainer-netdev.rst.

Do we need to create a Makefile for the selftests symlinked by DSA in
tools/testing/selftests/drivers/net/dsa/, for the symlinks to be
installed, or how do you see this?

The reason why I created the symlinks was to make use of the custom
forwarding.config provided there, and also to reduce the clutter a bit
and only focus on the selftests I felt were relevant for DSA for now.=