Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 7 Jul 2022 17:56:27 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Maksym Glubokiy <maksym.glubokiy@plvision.eu>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: extract port range fields from
 fl_flow_key
Message-ID: <20220707175627.7c6fc403@kernel.org>
In-Reply-To: <20220707083539.171242-1-maksym.glubokiy@plvision.eu>
References: <20220707083539.171242-1-maksym.glubokiy@plvision.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu,  7 Jul 2022 11:35:38 +0300 Maksym Glubokiy wrote:
> +/**
> + * flow_dissector_key_ports_range:
> + *		tp:     port number from packet
> + *		tp_min: min port number in range
> + *		tp_max: max port number in range
> + */

This is not valid kdoc, please see
Documentation/doc-guide/kernel-doc.rst

> +struct flow_dissector_key_ports_range {
> +	union {
> +		struct flow_dissector_key_ports tp;
> +		struct {
> +			struct flow_dissector_key_ports tp_min;
> +			struct flow_dissector_key_ports tp_max;
> +		};
> +	};
> +};