Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <33815bdd-3a30-594d-3304-8b81f2774190@quicinc.com>
Date:   Fri, 8 Jul 2022 09:33:42 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v14 00/12] Add soundcard support for sc7280 based
 platforms.
Content-Language: en-US
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
CC:     <agross@kernel.org>, <robh+dt@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <quic_rohkumar@quicinc.com>,
        <srinivas.kandagatla@linaro.org>, <dianders@chromium.org>,
        <swboyd@chromium.org>, <judyhsiao@chromium.org>
References: <1657200184-29565-1-git-send-email-quic_srivasam@quicinc.com>
 <Ysb7rZ4tIpN9fm8w@builder.lan>
From:   Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Organization: Qualcomm
In-Reply-To: <Ysb7rZ4tIpN9fm8w@builder.lan>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 7/7/2022 8:58 PM, Bjorn Andersson wrote:
Thanks for your time Bjorn!!!
> On Thu 07 Jul 08:22 CDT 2022, Srinivasa Rao Mandadapu wrote:
>
>> This patch set is to add bolero digital macros, WCD and maxim codecs nodes
>> for audio on sc7280 based platforms.
>>
>> This patch set depends on:
>>      [LPASS DTS: wcd related pinmux reorg]
>>      -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=657389
>>      [Clock DTS: reset control changes]
>>      -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=638002
>>      [Clock: External MCLK and reset control driver changes]
>>      -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=650267
> As far as I understand I can't apply this series until Taniya's clock
> patches has been picked up?
Okay. It seems Taniya's patches also in final stage of review.
>
>>      [Clock DTS: lpasscc node disable and lpasscore node name changes]
>>      -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=657325
> You're the author of these 3 other patch sets, so why are you asking me
> to stitch them together, instead of just sending me one series that I
> can easily apply.
Here 3 dependent patch series are of Clock Teams patches.  only patch 
from me is [

LPASS DTS: wcd related pinmux reorg] patch. Which is not dependent on any
other patch and can be applied directly as it's reviewed by. Will take care next
time and will combine patches wherever is possible.

>
> If you want your patches merged, make it easy for the maintainer to
> merge them!
Sure. Will take care next time.  For Now will keep it as it is, as it's 
independent patch and only one.
>
> Regards,
> Bjorn
>
>> Changes Since V13:
>>      -- Move digital codecs enabling to separate wcd specific dtsi file in CRD 3.0+ patches.
>>      -- Remove redundant output high setting in wcd reset node.
>>      -- Revert external mclk name.
>>      -- Update dependency list.
>>      -- Rebase as per latest kernel repository.
>> Changes Since V12:
>>      -- Update 'lpasscore' clock node name to lpass_core to match latest clock patches.
>>      -- Update external mclk0 name and it's source node.
>>      -- Move sound node to separate wcd specific dtsi file.
>>      -- Move CRD specific lpass_cpu node Enabling to separate wcd specific dtsi file.
>>      -- Update dependency list.
>> Changes Since V11:
>>      -- Remove output-low pinconf setting in wcd-reset-n-sleep node.
>>      -- Update dependency list.
>> Changes Since V10:
>>      -- Modify digital macro codecs pin control labels.
>>      -- Updated dependency list.
>> Changes Since V9:
>>      -- Move wcd codec and digital codec nodes to sc7280-qcard file.
>>      -- Modify the reg property as per link number in sound node.
>>      -- Fix the us-euro pin control usage in wcd codec node.
>>      -- Move wcd pin control nodes to specific crd board files.
>>      -- Sort max98360a codec node in alphabetical order.
>>      -- Modify the commit messages.
>> Changes Since V8:
>>      -- Split patches as per sc7280 CRD revision 3, 4 and 5 boards.
>>      -- Add corresponding dt nodes for herobrine crd boards.
>>      -- Update dai-link node names as per dt-bindings in sound node.
>>      -- Add reg property in sound node as per dt-bindings which was removed in previous series.
>>      -- Fix typo errors.
>>      -- Update wcd codec pin control properties in board specific files.
>> Changes Since V7:
>>      -- Remove redundant interrupt names in soundwire node.
>>      -- Fix typo errors.
>>      -- Remove redundant reg property in sound node.
>>      -- Rebased on top of latest kernel tip.
>> Changes Since V6:
>>      -- Modify link-names and audio routing in a sound node.
>>      -- Move amp_en pin control node to appropriate consumer patch.
>>      -- Split patches as per digital macro codecs and board specific codecs and sort it.
>>      -- Modify label and node names to lpass specific.
>> Changes Since V5:
>>      -- Move soc specific bolero digital codec nodes to soc specific file.
>>      -- Bring wcd938x codec reset pin control and US/EURO HS selection nodes from other series.
>>      -- Change node name and remove redundant status property in sound node.
>> Changes Since V4:
>>      -- Update nodes in sorting order.
>>      -- Update DTS node names as per dt-bindings.
>>      -- Update Node properties in proper order.
>>      -- Update missing pinctrl properties like US/EURO HS selection, wcd reset control.
>>      -- Remove redundant labels.
>>      -- Remove unused size cells and address cells in tx macro node.
>>      -- Keep all same nodes at one place, which are defined in same file.
>>      -- Add max98360a codec node to herobrine board specific targets.
>> Changes Since V3:
>>      -- Move digital codec macro nodes to board specific dtsi file.
>>      -- Update pin controls in lpass cpu node.
>>      -- Update dependency patch list.
>>      -- Create patches on latest kernel.
>> Changes Since V2:
>>      -- Add power domains to digital codec macro nodes.
>>      -- Change clock node usage in lpass cpu node.
>>      -- Add codec mem clock to lpass cpu node.
>>      -- Modify the node names to be generic.
>>      -- Move sound and codec nodes to root node.
>>      -- sort dai links as per reg.
>>      -- Fix typo errors.
>> Changes Since V1:
>>      -- Update the commit message of cpu node patch.
>>      -- Add gpio control property to support Euro headset in wcd938x node.
>>      -- Fix clock properties in lpass cpu and digital codec macro node.
>>
>> Srinivasa Rao Mandadapu (12):
>>    arm64: dts: qcom: sc7280: Add nodes for soundwire and va tx rx digital
>>      macro codecs
>>    arm64: dts: qcom: sc7280: Enable digital codecs and soundwire for CRD
>>      1.0/2.0 and IDP boards
>>    arm64: dts: qcom: sc7280: Enable digital codecs and soundwire for CRD
>>      3.0/3.1
>>    arm64: dts: qcom: sc7280: Add wcd9385 codec node for CRD 1.0/2.0 and
>>      IDP boards
>>    arm64: dts: qcom: sc7280: Add wcd9385 codec node for CRD 3.0/3.1
>>    arm64: dts: qcom: sc7280: Add max98360a codec for CRD 1.0/2.0 and IDP
>>      boards
>>    arm64: dts: qcom: sc7280: herobrine: Add max98360a codec node
>>    arm64: dts: qcom: sc7280: Add lpass cpu node
>>    arm64: dts: qcom: sc7280: Enable lpass cpu node for CRD 1.0/2.0 and
>>      IDP boards.
>>    arm64: dts: qcom: sc7280: Enable lpass cpu node for CRD 3.0/3.1
>>    arm64: dts: qcom: sc7280: Add sound node for CRD 1.0/2.0 and IDP
>>      boards
>>    arm64: dts: qcom: sc7280: Add sound node for CRD 3.0/3.1
>>
>>   arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts         |  37 ++++
>>   .../dts/qcom/sc7280-herobrine-audio-wcd9385.dtsi   | 155 +++++++++++++++
>>   arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi     |   8 +
>>   arch/arm64/boot/dts/qcom/sc7280-idp.dtsi           | 216 +++++++++++++++++++++
>>   arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi         |  73 +++++++
>>   arch/arm64/boot/dts/qcom/sc7280.dtsi               | 190 ++++++++++++++++++
>>   6 files changed, 679 insertions(+)
>>
>> -- 
>> 2.7.4
>>