Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 8 Jul 2022 14:33:07 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     Georgi Djakov <djakov@kernel.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/5] interconnect: qcom: icc-rpm: Set bandwidth and
 clock for bucket values
Message-ID: <20220708063307.GB195591@leoy-ThinkPad-X240s>
References: <20220705072336.742703-1-leo.yan@linaro.org>
 <20220705072336.742703-6-leo.yan@linaro.org>
 <28bf991f-7b4c-0af1-2780-842500b01a0f@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <28bf991f-7b4c-0af1-2780-842500b01a0f@kernel.org>
Precedence: bulk

On Thu, Jul 07, 2022 at 05:33:58PM +0300, Georgi Djakov wrote:

[...]

> > @@ -321,12 +365,11 @@ static int qcom_icc_set(struct icc_node *src, struct icc_node *dst)
> >   	provider = src->provider;
> >   	qp = to_qcom_provider(provider);
> > -	list_for_each_entry(n, &provider->nodes, node_list)
> > -		provider->aggregate(n, 0, n->avg_bw, n->peak_bw,
> > -				    &agg_avg, &agg_peak);
> > +	qcom_icc_bus_aggregate(provider, agg_avg, agg_peak, &max_agg_avg,
> > +			       &max_agg_peak);
> > -	sum_bw = icc_units_to_bps(agg_avg);
> > -	max_peak_bw = icc_units_to_bps(agg_peak);
> > +	sum_bw = icc_units_to_bps(max_agg_avg);
> > +	max_peak_bw = icc_units_to_bps(max_agg_peak);
> >   	ret = __qcom_icc_set(src, src_qn, sum_bw);
> >   	if (ret)
> > @@ -337,12 +380,23 @@ static int qcom_icc_set(struct icc_node *src, struct icc_node *dst)
> >   			return ret;
> >   	}
> > -	rate = max(sum_bw, max_peak_bw);
> 
> Looks like max_peak_bw is unused now?

Yes, will drop it in next spin.

Thanks for review.

Leo