Date: Wed, 30 May 2007 11:17:43 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: James Morris <jmorris@namei.org>, Ingo Molnar <mingo@elte.hu>,
       linux-kernel@vger.kernel.org, Stephen Smalley <sds@tycho.nsa.gov>
Subject: Re: [PATCH][RFC] security: revalidate rw permissions for sys_splice
 and  sys_vmsplice
Message-Id: <20070530111743.e638c841.akpm@linux-foundation.org>
In-Reply-To: <20070530071500.GU15559@kernel.dk>
References: <Line.LNX.4.64.0705291617260.9955@d.namei>
	<20070530071500.GU15559@kernel.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1107
Lines: 37

On Wed, 30 May 2007 09:15:01 +0200
Jens Axboe <jens.axboe@oracle.com> wrote:

> On Tue, May 29 2007, James Morris wrote:
> > Revalidate read/write permissions for splice(2) and vmslice(2), in case 
> > security policy has changed since the files were opened.
> 
> I guess it was inevitably going to happen :-)
> 
> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
> 

Probably acked-by was more appropriate.

James, is this considered needed-for-2.6.22?

> +	ret = security_file_permission(out, MAY_WRITE);
> +	if (unlikely(ret < 0))
> +		return ret;


ot: all the unlikely()s are irksome.  I wonder if there was some way of
doing this in security_file_permission() instead.  eg:

static inline int security_file_permission (struct file *file, int mask)
{
	int ret = security_ops->file_permission (file, mask);

	if (likely(ret == 0))
		return 0;
	return ret;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/