Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Michael Walle <michael@walle.cc>
To:     horatiu.vultur@microchip.com
Cc:     UNGLinuxDriver@microchip.com, alexandre.belloni@bootlin.com,
        colin.foster@in-advantage.com, kavyasree.kotagiri@microchip.com,
        linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org, maxime.chevallier@bootlin.com,
        Michael Walle <michael@walle.cc>
Subject: Re: [PATCH 1/2] pinctrl: ocelot: Fix pincfg for lan966x
Date:   Fri,  8 Jul 2022 10:27:52 +0200
Message-Id: <20220708082752.1745233-1-michael@walle.cc>
In-Reply-To: <20220707185342.2697569-2-horatiu.vultur@microchip.com>
References: <20220707185342.2697569-2-horatiu.vultur@microchip.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

> -static struct pinctrl_desc luton_desc = {
> -	.name = "luton-pinctrl",
> -	.pins = luton_pins,
> -	.npins = ARRAY_SIZE(luton_pins),
> -	.pctlops = &ocelot_pctl_ops,
> -	.pmxops = &ocelot_pmx_ops,
> -	.owner = THIS_MODULE,
> +static struct ocelot_match_data luton_desc = {
> +	{
.desc = {

Same for all the structs. Also it looks like it is way too big
for a stable backport:
 "It cannot be bigger than 100 lines, with context."

> +		.name = "luton-pinctrl",
> +		.pins = luton_pins,
> +		.npins = ARRAY_SIZE(luton_pins),
> +		.pctlops = &ocelot_pctl_ops,
> +		.pmxops = &ocelot_pmx_ops,
> +		.owner = THIS_MODULE,
> +	}
>  };

-michael