Date: Wed, 30 May 2007 15:09:37 -0400
From: Bill Nottingham <notting@redhat.com>
To: Satyam Sharma <satyam.sharma@gmail.com>
Cc: Roland Dreier <rdreier@cisco.com>, openib-general@openib.org,
       linux-kernel@vger.kernel.org
Subject: Re: dealing with gcc 'comparison is always false' warnings (was:
	[PATCH] drivers/infiniband: fix comparsion between unsigned and
	negative)
Message-ID: <20070530190937.GA5444@nostromo.devel.redhat.com>
Mail-Followup-To: Satyam Sharma <satyam.sharma@gmail.com>,
	Roland Dreier <rdreier@cisco.com>, openib-general@openib.org,
	linux-kernel@vger.kernel.org
References: <20070530080518.GA29195@nostromo.devel.redhat.com> <adazm3mqqh3.fsf@cisco.com> <a781481a0705300841k2a02335eg66985129eaed28f4@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a781481a0705300841k2a02335eg66985129eaed28f4@mail.gmail.com>
User-Agent: Mutt/1.5.14 (2007-02-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 835
Lines: 21

Satyam Sharma (satyam.sharma@gmail.com) said: 
> But yes, the kind of "fixes" you pointed out that _remove_ these conditions
> are definitely *not* what we would want to do.

I can see that - but I think it should be at least be brought up for each
warning, to determine either:

1) if it should be ignored
2) if a signed type is actually intended
3) if the code should be elided

While not necessarily in the IB instances, there are cases where there
are entire blocks of code (with debugging output, error returns, etc)
that can never get run, and it may make sense to remove those.

Bill
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/