Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20220707182052.769989-1-justinstitt@google.com>
References: <20220707182052.769989-1-justinstitt@google.com> <20220706235648.594609-1-justinstitt@google.com>
To:     Justin Stitt <justinstitt@google.com>
Cc:     dhowells@redhat.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, linux-afs@lists.infradead.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
        marc.dionne@auristor.com, nathan@kernel.org,
        ndesaulniers@google.com, netdev@vger.kernel.org, pabeni@redhat.com,
        trix@redhat.com
Subject: Re: [PATCH v2] net: rxrpc: fix clang -Wformat warning
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1840088.1657273144.1@warthog.procyon.org.uk>
Date:   Fri, 08 Jul 2022 10:39:04 +0100
Message-ID: <1840089.1657273144@warthog.procyon.org.uk>
Precedence: bulk

Justin Stitt <justinstitt@google.com> wrote:

> y is a u32 but the format specifier is `%hx`. Going from unsigned int to
> short int results in a loss of data. This is surely not intended
> behavior. If it is intended, the warning should be suppressed through
> other means.

Yeah, y is reduced to a 16-bit number so that it can be used in the protocol,
but the type is still 32-bit because that's needed for the calculation.  An
alternative would be to print sp->hdr.cksum since that's the value that will
appear on the wire, but I've no objection to this change either.

> This patch should get us closer to the goal of enabling the -Wformat
> flag for Clang builds.
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/378
> Signed-off-by: Justin Stitt <justinstitt@google.com>

Acked-by: David Howells <dhowells@redhat.com>