Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f05a9b04-b635-df6f-1c94-b44371d24041@intel.com>
Date:   Fri, 8 Jul 2022 13:33:37 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.10.0
Subject: Re: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32()
Content-Language: en-US
To:     =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= <peter.ujfalusi@linux.intel.com>,
        <andy@kernel.org>, <broonie@kernel.org>
CC:     <alsa-devel@alsa-project.org>, <tiwai@suse.com>, <perex@perex.cz>,
        <amadeuszx.slawinski@linux.intel.com>,
        <pierre-louis.bossart@linux.intel.com>, <hdegoede@redhat.com>,
        <ranjani.sridharan@linux.intel.com>,
        <linux-kernel@vger.kernel.org>, <lgirdwood@gmail.com>,
        <kai.vehmanen@linux.intel.com>, <yung-chuan.liao@linux.intel.com>
References: <20220707091301.1282291-1-cezary.rojewski@intel.com>
 <aecaf6aa-12b0-05bb-8ad4-8d09ca4eff10@linux.intel.com>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <aecaf6aa-12b0-05bb-8ad4-8d09ca4eff10@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXBjTlBzMENyYmlkSDZBS2I0TWxadVh3bGtvTitOL2pVMUQwajNrWmJ0WE12?=
 =?utf-8?B?T1g2NTE5TTJWaHlxUDk4Tm9JSk9nTjkyaGZqVGd0cTBhL1hUdWF5SHV0Wkd3?=
 =?utf-8?B?TlRSNDFtMWh3NnN6S2tVdTNFQkF6elIyUGNjL1lad3BOZkt0ZCsrZWlFZDNW?=
 =?utf-8?B?NDlBVWZ1YXZZcHd3ZGF5VkFMR2g4dGNaK3hUNThvRTkyeVg1Vkc4dUYraGl2?=
 =?utf-8?B?OVRTL09GMFNrd09ZY2xLbmJOYVVXdjcyMlE4MDNhZUMzdlUvaUtScjdWNjEr?=
 =?utf-8?B?c0VUTkU0dWJHMkZRZUR5Y3p4dThlS3BQWFBtNExKQ1BteVRkOVU4Vnh4WUNa?=
 =?utf-8?B?VjN3VElaYkhIbGs4U1RWWjVtaUxMc3EzNmhKSWRHV0FpUVVCNTRDU3lFU1JU?=
 =?utf-8?B?Q0pmelBVNjI4ZldnZGF0enEyUHdNQ0RLSzkyTTNPZnRpWDNtblU0M2lUeWdP?=
 =?utf-8?B?MHEvVWgyY1RHK3kzUUZFaHBQVWFzSHFiK2dZMEhlYzFwZS81MzdTZU9vUUN4?=
 =?utf-8?B?WUYyZktLa2xzSSs2WSs5cmJOUEhxdmsvUko5QmpJK0NmTll6Y2RtR09KemdI?=
 =?utf-8?B?NTh3OGcvaEJhbzNkYTJBR2ZRM0JJSU5mRDU1MDdFT2VFQTdudzI0SGZwSVpa?=
 =?utf-8?B?V0lnZk1zQUFxc2VmZFRUNm1WYlpHK000VjNzTi94NlRMRndYS3ZzOXE5Y2pW?=
 =?utf-8?B?V21OS2NMaVFLTzdpVjNpcGE2ZWQ1RURBK2MzdUhFN0Q1UTY3NE9pNm5yWWhw?=
 =?utf-8?B?N1l4TFJyUjRUZmdTZU5uUDFxbVh6MllScXcyYTVYSWNneUp3Y1Rha3o0NmRD?=
 =?utf-8?B?N1N6SzZMa2pUTkVETjA0MW5sNWhiejhaY2pQbFZFTHNzSENMcmJ6TDdLZlk1?=
 =?utf-8?B?YlJNRlQ5Y0R2MGh2dkhEMi82ZFlVTEJlU3JRbnFoazcvdkpTcVQyTWVEMGdm?=
 =?utf-8?B?SzdVV2gyZ3YwUjF0bzFpa1Uzc3Y2YjlvZmxEaXBERyt5aUtTaXVtNnl0WUk2?=
 =?utf-8?B?RVRNYUowV0drcnl1enphYkZPMGMrSmQ1aFduejU3SDltTHlrbkEwYkxDUGhK?=
 =?utf-8?B?OTkySnQyV2RrUThiNUZkM2c4ZXkzclhQaUVsbHErYlhyTkpLRWlwb3d3aFdk?=
 =?utf-8?B?VTl4MTd3TGhOZE9ZWTNJUUdmZFQyeUVlRG92U3NqSEMySG1GMXVvVG9neHZn?=
 =?utf-8?B?VTlwYWFlV3llRnNmQXVEbnEzOGxNdFFKQS9Yc3V5dXdaZDZ1MHhpS0dzQ3JM?=
 =?utf-8?B?OFlPcGxPSVAvajFTYVh1NkYxQXlWSzlvbkxDbVd6NDdkMVRpblk5SWpLUTA1?=
 =?utf-8?B?aWxiYWE0dEw1TUNablRKYks3eEZvM2RtL3NJRUdoQk1JWmJoc1Y2U0oyWUVP?=
 =?utf-8?B?ZTJFWFQ3eGVIR0NmZUd2QXM1UkVKUHovczFZTTl3R21qbEVFWXR0UVFpRlcr?=
 =?utf-8?B?MTdRSTVlOVhERWNvMWNOc1Bmc3pYMXhNSGErYjB0bUhzcVJXWUFrYWkzWFNv?=
 =?utf-8?B?MEM1Y0Z3NkQraHJzdm9vbXA5WEhkZnh0c1VqRUhPYXgxdmc2MVdkZHJudkh6?=
 =?utf-8?B?WmxsSFNRK3hCaWpxd0prYWhGN2QrZkgwa0tkOW9aYWw0bVlrdWJoMGVRVnVQ?=
 =?utf-8?B?OVlOU0VsdXd4MEM3VVZRRjY2WGJCbXRKQ053MWJLV1BtZ2hBaENZVzh5NTVK?=
 =?utf-8?B?b1dwd2FmTkZPb0tIY1ZNWlB4bUZCNmxlQVNXS1Z0VjNZS1NzNllPcDVFTUdC?=
 =?utf-8?B?ajVXQTVoeURKaE96ZythUVBYbHcwZU5BQ25Xb2J0dkk5VVJHS3laeVFHdVBS?=
 =?utf-8?B?RVZuVFo5eEZSS2lOcHQ1T0E1TWZ6bHJjNlBoQzhwSnNrOUhFY0tidkd4ZzYv?=
 =?utf-8?B?NXQwVWtOUWRsSlZRcktOSEZVM3lJTmwrQ0ZZcEh3WHFjQ3Q2aERBeWRJUUtq?=
 =?utf-8?B?cVBaN3R1UzN6dTVmWE1SMHJvNFRqczJvOGdzYkFIUXVraTdlYlE4Uzc0b0RF?=
 =?utf-8?B?dU00V3hJSW0yek14YmRiMlg4M2p5eVRyaXJrdlFjWVlTRjRHU0J0OEpPNCtO?=
 =?utf-8?B?N2NsN0dCWE1LdHJyMzBVWTVYcGlheW8rVzdkQlQ1QlJHRExvRFFSVVA3ZEZp?=
 =?utf-8?B?anR5M3JUS1VMbXNEK0pzSDczOEN3b2wzVzNFTEFsWGxLRGRKY0RhaDVaQkx3?=
 =?utf-8?B?d0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 373391c2-b6fe-4b3c-abf3-08da60d5b733
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 11:33:44.5357
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KtDBJTTKr+z5UYs0wL0iCUfqSywFY7iPNjUtpT9GkmUyrVyhkai70XMABLGBvcoUGl5J+prsHT1ZDxB39s2cWMS5rpbogGZpOKu+p8einOc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3923
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-07-07 3:51 PM, Péter Ujfalusi wrote:
> On 07/07/2022 12:13, Cezary Rojewski wrote:

...

>> +int strsplit_u32(const char *str, const char *delim, u32 **tkns, size_t *num_tkns)
>> +{
>> +	size_t max_count = 32;
>> +	size_t count = 0;
>> +	char *s, **p;
>> +	u32 *buf, *tmp;
>> +	int ret = 0;
>> +
>> +	p = (char **)&str;
>> +	*tkns = NULL;
>> +	*num_tkns = 0;
>> +
>> +	buf = kcalloc(max_count, sizeof(*buf), GFP_KERNEL);
>> +	if (!buf)
>> +		return -ENOMEM;
>> +
>> +	while ((s = strsep(p, delim)) != NULL) {
>> +		ret = kstrtouint(s, 0, buf + count);
>> +		if (ret)
>> +			goto free_buf;
>> +
>> +		if (++count > max_count) {
> 
> I think this should be as it was originally:
> if (++count >= max_count) {
> 
> Otherwise when we reach the max_count we would not realloc to get more
> space and the data + max_count is pointing outside of the allocated area.

I believe you're right. Will change in v2.


Regards,
Czarek