Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Message-ID: <trinity-05389b8f-a479-47b6-bc3b-5a02b4804627-1657282571466@3c-app-gmx-bs34>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Vinod Koul <vkoul@kernel.org>
Cc:     Peter Geis <pgwipeout@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "open list:GENERIC PHY FRAMEWORK" <linux-phy@lists.infradead.org>,
        arm-mail-list <linux-arm-kernel@lists.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Heiko Stuebner <heiko@sntech.de>
Subject: Aw: Re: [BUG] USB broken on rk3568 based R2Pro
Content-Type: text/plain; charset=UTF-8
Date:   Fri, 8 Jul 2022 14:16:11 +0200
Importance: normal
Sensitivity: Normal
In-Reply-To: <Yse9nz9jjRoiPq6K@matsya>
References: <trinity-54ed588d-4b2c-4177-83b0-4eda8ff16a42-1657210235522@3c-app-gmx-bap68>
 <trinity-ec3b4258-cb12-42c2-9058-362260a275d2-1657216287085@3c-app-gmx-bap68>
 <CAMdYzYrs0oJXVcViOmJk4E7PSTeP5TYs0O_ePHmrcAiKtOAWXQ@mail.gmail.com>
 <Yse9nz9jjRoiPq6K@matsya>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi

Samuels Patch fixes my issue

https://patchwork.kernel.org/project/linux-rockchip/patch/20220708061434.3=
8115-1-samuel@sholland.org/

regards Frank

> Gesendet: Freitag, 08. Juli 2022 um 07:16 Uhr
> Von: "Vinod Koul" <vkoul@kernel.org>
> On 07-07-22, 15:41, Peter Geis wrote:
> > On Thu, Jul 7, 2022 at 1:51 PM Frank Wunderlich <frank-w@public-files.=
de> wrote:
> > >
> > > Hi,
> > >
> > > traced it down with manual reverts to this one:
> > >
> > > commit 6a98df08ccd55e87947d253b19925691763e755c
> > >     phy: rockchip-inno-usb2: Fix muxed interrupt support
> > >
> > > luckily i can revert only this and now upper usb-port works again
> > >
> > > @samuel: have you an idea how to fix your problem without breaking m=
y board? :)
> > >
> > > @greg/Vinod: maybe we can add a revert of this in mainline till issu=
e is resolved?
>
> Lets give it a few days if we can find a fix, if not we can revert
>
> > >
> > > regards Frank
> >
> > I don't know what you're running, but with the standard arm64
> > defconfig w/ all rockchip stuff built in, I have no issues here on
> > 5.19.
>
> Please share the config and other details on what your running so that
> Peter can repro this...
>
> > Note, the following changes are necessary to the 5.19 dts here:
> > Remove the extcon from usb_host0_xhci, as the production model doesn't
> > have automatic switching capabilities. The ID pin was removed in favor
> > of the usb debug function which also doesn't work.
> > Add dr_mode =3D "host" to the same node, for the same reason.
> >
> > >
> > >
> > > > Von: "Frank Wunderlich" <frank-w@public-files.de>
> > > > i noticed that upper usb-Port (otg) is broken on my Bananapi R2Pro=
 with 5.19-rc1, works with 5.18.0
> > > >
> > > > this port is a usb3 (xhci) port which includes an usb2-phy and sho=
uld support otg, but i still want
> > > > to use it in host-only mode (USB-A socket).
> > > >
> > > > already tried setting dr_mode in dts back to "host" as this was ch=
anged in rk356x.dtsi by this commit:
> > > >
> > > > bc405bb3eeee 2022-04-25 arm64: dts: rockchip: enable otg/drd opera=
tion of usb_host0_xhci in rk356x
> > > >
> > > > i see no error in dmesg and usb-controllers seem to be initialized=
 completely (visible in lsusb).
> > > >
> > > > r2pro has ID-Pin not connected, so i tried also peters Patch witho=
ut success :(
> > >
>
> --
> ~Vinod