Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a665668a-4a10-d39e-d879-7f43aafad333@gmx.de>
Date:   Fri, 8 Jul 2022 14:47:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v6 1/2] highmem: Make __kunmap_{local,atomic}() take
 "const void *"
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>,
        "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     David Sterba <dsterba@suse.com>, Chris Mason <clm@fb.com>,
        Josef Bacik <josef@toxicpanda.com>,
        Nick Terrell <terrelln@fb.com>, linux-btrfs@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Ira Weiny <ira.weiny@intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        Kees Cook <keescook@chromium.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        "James E. J. Bottomley" <James.Bottomley@HansenPartnership.com>,
        John David Anglin <dave.anglin@bell.net>,
        linux-parisc@vger.kernel.org, David Sterba <dsterba@suse.cz>
References: <20220706111520.12858-1-fmdefrancesco@gmail.com>
 <20220706111520.12858-2-fmdefrancesco@gmail.com>
 <20220706120712.31b4313f17cb7ae08618c90e@linux-foundation.org>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220706120712.31b4313f17cb7ae08618c90e@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 7/6/22 21:07, Andrew Morton wrote:
> On Wed,  6 Jul 2022 13:15:19 +0200 "Fabio M. De Francesco" <fmdefrancesc=
o@gmail.com> wrote:
>
>> __kunmap_ {local,atomic}() currently take pointers to void. However, th=
is
>> is semantically incorrect, since these functions do not change the memo=
ry
>> their arguments point to.
>>
>> Therefore, make this semantics explicit by modifying the
>> __kunmap_{local,atomic}() prototypes to take pointers to const void.
>>
>> As a side effect, compilers will likely produce more efficient code.
>>
>
> Acked-by: Andrew Morton <akpm@linux-foundation.org>

Acked-by: Helge Deller <deller@gmx.de>  # parisc

> Please include this in the btrfs tree if/when [2/2] is added.

Yes, agreed. Please take both through btrfs.

Helge