Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 8 Jul 2022 16:35:35 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Akhil R <akhilrajeev@nvidia.com>
Cc:     dmaengine@vger.kernel.org, jonathanh@nvidia.com,
        ldewangan@nvidia.com, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, p.zabel@pengutronix.de,
        vkoul@kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: dmaengine: Add compatible for
 Tegra234
Message-ID: <YshAt5WAG9zUkrpy@orome>
References: <20220707145729.41876-1-akhilrajeev@nvidia.com>
 <20220707145729.41876-2-akhilrajeev@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="7KrFkS22rogEsCYQ"
Content-Disposition: inline
In-Reply-To: <20220707145729.41876-2-akhilrajeev@nvidia.com>
User-Agent: Mutt/2.2.6 (2022-06-05)
Precedence: bulk


--7KrFkS22rogEsCYQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 07, 2022 at 08:27:27PM +0530, Akhil R wrote:
> Document the compatible string used by GPCDMA controller for Tegra234.
>=20
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
>  .../devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml         | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dm=
a.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> index 9dd1476d1849..81f3badbc8ec 100644
> --- a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> @@ -23,6 +23,7 @@ properties:
>      oneOf:
>        - const: nvidia,tegra186-gpcdma
>        - items:
> +          - const: nvidia,tegra234-gpcdma
>            - const: nvidia,tegra194-gpcdma
>            - const: nvidia,tegra186-gpcdma

I don't think this works because it will now fail to validate Tegra194
device trees. You'll need to create a separate set of items for
Tegra234.

Thierry

--7KrFkS22rogEsCYQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmLIQLcACgkQ3SOs138+
s6F9wA/+PevJYM9sYGjtbmt0Td1G/xEVvLlkGtAzYtC2f2I9YJl43ag4RwxvG3ok
/i366YAeBcA61nBwuLsnPflTivsKa8W6MXUGByTJOCBsNYq5S3LGsqSi0KlsD1Xr
ARLkiz3WDyncUohNXOOBxGEzEOrO/YT/7Itb8dwr1ig5T+W0PtumgVnAH86iX+DM
mpiwLHuWFqMwU/tziEiR+JyzK6EYAwS3STDuCeaiGw7siF+cuf08Z8zmvwNU47sv
iIwwdPaSDvKVPyKRbl/YwJbbMkas4lF1itH0DhImspBbUEZIGTjcf1U7G8mrVSKL
HAj+S6rmhHM7cP1V99zcAQIDamEaWko9rGtrE7ihKpWG0R5Q+6+7qyZ08g6HeZ7S
aAA/uEhPU+SCy7Bc4wp13/fupQsSLmekewcNUSBSQXO1ZiQ6P9Lx+tkzNVT+xuk5
wev7ncXsqG8k2p1uv/EhvlA/LvHZ5V0obqcmhJB63tlDyncgdr+YmB4r3XHG4uB2
DseZSKeX6xqAhTOSC9FRmDcuNVoK6kllfbvY4xqpxiPmIc6drbEKan8FdqQVsKi+
YO3W+4fvigR+Bx9k7oCvTlSLko6iUkvlifessg4Du9zZW23+/FT7svBxL4uHSwEx
ozKor/mOpEdsHoe1FE8TQ38KpV9+XWzc9J7mjPc1LiFclEZ85a0=
=fR/G
-----END PGP SIGNATURE-----

--7KrFkS22rogEsCYQ--