Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 8 Jul 2022 07:59:22 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Matthew Wilcox <willy@infradead.org>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-pci@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/3] xarray: Introduce devm_xa_init()
Message-ID: <YshGSgHiAiu9QwiZ@iweiny-desk3>
References: <20220705232159.2218958-1-ira.weiny@intel.com>
 <20220705232159.2218958-2-ira.weiny@intel.com>
 <YshE/pwSUBPAeybU@casper.infradead.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YshE/pwSUBPAeybU@casper.infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RSUuWlU9AgLx24MNqBl7GBgA3vuMpJ8qkL8Qk4E5kNR5BNz/Cxy7hQEkXMVK?=
 =?us-ascii?Q?O0em21APNEyvTFEvht6gCSI1v8El30MeywMAsC/Ug2dsM+qDmSkZ274fAzVH?=
 =?us-ascii?Q?CWIXrS3V82ag1pHCIZAjZvyIMoZwFct1ZHzthhdYmurJwT22xs/H+BmsgL+o?=
 =?us-ascii?Q?ADEszjxoY3p/BqbGr8Xj+Pz81J+q3WT2QOe9uE8jNVi2+bbOpbRBPyFHK4ju?=
 =?us-ascii?Q?HCHZlAZYH2RyFqtAp3Od4dB1XMru0J4mnIDPhve117r0eCdW2wlUN8xebVCp?=
 =?us-ascii?Q?HhmG5YxijDJGMWpYRbrzvPsl/X6JIwwescwMHMIKbfcAU2AtAKzOcSZAZ89b?=
 =?us-ascii?Q?bifO+4XvEX1X9juG4OOAm8KqNKsUH/ZRYhb8c6XOCMd+vvjc+IzpiG5D835y?=
 =?us-ascii?Q?Fdq1ngWs32+BpSTHJZbGXtAa0obGSHX8lTK4b8+nQP4b/rByRehlxLt+s+8N?=
 =?us-ascii?Q?EPF30rR2Cgu8vTAVPCcg2P2sunITT6ZxLLiHQ36puO1uh6tPwxCtzrsLs+vB?=
 =?us-ascii?Q?JgPZUJx4dS/18c9hqONktEISxNf/1zD1twieZ2GjHfWRNx8ndzXGmwe7mrPw?=
 =?us-ascii?Q?2NojpajuJPsFFAJ13ynZZKpsu3aAY9Zm1a8OpBGnJfuUvpCOvyHSpoTsbyVy?=
 =?us-ascii?Q?cZJF9FNwtvK7blQdjgh8oiq6K1ggC/eIdelILzRp8NrIi6S82yw892Xo24FX?=
 =?us-ascii?Q?7txP8fMtRCDZV/igCmeixv//vxWLy0dr9k2+0Qnr4E3/sd4gnHsLC4uayyx/?=
 =?us-ascii?Q?NPa3q0jL28NT9FSSuZTXHA8g+I7zrgGEX4j40aokC1bhys5NRj+EnRcgQauV?=
 =?us-ascii?Q?rpSRNtzk1EWVzhc3415/8Qa7hCco3Vgpx3ThXsgQRhRjMK9SYimRX+1DX4Ls?=
 =?us-ascii?Q?9grak9+c17sJqm2tKrse4hBTzysjx81/MddIf6xd4E7mKMOLp3O0M1qzSjlu?=
 =?us-ascii?Q?HxeYIeNB4nbV1fWJtAwAtPWUFi/qK4agZsJ59gRYKXWy/sSdAj/1uRS0+bA7?=
 =?us-ascii?Q?VkhXb7bn031LGdzCGn0kngTBd3RBS27hPrr/0U6+KgjaDuwUM1lYdK8VLqyZ?=
 =?us-ascii?Q?hdESV31B35QSxDGeilnH6lsJtIDWl4adLUOgRrKKpzbK6VHZumrHpZqIEVLU?=
 =?us-ascii?Q?gcyz42As//atjglsIFxYlfxIDF/cjpwYWWJFyOMZ329GlJfp9Y77MVXzJQIl?=
 =?us-ascii?Q?bal0ACUaOSm+9z5hoNd7JCBM396IER5wkgbJS73s4HX6W8XSrtCFz8tx0QBl?=
 =?us-ascii?Q?eqUP3xNi/Y4W6bNYbSmoHvS83PhXbW8KWpyAmTXAYexy1qtNJPvOQyIzS6rE?=
 =?us-ascii?Q?8jvtu4YnHlc/EEFGwv0yi4ZbhTRFkyy6rUSGNoTn2aum/GdjByFYAuNRJwlx?=
 =?us-ascii?Q?42lYyXifdH47d5X/ILA6a58TSk+oVACEc/u6FWzWe2LcG2awRyPh7bOYS+Yh?=
 =?us-ascii?Q?3/oaIO3EWV28bN90fp/jOlbwvHGqRVBxNVDUR7ktoHdWCeUYB8kHpidqk6dt?=
 =?us-ascii?Q?BElx9D6dmfWSiN5wo6iwCR7ky7VKomxXLyOS3AgtPAregpbicTNFFg96r5KV?=
 =?us-ascii?Q?p4EDAihOtksI87TfWCUbDttfy3uScFDuiBjr57jeo7gRPqL2FTNGYRslRjtT?=
 =?us-ascii?Q?Hv8MvquLdFba0w5B70no4KHLR7U8+URDmvkTAhXK+VIp?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fd1dd41e-2214-4256-53f0-08da60f274b9
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 14:59:28.4094
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5w1mXOTjpceWkg0bBCVf7wBpPR1PKt4+t8DdeZGzi5lTHJAXyrYU6BTwr7D3BpDB+2AjQcQ2N1kbBuT6ujJu8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5383
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 08, 2022 at 03:53:50PM +0100, Matthew Wilcox wrote:
> On Tue, Jul 05, 2022 at 04:21:57PM -0700, ira.weiny@intel.com wrote:
> > The main issue I see with this is defining devm_xa_init() in device.h.
> > This makes sense because a device is required to use the call.  However,
> > I'm worried about if users will find the call there vs including it in
> > xarray.h?
> 
> Honestly, I don't want users to find it.  This only makes sense if you're
> already bought in to the devm cult.  I worry people will think that
> they don't need to do anything else; that everything will be magically
> freed for them, and we'll leak the objects pointed to from the xarray.
> I don't even like having xa_destroy() in the API, because of exactly this.
> 

Fair enough.  Are you ok with the concept though?

Ira