Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 8 Jul 2022 07:45:12 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Bjorn Helgaas <helgaas@kernel.org>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-pci@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC PATCH 2/3] pci/doe: Use devm_xa_init()
Message-ID: <YshC+Jaua01dPQak@iweiny-desk3>
References: <20220705232159.2218958-3-ira.weiny@intel.com>
 <20220707160646.GA306751@bhelgaas>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220707160646.GA306751@bhelgaas>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ancaAX0UbEPPfnjF2ugkglsl+jBdIvzHANHwU18Yzy/lOI9Zb/ddc7+u/9dP?=
 =?us-ascii?Q?mfwfNu0M7KGgmrgGx5Lbzo7c4d9VqamsVxxs6cO7CZtQvtZ5OjsOyYfictmQ?=
 =?us-ascii?Q?nO6OeGMZXyJXLn0HUKD7rbOF5lm6xrZR+jJee6mT882+eV/Fkk461KJiqhcj?=
 =?us-ascii?Q?KPBA2cbAHmjKoawg+xtEOFT1kGtSCxBfIiib/feaxj8WzfFdyouzNUVFzxCd?=
 =?us-ascii?Q?GJesPcyGN0pIkV2LQD/QZwGFvSeG/wGBsQi5xq9PhNI5dcx1M2jpfuZITZL3?=
 =?us-ascii?Q?YZBgs5bW5KFZ4yHoehE49Bb/1sQCPE4I236vLIlqsqptCne4psYA0Ceyec35?=
 =?us-ascii?Q?dYd+z9F30VJrpfbfcxrBOL2uXSPzG3Ffc6qv2rVkAFsJGPNZMO0BbZiyg4OD?=
 =?us-ascii?Q?ecI2aRR8yiF/jAi6wDmuM85yT08L5VemNs2M6MMmjY5Kyz8OtdP7GrV8uhgb?=
 =?us-ascii?Q?Ig27Uf5DiJOB+fbbkTDETiVm5Uj58GPv5i7Tw9k1Akkiu9z+ikCtIq+47n62?=
 =?us-ascii?Q?TdnCZGrRFtZmW/iD4RSUsS8iQuSbvd3R2Yrd7E1rcQf12gaRpLLQTJcnFDkV?=
 =?us-ascii?Q?iKHlPcrwDB9XwvK4KlAqJ6ev+HP89HfAx1pO5Tz3Yz9k6D+a/7pgbjztJDlF?=
 =?us-ascii?Q?NeY4zwVM+G+EoTyui5qPKW0h7hXHFuoiTA1JR9fvSTxDg1G/EsmM/dS7th3r?=
 =?us-ascii?Q?K18lxwXr8FQkaXryM2Vuf+c73NMdYAnLXYp6liCLD0hm62qouEHCY2YWrc4O?=
 =?us-ascii?Q?ivMkPv1RhvPb/gONh62ZKqaOCMhAp/paOy4sL6CUp8QkK/X+t6+mYQ7rIl5i?=
 =?us-ascii?Q?NdGviYuB0y3IFHZtvBAHeVdutGKzd/ZJCUfYQEBoBZjUB08PmN1n7ZdabU1l?=
 =?us-ascii?Q?IZ6HleLElLg0u/ACcn93mzlzQdqXFqniaJKAF+gqTWbACcLOLT+cen9inVtm?=
 =?us-ascii?Q?/BVnJzsHCsDAUAHraOTlQblMSUEkYRTd+pjy/ysuyVwPcKrxsvwQ4EMqf0oz?=
 =?us-ascii?Q?mA0tAaEm31mTnH8KINjiO5BsljnwvWgQGbrNpPgm3ulGnJ0V3oQMJhbccENH?=
 =?us-ascii?Q?P4Ro8VbqNlLVE+M5rNb7d7o8CP9UY6w9BwMsY/92Bzwd5+MNKgJsgzChwfb2?=
 =?us-ascii?Q?egcuh+Y1aFQBlVeDUOewYVxjdfOrUrYc0NeiyVJ280kBtwY1OVE3+78q4/e8?=
 =?us-ascii?Q?iI3tcpUCa2jnBGb6ChCVqhW+Ic+N46/yLEbAIntaAVIrZtQIXlzrpREjbVFz?=
 =?us-ascii?Q?uM/7BRaF1LjHtGTWhFqbGmW1COs2YMHFQxXRtn58FcaNFkq4+aip5l4xT1i/?=
 =?us-ascii?Q?Yz0DOhBTqv2fezfEqZ+rWjJD3k/VWNDTFNsCR/aMo+nfHvG3ebWXk4ua8RQw?=
 =?us-ascii?Q?O9DMLohUgZ+xYJakgaQ0mtzs4P5vo//3WRPwYyTkmDWP3awMyml+JKfVu3Ud?=
 =?us-ascii?Q?nBLs8CcAwu9BuAvxlOjgfuyMcp4QpkahEeHdXOIgedfsHkWwnmd4rRLVQW6O?=
 =?us-ascii?Q?+0IfRDiuxnlw8d/zZERoOqsy0U6HON6uuNwo64APaCmwm+bP+I8af+DULwki?=
 =?us-ascii?Q?smT3/09S9tcEwz8M4m57L19xG7kYioqURItfq8spV1I4Wpn0F6oYgzCmCdYp?=
 =?us-ascii?Q?SszyzgC3zr+Vc8shV6RdasU1OHuscI70o1cE+RTq8HGT?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c4cc467-b9a4-4fc2-cb72-08da60f07a44
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 14:45:18.7655
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +3OZVGB0ojlSOio4azqG8uRxlCFIErMa+3I0Y/dOLRCTAfTCi3tGzIKXY43TX44rKVD0SaHVDHIIX4to5DqVbw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2199
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 07, 2022 at 11:06:46AM -0500, Bjorn Helgaas wrote:
> On Tue, Jul 05, 2022 at 04:21:58PM -0700, ira.weiny@intel.com wrote:
> > From: Ira Weiny <ira.weiny@intel.com>
> > 
> > The XArray being used to store the protocols does not even store
> > allocated objects.
> 
> I guess the point is that the doe_mb->prots XArray doesn't reference
> any other objects that would need to be freed when destroying
> doe_mb->prots?

Yes.

> A few more words here would make the commit log more
> useful to non-XArray experts.

I'll update this to be more clear in a V1 if it goes that far.  But to clarify
here; the protocol information is a u16 vendor id and u8 protocol number.  So
we are able to store that in the unsigned long value that would normally be a
pointer to something in the XArray.

> 
> s|pci/doe|PCI/DOE| in subject to match the drivers/pci convention.

Yes. Sorry,

Thanks for the review,
Ira

> 
> > Use devm_xa_init() to automatically destroy the XArray when the PCI
> > device goes away.
> > 
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > ---
> >  drivers/pci/doe.c | 14 ++------------
> >  1 file changed, 2 insertions(+), 12 deletions(-)
> > 
> > diff --git a/drivers/pci/doe.c b/drivers/pci/doe.c
> > index 0b02f33ef994..aa36f459d375 100644
> > --- a/drivers/pci/doe.c
> > +++ b/drivers/pci/doe.c
> > @@ -386,13 +386,6 @@ static int pci_doe_cache_protocols(struct pci_doe_mb *doe_mb)
> >  	return 0;
> >  }
> >  
> > -static void pci_doe_xa_destroy(void *mb)
> > -{
> > -	struct pci_doe_mb *doe_mb = mb;
> > -
> > -	xa_destroy(&doe_mb->prots);
> > -}
> > -
> >  static void pci_doe_destroy_workqueue(void *mb)
> >  {
> >  	struct pci_doe_mb *doe_mb = mb;
> > @@ -440,11 +433,8 @@ struct pci_doe_mb *pcim_doe_create_mb(struct pci_dev *pdev, u16 cap_offset)
> >  	doe_mb->pdev = pdev;
> >  	doe_mb->cap_offset = cap_offset;
> >  	init_waitqueue_head(&doe_mb->wq);
> > -
> > -	xa_init(&doe_mb->prots);
> > -	rc = devm_add_action(dev, pci_doe_xa_destroy, doe_mb);
> > -	if (rc)
> > -		return ERR_PTR(rc);
> > +	if (devm_xa_init(dev, &doe_mb->prots))
> > +		return ERR_PTR(-ENOMEM);
> >  
> >  	doe_mb->work_queue = alloc_ordered_workqueue("DOE: [%x]", 0,
> >  						     doe_mb->cap_offset);
> > -- 
> > 2.35.3
> >