Date: Wed, 30 May 2007 13:18:19 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Yinghai.Lu@Sun.COM
Cc: Andi Kleen <ak@suse.de>, Russell King <rmk@arm.linux.org.uk>,
       Bjorn Helgaas <bjorn.helgaas@hp.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Gerd Hoffmann <kraxel@suse.de>,
       David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 4/5] serial: convert early_uart to earlycon for 8250
Message-Id: <20070530131819.641e1548.akpm@linux-foundation.org>
In-Reply-To: <465DD753.5040208@sun.com>
References: <200705291844.00308.yinghai.lu@sun.com>
	<20070530115717.77e05153.akpm@linux-foundation.org>
	<465DD753.5040208@sun.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1222
Lines: 34

On Wed, 30 May 2007 12:58:11 -0700
Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:

> >> +int update_console_cmdline(char *name, int idx, char *name_new, int idx_new, char *options)
> >> +{
> >> +	struct console_cmdline *c;
> >> +	int i;
> >> +
> >> +	for (i = 0; i < MAX_CMDLINECONSOLES && console_cmdline[i].name[0]; i++)
> >> +		if (strcmp(console_cmdline[i].name, name) == 0 &&
> >> +			  console_cmdline[i].index == idx) {
> >> +				c = &console_cmdline[i];
> >> +				memcpy(c->name, name_new, sizeof(c->name));
> >> +				c->name[sizeof(c->name) - 1] = 0;
> >> +				c->options = options;
> >> +				c->index = idx_new;
> >> +				return i;
> >> +		}
> >> +	/* not found */
> >> +	return -1;
> >> +}
> > 
> > Shouldn't this be __init?
> > 
> > serial8250_find_port_for_earlycon() had its __init removed.  Why?
> with __init, the compiler will cry about .init.text and .text missection.

But was this the correct fix for that?  afaict the only caller of
this function is __init anyway.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/