Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 8 Jul 2022 08:49:09 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Matthew Wilcox <willy@infradead.org>
CC:     Bjorn Helgaas <helgaas@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-pci@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC PATCH 2/3] pci/doe: Use devm_xa_init()
Message-ID: <YshR9b+cc1VogVlc@iweiny-desk3>
References: <20220705232159.2218958-3-ira.weiny@intel.com>
 <20220707160646.GA306751@bhelgaas>
 <YshC+Jaua01dPQak@iweiny-desk3>
 <YshED+nm7LdcmL75@casper.infradead.org>
 <YshFxnBZGUPN5LoC@iweiny-desk3>
 <YshHZXK/dq3apNDu@casper.infradead.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YshHZXK/dq3apNDu@casper.infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cNTFAOfIelz6fWe8vUH+6lpX/yyA/e1jZjhK+QLpfd43Ig+/DOVKHQUWz3xb?=
 =?us-ascii?Q?EUnxjqziYWch+TfZ9ogmB3chn4bbc95sz3wmwL+69TOcVMEHMyGOxrIFT8jb?=
 =?us-ascii?Q?3iNnVe6uE3TP/JuFYTpE8gXPWgmBsSsuzyXS4rOFiTl+yrC6nWcaLM+/X3eB?=
 =?us-ascii?Q?vN/3yd3CmmKZ4Iz8Xq9tMgfDQXxBQbdfwRAqRYIJ929/ztlAUILzrPtyEOwk?=
 =?us-ascii?Q?DE5N8o0hSaSD6FJkEV0pxZPN0x5SMUzOZCmB/YL2I+TXol9Ri599QFr6xzyG?=
 =?us-ascii?Q?FLdWzQ6dZn064f5ugRAo1Q9mZKRum3OPJcPMomXJRxPkIkcCFyikdMrAW5PQ?=
 =?us-ascii?Q?cp1pFxPpKDcvbt3qgnWHTMMVJFtl+LfEcdZqJpOEIMotoZdAYGSR7bL+XDAL?=
 =?us-ascii?Q?iLCDXjclR0EoewmC8ArypTPgQakHj5HW3PWxk0KQe0zZrUeJ2waUZzbRE6jN?=
 =?us-ascii?Q?lL640XZigk8wac7FCaA9FZr8xiNWR2L/yfrNWl5r7GQllhPpIAebJ7tO2hwk?=
 =?us-ascii?Q?e5O5L+SKxY0tCeRAr/Ru8np+LANTQU0ppTjXiEpeatnuFS4CQdVukypoxdQe?=
 =?us-ascii?Q?ktBkoI0XmyL+hWxKYeqFKv+dCCOm/aMEFX2uFkU6TvRnVoUlLOQ+3COinmch?=
 =?us-ascii?Q?KxQcVQjmnj25a8kqrWd69DFuejoUs2ikkm4AH00xYaZvxNpqWAegrTdQyy0Y?=
 =?us-ascii?Q?6Or1kzIMYeglKbaowyIhiHH7Wc4GywZwUIoVPQNZXcQulBgigh7W9R+Kue2z?=
 =?us-ascii?Q?SebABx6nqSLHR8BrgmGiJDK5cZD+18JA4WIT0O64DtfAoEMIoLxMpMdc1OsY?=
 =?us-ascii?Q?Pm+taykWJt9kUn/yhcLOGl/hEJbcA5q76VL5Z5mOoEDuKrnS3uEHGBX30SA9?=
 =?us-ascii?Q?lsQX/nmkApCTnF2CqWyLw9Ds1CC50rzBzQJujxDIVC5zNKI4+jQdwtrQbXpC?=
 =?us-ascii?Q?kd3eYdFjiVBkOUcS3vj4dD7Hii9saNNLzpTAm7BbAvSSAtS/aZGa1f8BOjVJ?=
 =?us-ascii?Q?+ELN6SACpGyLpue1CaDANbvX6R5tZBEVRPPqJsyOPIUU2ZkWF//tcu2BuYwB?=
 =?us-ascii?Q?aXp0An6Zt0m28fMCbWZSw0evxoZw8GR7w3zGPiB847HB5yiImRZXH5jw8OK3?=
 =?us-ascii?Q?IO7wFFttjucr4LEK5z0E71g2HEgoElGgz3Ye5Kx6eCHvjE9DZOj9asQj/YJp?=
 =?us-ascii?Q?8qdJ+keH4KRRUw8URMse9UZcoAPwn/Yold4Cn0xDIPYL4WQwc51//LdT7/pZ?=
 =?us-ascii?Q?nil8ThPDPUtwEa0WLcuSZ48nYnO5s7tFlt1+NUfOl7XwyUTOggFrzYTMf7Ms?=
 =?us-ascii?Q?79eHYz6eMeQPgg/3/mQ4f8bjkWcNFUpnChKJEUjAy+xz3VCw63BI0UE/+x2s?=
 =?us-ascii?Q?yV4Cq8rT3gH8d+1+XNuCaCSFFOJ3PSQIbPzNf2AyYg/Cy1ECiYTUdMoP32vZ?=
 =?us-ascii?Q?nFQ233wEb0W66+U1AtYbSZDnQiWcpXZFhEoNXH0Pcz8I95axLLUlFXO7B0VC?=
 =?us-ascii?Q?i6t++cG0cIW8ktUaouPMir77IsEtck2m06EPkATgo8zm+u4cqXYTXGuyZmd1?=
 =?us-ascii?Q?TMi3289SpPR34FfI8uWf1NdTfnrqzJwlYjKvUCG68tRa77azVxNjet1xZ9R0?=
 =?us-ascii?Q?znYKyvhWMYBWQhEwW1pxiIZ9Avn9+ZKEkh6BsFxTzd7u?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 44c751a6-8eba-414e-10bc-08da60f96a1c
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 15:49:17.1412
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GRtLFNKVre7foilH8EUscAsLJpbqqf6m8+qGqhvod33vAhhmcL12/3eTi2O7IQmXzXJswgEPijN7UI+AjAUckQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5913
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 08, 2022 at 04:04:05PM +0100, Matthew Wilcox wrote:
> On Fri, Jul 08, 2022 at 07:57:10AM -0700, Ira Weiny wrote:
> > > > I'll update this to be more clear in a V1 if it goes that far.  But to clarify
> > > > here; the protocol information is a u16 vendor id and u8 protocol number.  So
> > > > we are able to store that in the unsigned long value that would normally be a
> > > > pointer to something in the XArray.
> > > 
> > > Er.  Signed long.
> > 
> > Sorry I misspoke, xa_mk_value() takes an unsigned long.
> 
> It does, *but* ...
> 
> static inline void *xa_mk_value(unsigned long v)
> {
>         WARN_ON((long)v < 0);
>         return (void *)((v << 1) | 1);
> }
> 
> ... you can't pass an integer that has the top bit set to it.
> 
> > Can't I use xa_mk_value() to store data directly in the entry "pointer"?
> 
> Yes, that's the purpose of xa_mk_value().  From what you said, it sounded
> like you were just storing the integer directly, which won't work.
> 
> > +static void *pci_doe_xa_prot_entry(u16 vid, u8 prot)
> > +{
> > +	return xa_mk_value(((unsigned long)vid << 16) | prot);
> > +}
> > 
> > Both Dan and I thought this was acceptable in XArray?
> 
> You haven't tested that on 32-bit, have you?  Shift vid by 8 instead of
> 16, and it'll be fine.

Ah ok.

> 
> (Oh, and you don't need to cast vid; the standard C integer promotions
> will promote vid to int before shifting, and you won't lose any bits)

Will do, thanks!
Ira