Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <33277b4f-5147-2857-5d23-fe68674ab3b0@amd.com>
Date:   Fri, 8 Jul 2022 11:02:17 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] drm/amd/display: Remove condition with no effect
Content-Language: en-US
To:     Zhongjun Tan <hbut_tan@163.com>, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
        daniel@ffwll.ch, chandan.vurdigerenataraj@amd.com,
        tanzhongjun@coolpad.com, aurabindo.pillai@amd.com
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220708031048.43472-1-hbut_tan@163.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20220708031048.43472-1-hbut_tan@163.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3dZVE1NNTlnd2FNb2dpdVZCZGQvNFlxOU0ySEtudjBMeVZLUWIrUG40L09q?=
 =?utf-8?B?YUx6MUpGeUV6b1BSdFJUYjUrTjdJdTdjQi9uYityM2xUTjZ5L1Q0Z05tT25L?=
 =?utf-8?B?SldiQ2NPV3lVS1ZuVnZ1b3hQNUJpRDNBYmNvTktOWWZySE14Q283OTFBOE10?=
 =?utf-8?B?WjVKS091NHJMbWpaT3NIUDNCVlJBQ2lnZTFialluZGhvdXU4NDN4M1VCRzJ3?=
 =?utf-8?B?akhoMmNuWGdicWZ2ZnlVT0U3allqVmdFVFdwMzU1aDJUOGJGek1jN0hoOTdP?=
 =?utf-8?B?Q0VFOVU2MXltL0Q5enpEMnU4TXpoT1RJY2l2aEZ3akxmQ1Y5T2JTWGFzMWRv?=
 =?utf-8?B?NEFLS25ZYnpZcE9IUWozRmV2ZnNsb3diVWdTWTY0V3cxZmNWOGVmTVlwcFJD?=
 =?utf-8?B?cldjZGllVWt4dUpkQ25BNHdYZUZpd29MK0dPeUpJTGdmSGlxYXgwR2JOZmJQ?=
 =?utf-8?B?WnJTS0hZUXFjVldkVGovczQrSnFSemE0T0J4cWExcFZNVnR2U1RWd1E1U0Zs?=
 =?utf-8?B?RU9HUFhWSGlxcnhlUlVxSzBTVXhraTU5SjJ0VUVBMXpOT1lkdVdFY3RVd29F?=
 =?utf-8?B?MEtlaXFSYVFZUnhXU2pTN2pXVjljeFphYkRQN0tlSzFiS3llNk5KcENoRjhL?=
 =?utf-8?B?TVlpbzFNTENZWkVtUlRXalBlTHNKRjJiTEdEMEw0U2gva0ZJOFRFR3FnTHp0?=
 =?utf-8?B?WE0wMzFpT21RcWllQThWUU1rR0pydEdCRWVXWi9tMWEwcXRxbHFqZHdsYnlP?=
 =?utf-8?B?dExZOVFSSTF5RkUxejhDc01WK0l1Ym1qTHJ5Rk5YWXJkTVVUM0ZTZDRMNnY3?=
 =?utf-8?B?TmhWMVE1RU9ZalZjdXNrMDQwRjJjQUN5bW55ZXA5SUxIQWhITVZQWXN2VUYy?=
 =?utf-8?B?YVFicTcxVDlPS1ZZbnhUVlR0eFB0V05ESVlvcXBnMk5VL29wRTBEQXIweVNj?=
 =?utf-8?B?RFFUakxlaXptWktBZTV5N2huSzZjRGZyYnRRQXQ2bmdxSnpuQmhNeG5OdHpE?=
 =?utf-8?B?dEtHZllDVVhNVzBqbm1KRkpsVVc2YUdvckZja0lvSjRpTVhCYTBySWo5SlFB?=
 =?utf-8?B?VTM1VURTS3BuSnNLajVEYjJoUXh5N1lKTWlvRE8xaElXbWt0b2NQR1MyWHRh?=
 =?utf-8?B?Y3RBeHFaeW1WY0JZYzhRd0R0NUUzY2I5Q3UvaS83SGk2WXY1LzQ4ZXlveVVu?=
 =?utf-8?B?SDRjZXZCMHBtaWg4bWJSZzR6Q0FHais3ZE51bWJEZm1NY05EZDFwdCtZY2Fm?=
 =?utf-8?B?Y09NTTNDdlNNbVJLLzBIemZZMUw5YkxpL1BqWDEyb2VLM2VKeEtDclF3QUEx?=
 =?utf-8?B?WlFkRXRUWFh1emUyUU45RmlaT3dxMS8yWWpMbXNVUzVVRFdUUC9CdVpsaWw1?=
 =?utf-8?B?R2lyVkJENTNmcGdna3hIS29vaytzNDFxdUROOU1JRFVpSmhZQ2VHYmJIMVVn?=
 =?utf-8?B?ZUpxdGI1UFloaDh4elNteGxhVytVSXJNdGxUL2w1RGE0eklQVTMwYVI0VTBH?=
 =?utf-8?B?MnNMS29JekcvUG9PZk82T3dnQVVnLzR2ZlV4bDJSb2ltR1JCbUJQTjBBNXE5?=
 =?utf-8?B?OVg4MFRSeXVjTlFscjBXY2hzVWZYVHlyK2JCdTd5SVovbnh1QnhzU1d1dS9R?=
 =?utf-8?B?blB1R3ZGaWpvTkN0TG8yMWMvY2lZaDZxa25jRWhrYmQ2SWx1Qi9aZTVpdHNT?=
 =?utf-8?B?STcvd283QVdvSmxmaDlxOTA0aEVpU1VmbjRhNkRKaE1YcERFeVIrMWl0cjhk?=
 =?utf-8?B?eEtwZERENlVXQ1ZGdU5EZUlGejgyaHkwM2QySWp1K0JNMXFjTW1RS2lBM1Vq?=
 =?utf-8?B?azNISk9GelljUDVKNi9ScTJjaVZrL3VyTGFjRUZnZ0tsbmVRaWNzMzJjM3Fm?=
 =?utf-8?B?MldUS1NvUkRMU1Z4TGVNZlNmS3YrUjBBc0VwdkFJK1AxSm9haTZtWjB4MGIw?=
 =?utf-8?B?elY3NU41SzVHSmpPcDc2Sk42Q3NrN0c2NGozcGNNYkVIc01JNi9zUkQwQ3JE?=
 =?utf-8?B?WjZjb3dQZTR4QmhJZFp4YUVpd3BmVlQvbG1udlg4d2tvREdDc3krQWVJQ2ww?=
 =?utf-8?B?VVd2MFU4WUwwN0Z0YjdFaWE2YkRGNEVNNTkvUTNGanhoVmc2MDRMeEJlZDVS?=
 =?utf-8?Q?H3MD5tOXRhYpZt2sdw2xOAr9C?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d9c23038-e9ea-4288-5c16-08da60f2ed58
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 15:02:51.4383
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2UjIu/GOs2fst+Jl0LYkGnoYb1Iohe/DOQzP1HripZWUJjABTufmD3/k5HFzB7IcG1QaXMKVb/hQzdkEbz/BVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5219
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-07-07 23:10, Zhongjun Tan wrote:
> From: Zhongjun Tan <tanzhongjun@coolpad.com>
> 
> Remove condition with no effect

Please explain why you think this has no effect.

Harry

> 
> Signed-off-by: Zhongjun Tan <tanzhongjun@coolpad.com>
> ---
>  .../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c   | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> index 07f3a85f8edf..ec3ea94d3802 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> @@ -4670,10 +4670,6 @@ void dml32_CalculateMinAndMaxPrefetchMode(
>  	} else if (AllowForPStateChangeOrStutterInVBlankFinal == dm_prefetch_support_uclk_fclk_and_stutter) {
>  		*MinPrefetchMode = 0;
>  		*MaxPrefetchMode = 0;
> -	} else if (AllowForPStateChangeOrStutterInVBlankFinal ==
> -			dm_prefetch_support_uclk_fclk_and_stutter_if_possible) {
> -		*MinPrefetchMode = 0;
> -		*MaxPrefetchMode = 3;
>  	} else {
>  		*MinPrefetchMode = 0;
>  		*MaxPrefetchMode = 3;