Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 8 Jul 2022 16:58:35 +0100
From:   Mel Gorman <mgorman@techsingularity.net>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Nicolas Saenz Julienne <nsaenzju@redhat.com>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        Michal Hocko <mhocko@kernel.org>,
        Hugh Dickins <hughd@google.com>, Yu Zhao <yuzhao@google.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH] mm/page_alloc: replace local_lock with normal spinlock
 -fix -fix
Message-ID: <20220708155835.GK27531@techsingularity.net>
References: <20220708144406.GJ27531@techsingularity.net>
 <a78f95e9-298a-bc97-9776-14e0f02f62b9@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <a78f95e9-298a-bc97-9776-14e0f02f62b9@suse.cz>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Fri, Jul 08, 2022 at 04:54:47PM +0200, Vlastimil Babka wrote:
> On 7/8/22 16:44, Mel Gorman wrote:
> > pcpu_spin_unlock and pcpu_spin_unlock_irqrestore both unlock
> > pcp->lock and then enable preemption. This lacks symmetry against
> > both the pcpu_spin helpers and differs from how local_unlock_* is
> > implemented. While this is harmless, it's unnecessary and it's generally
> > better to unwind locks and preemption state in the reverse order as
> > they were acquired.
> 
> Hm I'm confused, it seems it's done in reverse order (which I agree with)
> before this -fix-fix, but not after it?
> 
> before, pcpu_spin_lock() (and variants) do pcpu_task_pin() and then
> spin_lock() (or variant), and pcpu_spin_unlock() does spin_unlock() and then
> pcpu_task_unpin(). That seems symmetrical, i.e. reverse order to me? And
> seems to match what local_lock family does too.
> 

You're not confused, I am. The patch and the changelog are outright brain
damage from excessive context switching and a sign that it's time for the
weekend to start.

Sorry for this absolute misfortune.

-- 
Mel Gorman
SUSE Labs