Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Akhil R <akhilrajeev@nvidia.com>
To:     Thierry Reding <thierry.reding@gmail.com>
CC:     "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v2 1/3] dt-bindings: dmaengine: Add compatible for
 Tegra234
Thread-Topic: [PATCH v2 1/3] dt-bindings: dmaengine: Add compatible for
 Tegra234
Thread-Index: AQHYkhH2RKRmdrlQR063eqSYWXAxeq10i9OAgAAamLA=
Date:   Fri, 8 Jul 2022 16:10:47 +0000
Message-ID: <SJ1PR12MB6339A080E09C0CCCCB9F2E6BC0829@SJ1PR12MB6339.namprd12.prod.outlook.com>
References: <20220707145729.41876-1-akhilrajeev@nvidia.com>
 <20220707145729.41876-2-akhilrajeev@nvidia.com> <YshAt5WAG9zUkrpy@orome>
In-Reply-To: <YshAt5WAG9zUkrpy@orome>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GGRg0CqLFRkFRVJiSYIDyicjxJWjhc6zB9EvHugPwMdXf6DpvCzmFFjo24Rg?=
 =?us-ascii?Q?LcbeoF73K0Zjc/TyyzCa/4Ct9CJBgQAeu8j2+EaCq4XuD2jFV0xvxynVwlSJ?=
 =?us-ascii?Q?+g+xxuceOHg4b2w2OV+f5hAiJ1XUcRoYlLWNsEkjFaXEmZ0Z0Hdod9nAOZpT?=
 =?us-ascii?Q?vzpT4caVZMtcexgw2fuy2DZhag8ZArrijvESWFN2ovQx+xP7VQafT/mB/e4X?=
 =?us-ascii?Q?+x9l2DWfin8QC6pH5NNb7Ndd4W8+nY//pXu8xEIfl6IDwdAJbcSYCFCceIGo?=
 =?us-ascii?Q?HJqCUzHHjl9eiyQ5hl3pc7YjxWR8y/0NnkDE2/WplYnpRdmG/Sf6jcI0SfM+?=
 =?us-ascii?Q?QSnRa6f7pVhdytjgLkxiOXisqz2BWle8hFiSWzf8G44xCxycqh7tuUdds8L5?=
 =?us-ascii?Q?EO6nUBMtEx/HaIJOegMcGuLF+hrDg0b4kyksCDzh5vbZpbckSUPdnxVqSgeU?=
 =?us-ascii?Q?bErnYfJ794Jpb3moBNYOv1wdYO1Xy9wS4ylwinDfm+lI7Fw7+xPCrrq/ye9h?=
 =?us-ascii?Q?JkHmmb+dDFWva5sXWZDWnH4H4+GBYuEAhfT69Z59z/+R/SQ7EMkHN2ckeCdx?=
 =?us-ascii?Q?yF83ybJNEhY3JVz1+AFVIVJMELnLjhjp0kIhzO1zLSJaT1LQhQ/uN8sLqPvI?=
 =?us-ascii?Q?/wVge8YUVV1eP+W7vzI/v5pjMnWhk0VmxcPWBAH1OSsetE7wqWuGEo0y2C0d?=
 =?us-ascii?Q?QdV7d5yefdPkseWeJnkheG8c3MiKq55cO52NXVSBPdWIiXhrCJLK/Li71xES?=
 =?us-ascii?Q?5sXx3E0SGNkxI+KWewooUnqdJg+rCgf2+ShEPcC206bniXTJ6/41WUWFpzUW?=
 =?us-ascii?Q?zx4U2rY9kONaPmoYl7xs7qwJ5g8KRy4cBsYjuCl5ALWVny16nkTO7TGJ7HW0?=
 =?us-ascii?Q?hBjrQxdB9u5bBOThWsZHbTYq9Wwc4I0lF02UTiba3tifs6ArHgYOQwRPGdQC?=
 =?us-ascii?Q?uG0XBR+ENlSMhUnlJk/qhzitRLE7j9j0Ao5meqfe+wDdykwsgSpJrPc8FPqI?=
 =?us-ascii?Q?7OpMGwGzpUz/Zyg3u0P/BcDw9nsfvmxvQy+YnkfzI8up6144wJowmK7YBTEF?=
 =?us-ascii?Q?1dHsEYjMPptqj1eI4ZdSdW3+AK9NxE7x2n7WMv6cB0Mzy8nPQTAv4g9ciE7D?=
 =?us-ascii?Q?r83KAqzqA3ApQRdMBLpSXSswshLtxMJhJmBw0WoVG3l1nAtr+qVCM6YFwDJg?=
 =?us-ascii?Q?cq0CDLb3I0m9z+926Hekmv+yes9QLMC75fryxUWsQBLy123Arx5dk4E0HB8x?=
 =?us-ascii?Q?b15DcF7pjn/uvWkxZtIuU3wDtfaG6wt2smzxlEa1kqKiC6+4ZIS5GNEAkkHD?=
 =?us-ascii?Q?rE54dg/N+qSur7u80hoqtqoDpM6Hsq19hz3Dby4/fRrrDuP9ckpdhLG1vnQn?=
 =?us-ascii?Q?ZMomTFUZ6SKnuiPCgdvqHB+e04Pm6/vm2MZNtVrKg/KDD8olL5i2t5AXArOR?=
 =?us-ascii?Q?oI+HUPmhS8Wb9/n6wtjGNDsexDsqubWolRiNkUAvtZX8ml5SAzCqvMgNJQCM?=
 =?us-ascii?Q?C+OcpRnZ3fZ/kc+yHhLq9eO1t9U7seV4lrgn+yxQ6vPaohrVtGay6oVbTakk?=
 =?us-ascii?Q?QbZmRLFr8meZO3QiITQXXfZIOFl2sz15sxPzt1fg?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR12MB6339.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dd6adb31-7173-4b8e-8505-08da60fc6b92
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2022 16:10:47.8979
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1rIBPFpxnLaPN14FHr9u612qVnzzL2UKhf6UdRRq7qnSs4b/WhQrsOQ54tDST14zXUOgyKUKu+sK3MLe/kfXpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6578
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Thu, Jul 07, 2022 at 08:27:27PM +0530, Akhil R wrote:
> > Document the compatible string used by GPCDMA controller for Tegra234.
> >
> > Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> > ---
> >  .../devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml         | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> > b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> > index 9dd1476d1849..81f3badbc8ec 100644
> > ---
> > a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.ya
> > +++ ml
> > @@ -23,6 +23,7 @@ properties:
> >      oneOf:
> >        - const: nvidia,tegra186-gpcdma
> >        - items:
> > +          - const: nvidia,tegra234-gpcdma
> >            - const: nvidia,tegra194-gpcdma
> >            - const: nvidia,tegra186-gpcdma
>=20
> I don't think this works because it will now fail to validate Tegra194 de=
vice trees.
> You'll need to create a separate set of items for Tegra234.

If I update it as below, would it work?

- items:
	- const: nvidia,tegra234-gpcdma
	- const: nvidia,tegra186-gpcdma

- items:
	- const: nvidia,tegra194-gpcdma
	- const: nvidia,tegra186-gpcdma

Regards,
Akhil

--
nvpublic