Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 8 Jul 2022 19:48:48 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Akhil R <akhilrajeev@nvidia.com>
Cc:     "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: dmaengine: Add compatible for
 Tegra234
Message-ID: <YshuAIhi2CBQecu6@orome>
References: <20220707145729.41876-1-akhilrajeev@nvidia.com>
 <20220707145729.41876-2-akhilrajeev@nvidia.com>
 <YshAt5WAG9zUkrpy@orome>
 <SJ1PR12MB6339A080E09C0CCCCB9F2E6BC0829@SJ1PR12MB6339.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="TiQvvnLkTwz7kPLP"
Content-Disposition: inline
In-Reply-To: <SJ1PR12MB6339A080E09C0CCCCB9F2E6BC0829@SJ1PR12MB6339.namprd12.prod.outlook.com>
User-Agent: Mutt/2.2.6 (2022-06-05)
Precedence: bulk


--TiQvvnLkTwz7kPLP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 08, 2022 at 04:10:47PM +0000, Akhil R wrote:
> > On Thu, Jul 07, 2022 at 08:27:27PM +0530, Akhil R wrote:
> > > Document the compatible string used by GPCDMA controller for Tegra234.
> > >
> > > Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> > > ---
> > >  .../devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml         | 1=
 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> > > b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> > > index 9dd1476d1849..81f3badbc8ec 100644
> > > ---
> > > a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> > > +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.ya
> > > +++ ml
> > > @@ -23,6 +23,7 @@ properties:
> > >      oneOf:
> > >        - const: nvidia,tegra186-gpcdma
> > >        - items:
> > > +          - const: nvidia,tegra234-gpcdma
> > >            - const: nvidia,tegra194-gpcdma
> > >            - const: nvidia,tegra186-gpcdma
> >=20
> > I don't think this works because it will now fail to validate Tegra194 =
device trees.
> > You'll need to create a separate set of items for Tegra234.
>=20
> If I update it as below, would it work?
>=20
> - items:
> 	- const: nvidia,tegra234-gpcdma
> 	- const: nvidia,tegra186-gpcdma
>=20
> - items:
> 	- const: nvidia,tegra194-gpcdma
> 	- const: nvidia,tegra186-gpcdma

Yeah, that should work. You can verify that this works by running the
dtbs_check target, although this can be somewhat overwhelming right now
given that there are quite a few errors/warnings, so it's easy to miss
new ones.

According to the DTS change that you posted as part of this series, the
Tegra234 compatible string list also includes the Tegra194 compatible
string, so that should either also be updated, or you need to include it
in the binding as well, like in your original patch.

Thierry

--TiQvvnLkTwz7kPLP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmLIbf4ACgkQ3SOs138+
s6Golg/+Nr0ZI1WGzLCZf7ETOImR5DeBoFHa8yEv82uj78FtwiDZxsHGPOgJL+C3
6dunfW7CPg/RGpLbeKEAzNxdqiSEsbpmSAVni0BWdrH4idGrDrEIl2Aj/ORgNkKB
aqap/j+BjKtcVsqHgF8bauQIyFcyGRtwkjhYLwGTJGWAzxq4/NLPwcXc+ah8gCFX
+oTguWZeGbX1eXpOLW4yPtCahtZBnfjoib/B+KMu+OfYnxHGcvbxf5YLSiTE8DGI
aPCmTCiPFR/r289T+6vOfkzcseusbUDr0hbKUprR8z/eTAGm8J1HPJzTkTOyND7x
B9t7cMCz8TXF3qgfE3XBW1QlheyTWgLyLNmpzW9Ya+TwvT/eKT3f8OObLyhbY+Ef
5sAReS9chgCQsmHc5Y2CYyniKNn4m781bUQTbdu/07qKKqRWeI92VyZZttUgkMMk
omUBSpewOFnkxFjIrv33xHMDUQt48pykLKWx4tA3szfQpeHgna99uhFmVtefiNw4
WAXt/v0rg1nx8lbc8+iXo1nnf+BemuoEWrySSJKtCzMrl+vNONIeerjeOe8L4tj6
eHmiN0c0eboRZbsPbEw1G01bCVAt/qQz8qrDwwP/pDtGQFiWIZ+xXk81TXhYsVly
7xsGPz0w4+fAQhYcvQDjdHlBaff2vH5FHIxwH/YTh+5mq5SbGQg=
=Z7VR
-----END PGP SIGNATURE-----

--TiQvvnLkTwz7kPLP--