Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <33a6193e-1084-ae5f-1f80-232274f71bd0@intel.com>
Date:   Fri, 8 Jul 2022 11:34:40 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] platform/x86/intel/ifs: Allow non-default names for IFS
 image
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     <hdegoede@redhat.com>, <markgross@kernel.org>,
        <ashok.raj@intel.com>, <tony.luck@intel.com>,
        <ravi.v.shankar@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>
References: <20220708151938.986530-1-jithu.joseph@intel.com>
 <YshNAh6awfPFmxzU@kroah.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <YshNAh6awfPFmxzU@kroah.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0pOQThDZDZVUnhDOCt5dWovT0crWmpiTTBsVGtncXAwbThHVnNwS3dCVGR2?=
 =?utf-8?B?VTd6bzhEM0JjdmJyaTRxRjZjaDZSR1VFcHMwWDdnVDVSY0hCdm9PS09TVU10?=
 =?utf-8?B?Qlo2SUtNdlR6SHQ1bzE4Y2Uwdlp6S0tnNWlkR040aHpmbTNYRlpBYkdUcFJ2?=
 =?utf-8?B?ZG96VEQ4VHl1NGVaTnRXVjExQUhHNnNibUlaRHlYZWFnN1JIUlBzanM3RXp0?=
 =?utf-8?B?aC9LTUdQRUVRZHBDWWh1VTVRVW5GTGlBSVByeFZoYVR2WlpUeGt2NHRDYmdB?=
 =?utf-8?B?UUpVMFRmN3A5ZGVHc2ZWeG1ORnVMVk5hVDVGMFBJYzVaaWFPQ3VHSVQ0VlRw?=
 =?utf-8?B?cm1MSXdyMndnSG9MblhTOEMzNHVyblZ0TXdpWFNObktiQTN6TXUxNytsRjQx?=
 =?utf-8?B?ZHNPYnZ5cWRMT0xDWElNckxMOHBROGNGc1U4T1UrVXZRaXdlaUZFMTBIV3FE?=
 =?utf-8?B?VmZ4cW9IOFNHYmx3Z0JxV2JhcXc2cGlDM2xybkw1empuZzlnbmZUM2pETDlN?=
 =?utf-8?B?bnVhZ1NuOU85b0N2TmNka3lCb1BveTEzZjBhdkw1aEFPaEZYOGZkeVlPcFNw?=
 =?utf-8?B?bElpUnMxYWRvZVZQQkFYK0c0TklHc2NCdmR4UnphQnhSRm01ZTBqaWtyZHJU?=
 =?utf-8?B?VDh2b01NcGNBaVVIek14RHJMQkhPNjhUaHc3L0NmL3hrMUs2NWdaLzIwbTRU?=
 =?utf-8?B?RjQzODBZSFQyM1RXeXNvRDM0dlEzL29lUlg3R0o4S09WRmREQ3oyMUlXNm1l?=
 =?utf-8?B?d1ZtYmZHZ1ZtRitGOEhycVlpcHF1WThXOElJbXA3TmpiN0U1SEsvQjUvRlR3?=
 =?utf-8?B?TWVQZDFLU2ppaDhINXpXN2hUb3RSTFR2NDBGNERxNmdkR1g2eWNYR2NxQmgx?=
 =?utf-8?B?K2NBNklqS0M3d0xCd1lHb1B6Y1BJU2RhaThpbTJxYnh3d3VYcEU5ZTdoUXps?=
 =?utf-8?B?dnJhdGFzQzhZamZHQmlPanRtcXl5Ymc4cHhsd2sxZ2k0cFVNMXNadVJWNWcz?=
 =?utf-8?B?VUgyeE1HRkQ3Z1llbDNYYmYwa0pnTUFuUWk1bytBd3krRzZIM0tpOUpZQTFS?=
 =?utf-8?B?TFkzYXV0alpmK3U5RUZ3d3dVVnRZU2t3ZzZQM2YyYXZhNzA3K3Y0S3p1V2lD?=
 =?utf-8?B?eDhMV0xBdXNZWG1PNFdJSVJHRTN4RzM0UHpyRDd5VC84Qkh0eGdQSWpId2c1?=
 =?utf-8?B?QXg2c1VXZEo0MmNoUG9lTFRpajhISE9acDJCMFRMdnJraUNQTW1DeVpyOXg1?=
 =?utf-8?B?UVNzL0Rka3lMdzJPb3d4NXV4MFJ6Z3l4N1MxUFhXWXVoS0xkOXRZd2N3TGJK?=
 =?utf-8?B?d2hLTUxBNUtwSjIzbUZ2RmtJeEgwcjVnc0FUaWF3c0tFTDM5bnVqN3E1dmlI?=
 =?utf-8?B?aWNiVWNpZ3EvZFk1b0hIdWptQnFJanRVazhQTG1aNjIyYjhMQVZUSWxSamp2?=
 =?utf-8?B?YTR2dE9ZNmpGWkY1Y09XUzZlM0FIU2pQVEZPdVkvM0tvUGRaQmc2R3J3NjV4?=
 =?utf-8?B?MHJSRlhHL2NjRTk0YlNTOHBYUHZtRjAxczBVRmI1QnhFRnV0Nlp5bUU3TjVB?=
 =?utf-8?B?bjdyNFU2VlZVYWtVQUEwWk5GT3lCc0lKVXVGekJVZHpGaGZPOHpCQUpLNzV5?=
 =?utf-8?B?TlRhYjVKZ3o0RE9KckR0b0FtU2tqalA5NU1FYUY4bGVvMVFHS1Y2ZzZvdjVM?=
 =?utf-8?B?cUdaTmNud3A5N0ZSV0h6V1pzUjlkODd4bTFrU3pCNjVlS2xVenE2dERPNTds?=
 =?utf-8?B?S2N4SkZXbFVYSEwwNnV3dU5veFp2a0FiU1psZm9zZUVncC9yS015bXltWXZh?=
 =?utf-8?B?aTRsU0hwKzBwZlVhQkxMWEpjb1hYV2tybzQ3L2svTWs5bGcrSUFNUGlDRTVa?=
 =?utf-8?B?T3VDZ0VwUThqYjNUUytYSVRsWWtlSGxUZXNjTndHc2NPeEpEWjJRU3p0V3lZ?=
 =?utf-8?B?RlRvN1JzaUl6M2tOU2JncnExSlFUckJraU1jSnhYSXBTbDBtVEVyZ3dIczR4?=
 =?utf-8?B?UXhPZlF1MlM2aVp4a2RFUHBKdzlBNllRT1c0WnduYy9lQmZ5NnhNaVBpTmtL?=
 =?utf-8?B?aHBPVVd3TnQ0UjdlMDcybzZTdklJaVdyMlJBNzIyTnE2TVRUTkE4TnB2VHBH?=
 =?utf-8?Q?vUB/FGgHjQ2C0BhkHHmutxBi1?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 640dddbd-af53-4bb1-ee19-08da61108665
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 18:34:42.9638
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ze5PFTQ+Tvi7Pvmgm7F5Ma0lAcvrWzeloUw8DlbZiRZnxbZvI2jodJmcReF7JmiSqzpgo00vNTfBjf08/Sg1Ww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3780
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/8/2022 8:28 AM, Greg KH wrote:
> On Fri, Jul 08, 2022 at 08:19:38AM -0700, Jithu Joseph wrote:
>> Existing implementation limits IFS image to be loaded only from
>> a default file-name (ff-mm-ss.scan).
>>

> 
> Ick, but now what namespace are you saying that path is in?  If you need
> debugging stuff, then put the api/interface in debugfs and use it there,
> don't overload the existing sysfs api to do something different here.

The namespace related confusion could be because, the original commit message
was not using full path-names. The below write-up tries to be more clear on this

Existing implementation limits IFS images to be loaded only from
a default file-name /lib/firmware/intel/ifs/ff-mm-ss.scan.

But there are situations where there may be multiple scan files
that can be run on a particular system stored in /lib/firmware/intel/ifs

E.g.
1. Because test contents are larger than the memory reserved for IFS by BIOS
2. To provide increased test coverage
3. Custom test files to debug certain specific issues in the field

Renaming each of these to ff-mm-ss.scan and then loading might be
possible in some environments. But on systems where /lib is read-only
this is not a practical solution.

Extend the semantics of the driver /sys/devices/virtual/misc/intel_ifs_0/reload
file:

  Writing "1" remains the legacy behavior to load from the default
  ff-mm-ss.scan file.

  Writing some other string is interpreted as a filename in
  /lib/firmware/intel/ifs to be loaded instead of the default file.


> 
>> Fix the below items in adjacent code
>> - Return error when ifs_image_sanity_check() fails in ifs_load_firmware()
>> - Correct documentation "ifs.0"->"ifs"
> 
> That should all be a separate patch, you and Tony know better than this.
> 

Noted ... will send this separately


Jithu