Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp799207imw; Fri, 8 Jul 2022 11:57:45 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sCN+A/8sNQaMyhCl1w/dDFf/wXojYlmsRW55tLTxv2V61WYsyXt+7yDeoYex1HFH2m2PFI X-Received: by 2002:a17:907:2856:b0:72a:f13e:6c6c with SMTP id el22-20020a170907285600b0072af13e6c6cmr5150434ejc.642.1657306664763; Fri, 08 Jul 2022 11:57:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657306664; cv=none; d=google.com; s=arc-20160816; b=vmPXIDHE+7hNO3OwbTxrL/l7qVek1uYTqSr3dbvW6wZ6aD9njXJFFAM/E30vjmz2b5 ZLkKxLWSRdbTWO1WYL0bomh959VeeMpjvlwMIBzOmTi2yEnQ54Db65P9yFN5Klg3vVGk I/aKE5or5WfUgeO8tOSXje0PYFilEDVQCZtVpkBopa6OsrAvrzjOWWnSlfG2mJBQfQwT qGiqy8wGmKYu2V0k9C/tXyf9oMquD2GvtS0U77QrIyNiiG7VARuYKe1jSlXJEZejPl0K oQetqrtH71JHPtffD5Qlmc4+6yHMW98xDsivh64+i0ld0hnbjABULke3FoeajllxlMNd fJqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=tF7YJFsjFxIyw7PwghLrp5+JSxXV+QtYZQUL3UeYwHE=; b=nN74ROjL8VvUMfz+Wd8/GpLJKk0VJCSJwBxAKA99MblfjfXCejP7/KH/l4GTTe5X1G n1qkkC1saCyg6J2sRnHBn96zwsgI+3FDJr1jhhmym+C3q0IDzAcd88FYXNowaEtQF+q9 PoI0zO/DOTc8Ixn4byRPYc6a6T1jia6jatjlM2nre1tbPtsskZRc06AyDXX3MEL6F49t nM4U9//fUleHd6tJESNdgKODGYBu8L3SZGHfqloQ3LGQbI0nSNpu4+QpBfFqO46k2ZKh CcyIfWmaee2dUDndk2AaSULtu++mOmiphZKfxZwI39qDq5ariKf22CyDxkg65snQcwnk PpNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b="rC/6EwSG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sh13-20020a1709076e8d00b0071114e6de39si6099937ejc.679.2022.07.08.11.57.19; Fri, 08 Jul 2022 11:57:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b="rC/6EwSG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239190AbiGHSuw (ORCPT + 99 others); Fri, 8 Jul 2022 14:50:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239721AbiGHSun (ORCPT ); Fri, 8 Jul 2022 14:50:43 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E123963E0; Fri, 8 Jul 2022 11:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1657306243; x=1688842243; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=tF7YJFsjFxIyw7PwghLrp5+JSxXV+QtYZQUL3UeYwHE=; b=rC/6EwSGX3FHRe2tG1TFf6a/hBAapiII4njMF66f1Ouz120SDxqOHCxR JHZ+aizE7fVSJYiA5715l03MbsJCwAlN6d/wDnLQh705OGqE9rzWzZMYv 8YbiAgikkKN4gFr/soCnZBQ1xGnIUnTRyTsUrSu3Ri6HvDo0j86cUmoEz 0=; Received: from ironmsg08-lv.qualcomm.com ([10.47.202.152]) by alexa-out.qualcomm.com with ESMTP; 08 Jul 2022 11:50:41 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg08-lv.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 11:50:41 -0700 Received: from nalasex01b.na.qualcomm.com (10.47.209.197) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Fri, 8 Jul 2022 11:50:20 -0700 Received: from hu-wcheng-lv.qualcomm.com (10.49.16.6) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Fri, 8 Jul 2022 11:50:20 -0700 From: Wesley Cheng To: , CC: , , , , Wesley Cheng Subject: [PATCH 2/5] usb: dwc3: gadget: Force sending delayed status during soft disconnect Date: Fri, 8 Jul 2022 11:50:04 -0700 Message-ID: <20220708185007.21743-3-quic_wcheng@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220708185007.21743-1-quic_wcheng@quicinc.com> References: <20220708185007.21743-1-quic_wcheng@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01b.na.qualcomm.com (10.47.209.197) To nalasex01b.na.qualcomm.com (10.47.209.197) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If any function drivers request for a delayed status phase, this leads to a SETUP transfer timeout error, since the function may take longer to process the DATA stage. This eventually results in end transfer timeouts, as there is a pending SETUP transaction. Signed-off-by: Wesley Cheng --- drivers/usb/dwc3/gadget.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 298e842c384c..75cbc3f185d0 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2513,6 +2513,9 @@ static int dwc3_gadget_soft_disconnect(struct dwc3 *dwc) if (dwc->ep0state != EP0_SETUP_PHASE) { int ret; + if (dwc->delayed_status) + dwc3_ep0_send_delayed_status(dwc); + reinit_completion(&dwc->ep0_in_setup); spin_unlock_irqrestore(&dwc->lock, flags);