Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <357da99d-d096-a790-31d7-ee477e37c705@oracle.com>
Date:   Fri, 8 Jul 2022 13:36:13 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v2 0/9] Add support for shared PTEs across processes
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mike Kravetz <mike.kravetz@oracle.com>
Cc:     willy@infradead.org, aneesh.kumar@linux.ibm.com, arnd@arndb.de,
        21cnbao@gmail.com, corbet@lwn.net, dave.hansen@linux.intel.com,
        ebiederm@xmission.com, hagen@jauu.net, jack@suse.cz,
        keescook@chromium.org, kirill@shutemov.name, kucharsk@gmail.com,
        linkinjeon@kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        longpeng2@huawei.com, luto@kernel.org, markhemm@googlemail.com,
        pcc@google.com, rppt@kernel.org, sieberf@amazon.com,
        sjpark@amazon.de, surenb@google.com, tst@schoebel-theuer.de,
        yzaikin@google.com
References: <cover.1656531090.git.khalid.aziz@oracle.com>
 <20220701212403.77ab8139b6e1aca87fae119e@linux-foundation.org>
 <0864a811-53c8-a87b-a32d-d6f4c7945caa@redhat.com>
From:   Khalid Aziz <khalid.aziz@oracle.com>
In-Reply-To: <0864a811-53c8-a87b-a32d-d6f4c7945caa@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bG1md0VzeXJwVEIvNXp0ckFmUno2MWUxb1RYcDNwYTJ6UlJ3NXlKdUtrWGx5?=
 =?utf-8?B?UWhBQUxEUC9vblFFTVJwM0Rqc0ZUeFYzVk56MHFWOVB2QW02Uy9ka2pyMEdL?=
 =?utf-8?B?ekNCb0c3bWM3Tk5lTXM0WVpuZUl4L2NyUTlkdS9YTEd0cFdNU0pJT2ExdHRC?=
 =?utf-8?B?UkRQNFhnazhnR2N3Ym5FTFVFZDFuc3pUbE02MkNhemYzNkV1Um9sOWhzOERB?=
 =?utf-8?B?TllvZ205bUFWWVp2U2hlL1NIbmNHYWpVZHVDTXdiZkQvc3FrOEI2Rkl0R205?=
 =?utf-8?B?eE5uTEFTTE5haVY5UGMra0ZwbTVyWnErRktGeXVkQlByK1h3VGxKcTVsVDJ6?=
 =?utf-8?B?bFQ2T0FVODFBam1mZHNQdTYxcGcxZGxzK1RJVHhGK3pYOEN5RktIQXpFbXZ2?=
 =?utf-8?B?RjM1SnZyT005a2RZVFpqNWNFdGpndU1kSTJkMzI1SXcrUmtRQkRBSXZOUEQr?=
 =?utf-8?B?bFZnN3RmRVNQVmZYcm9mQTRFVnpTY1REUVBSYWtwaHFaeVFodzhEdlFhU2pu?=
 =?utf-8?B?ekNkQzBMcnBFMDFQdDhzRVVxM0hnbzc1TGJCNlpsMy9KVEF5VktqazVNMjZ6?=
 =?utf-8?B?Y1h2UVY3UFdvZUZDM3dLVm1qVkJnOFhvekNSWC90N1ZmNEdnTkhNanBtTklZ?=
 =?utf-8?B?Zm9xOElIZWVFZ2xxalY2ZkkvcE91dk8wNkZxU0gxSmUvMmYzR1NzblhhZGg0?=
 =?utf-8?B?VzJCOVYvSERmNDkrSHBVV2E3YXZGRk03aWt5NHg3aUNpK2ppSS9YRzI0bEhS?=
 =?utf-8?B?ZUNwZmlwb2tMMzh0K3BxeC9vSVp1WExrM2FsVFh1eitja1ZJSVhqaldTeGVa?=
 =?utf-8?B?WFpJaWo5ajltMk01QVJBUlhlTEkvNEZVR1ZZRk5zaC9NNVZMU1lSYlFFWWFW?=
 =?utf-8?B?dm1aMVl4Y0Q4bStIRS9CY1JnZkFRM2ZYbDFSNE1jN011RWdERXVxaE9Ddktl?=
 =?utf-8?B?b08xOUEwV2xiKzBiMUtQdkVXRmlDV0JodHlnY1h0d0daSTZJMVAvQ044Ylp0?=
 =?utf-8?B?dTJBU3FJS0VIb0FhM1A4RzNRZjhVcWl1czU3dzVIV3RLNDhYNFc3b1hmb3Vl?=
 =?utf-8?B?K0xuZmRnVzlFbVR2d3EvSnQrK2ptQW5uZFF5MnZHM0pKK0I3Y2ErOFRueFMx?=
 =?utf-8?B?RzdSZUJiTVZOOEYvem5pSEsyb1U1Q3pVVzBtbXdNem4yWmVPY1ZNZzZvVXFO?=
 =?utf-8?B?WllYWWtnRmFUQWR3UHN3VjdaZ0s2d0JYOFUreUhxaWpWS240NVcvTkplOUhU?=
 =?utf-8?B?UmFDSWpFcDRkT1FrWXI4RVNzU2I4dmJEN21VM3BwOGNuK2xmei9RNmVrV2I1?=
 =?utf-8?B?QnpISUVwSlRqaDJDUzJvLzA1RTJEVElqMzk0OS9tTjZla0phc1pvbjBJdFp2?=
 =?utf-8?B?bHpjNmZIR3pXbG12aUJxempWQTFUUjh6TDIwQnFjTnB6K0NiRUdUSHFwS1dh?=
 =?utf-8?B?TXQ5R05vU1VmV2t5QXNIYXFoTGlYR3NzSmpxQm9GQStpWk9rSGhCWHJnZDBh?=
 =?utf-8?B?MVNUd3RvYmlnNWd5aVRLRWsvdVZVMUFhcWJaZ3laMmcxM0ljUHJ2UVdQckZM?=
 =?utf-8?B?UTJYL09Od1gyYlhRR0hPTEovSzc2WlAyOGhITGdabkRBQ3F2VHM5OVMvVEN0?=
 =?utf-8?B?b250OVg3TmZDV1Ivb0Qxc3hHUUVEUUFXNk5rbVFPRk1jSW1lT0liWmJvdHc5?=
 =?utf-8?B?Z3ROSTZOSFRvV0VvMDA0VW9LR3F1WEJjQU40MlFmamMxUVFMZ2JZTmFSb3Yr?=
 =?utf-8?B?bzZWczlkTXZRWHNhZVV1ZTFlTE1DOTFJT1llQksyOXIzclJtSkZPSFUyOCtM?=
 =?utf-8?B?MXhydFpYYVhpdWVsZWF1VFJNcGd1Y3J3UDREQ2RaWDd1Nk5XUnhreDIzSE8z?=
 =?utf-8?B?clhVeEJPUjZzbGxaeUswNDh3STRXVG1qS3Y5VjFGdUZuVExoYmYwTWtyRk85?=
 =?utf-8?B?TVBLTzdSRGxGREtPeG4rVGZVU0hFUlA0NWltc0xtSkMxQWpNSEJGanZUaHdE?=
 =?utf-8?B?ZFozNlErV1h4NEEzNGpQRUl3TEMrc0FNbGJidGpaK1Fua2Z3TkdLUzNQY29s?=
 =?utf-8?B?cWVHdzhidmR4a2x1alpQNkFJdlYzaEkyUXJuZzFZSnNlSGV2QjBZL2xjVzhl?=
 =?utf-8?Q?ngWye1koAbojKz0E5hJwLvZq/?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32ae2acb-8940-49a2-5c16-08da61192149
X-MS-Exchange-CrossTenant-AuthSource: BN8PR10MB3220.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 19:36:18.9222
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OBnYTKZe/ymVaJFNXBr5Gk/YQ1LKYDR+RSA98fbXgQrOo96fVFTGQCOv+2YwFlluywYSZePL5hLmeFkvpeRsrQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1453
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-08_16:2022-07-08,2022-07-08 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 phishscore=0
 mlxlogscore=966 spamscore=0 adultscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207080076
X-Proofpoint-ORIG-GUID: fxxCjceUuw29bkaEIi3iY2BFb_ivT8kE
X-Proofpoint-GUID: fxxCjceUuw29bkaEIi3iY2BFb_ivT8kE
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/8/22 05:47, David Hildenbrand wrote:
> On 02.07.22 06:24, Andrew Morton wrote:
>> On Wed, 29 Jun 2022 16:53:51 -0600 Khalid Aziz <khalid.aziz@oracle.com> wrote:
>>
>>> This patch series implements a mechanism in kernel to allow
>>> userspace processes to opt into sharing PTEs. It adds a new
>>> in-memory filesystem - msharefs.
>>
>> Dumb question: why do we need a new filesystem for this?  Is it not
>> feasible to permit PTE sharing for mmaps of tmpfs/xfs/ext4/etc files?
>>
> 
> IIRC, the general opinion at LSF/MM was that this approach at hand is
> makes people nervous and I at least am not convinced that we really want
> to have this upstream.

Hi David,

You are right that sharing page tables across processes feels scary, but at the same time threads already share PTEs and 
this just extends that concept to processes. A number of people have commented on potential usefulness of this concept 
and implementation. There were concerns raised about being able to make this safe and reliable. I had agreed to send a 
second version of the patch incorporating feedback from last review and LSF/MM, and that is what v2 patch is about. The 
suggestion to extend hugetlb PMD sharing was discussed briefly. Conclusion from that discussion and earlier discussion 
on mailing list was hugetlb PMD sharing is built with special case code in too many places in the kernel and it is 
better to replace it with something more general purpose than build even more on it. Mike can correct me if I got that 
wrong.

> 
> What's *completely* missing from the cover letter are the dirty details:
> "Actual data is mmap'ed using anonymous pages, ext4/xfs/btfrfs/etc
> files.". Gah.

Yes, cover letter in v2 patch was a little lacking. I will add more details next time.

> 
> As raised already, "anonymous pages" makes me shiver.
> 
> 
> (To me, what I read, this looks like an RFC to me, yet I see "v2". But I
> am a little confused why most of the feedback at LSF/MM seems to be
> ignored and people are moving forward with this approach. But maybe my
> memory is wrong.)
> 
> Please, let's look into more generic page table sharing just like
> hugetlb already provides to some degree. And if we need additional
> alignment requirements to share multiple page table levels, then let's
> look into that as well for special users.
> 

Thanks,
Khalid