Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp930043imw; Fri, 8 Jul 2022 14:38:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1umh7jbLRg8wzMISx+LKgPYQV/pVS6MzZOSXUqdrUEz1jsojbGDX8gGkb/g/xcrCbyWX+LW X-Received: by 2002:a17:902:e80a:b0:16a:311a:a672 with SMTP id u10-20020a170902e80a00b0016a311aa672mr5577885plg.161.1657316338581; Fri, 08 Jul 2022 14:38:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657316338; cv=none; d=google.com; s=arc-20160816; b=Ap7/uC4heLg2EMMXtPOaHQlP9PCwDR9OzRaSWAzOzJeLMvrE43D9qJv/zL1tuQouvY zkV3eSkpjmd5Sm6rBbX/NsVvTuxQ/2V4Kp2ibdSnJ/tqCMeXa8FvhkgL5NqZ7m9ma22a z9qrrHBRGfRdO6p0bJY5NpDb5yJ3IiU7kErPxeYOd/M6tyR6pa3hbbQxweW71OpVeiYd tBpiCJVF8eKK4HhSPLwmxyV3g7vIjm63YH29YzEZMSsyBzXxuMbsW2XS122zpYghcjpd wr8mExJ0enhRFHnqCtEU5APcbqkjq2AGGEAOgVO0evH2IqyRUL+uOKoNeijwUK+RG3J/ rUww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=42cZlLqESbSzGOIQC6IhKSPqgo/QyLTrwwAMCp9WNzo=; b=02AD55+SOjliUnSsHlK05NfBUVfirkqUZ00QIfiEm/mZ9vw5yjMn3Fs26ehAKjx4tc HWdTZzhMaR3sWUWEu8LbG8ZqpcWjKdU4jcX9sIf0DrDPVMV7OZrJIGi0woUaGxrHQAA9 JoxtQRIhpJGR3t8YOlnSdjLm2GF3VRDtv+L5xJ5D81okGmwNTm+F4Fs9oAC8GRQxntSN +46JVbocbzny3fcy+AKIdZw28I6t6wRWM6KEMrer8eoAxzOAJj7gGEe2IpgNPhUxf1G1 aP1MP5RFkO+FS3InABh7rEqQRqzzoNWljiGDmOHj64gGVBNExShLHHyOv9cxApUaNORc 443w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=IV0paG90; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f4-20020a655504000000b00412a9c163b3si3548386pgr.51.2022.07.08.14.38.45; Fri, 08 Jul 2022 14:38:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=IV0paG90; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238730AbiGHVYs (ORCPT + 99 others); Fri, 8 Jul 2022 17:24:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238447AbiGHVYq (ORCPT ); Fri, 8 Jul 2022 17:24:46 -0400 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABEB024BC4 for ; Fri, 8 Jul 2022 14:24:43 -0700 (PDT) Received: by mail-io1-xd2d.google.com with SMTP id p128so173703iof.1 for ; Fri, 08 Jul 2022 14:24:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=42cZlLqESbSzGOIQC6IhKSPqgo/QyLTrwwAMCp9WNzo=; b=IV0paG90JHXaGZbrxl8pRjANIsQWCXppiwcKYlmXVIxXcJ27wNUF4yH2g+6tA4C+qd mamfHwnW/lcS3+Uv/gPQPJf5q/UUMz6XSShpn+/NkJMb/c/gai50uarqyLdYdTFa7a08 wnNNt2hidpsVCeeD1GYrXUswLcElFqWYI67m0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=42cZlLqESbSzGOIQC6IhKSPqgo/QyLTrwwAMCp9WNzo=; b=iT7Q9eqFxL2KLYRnuaNTEaBiuvORsaY9ev5YuDfIMschGy0SvPlNUYfuLRqOEpYl5i GdZpGHuyDGSzFOEizOjSK45HkS2FDTrl79jnIXL+e3rpRKPEn4sslmcpQYY4I9eMXIQa N04XP2TPRhKdzCtBazq+qTOKhBZu1uy88Ji8eMMISd+GHf4ylSCXQEiQ+ZVSui8H6/4C KNCyxve01U8koIf/EUfolV6MDsSi8EmUrOKpAsiS/6bUhyL4ZB00Cs3M1mQcEdh4xkY8 FwcDggtDlM3DQxBR7KsGEGsDiXhw6tS6IQU3qQphvSS8JNnkpyHRB/IK4uohCwebYU+N 03EA== X-Gm-Message-State: AJIora+FYwhHrTP2YwG5xnkfjFCIHPgJuqNtvzhb3JjoPDHX7UlQTVOZ ZdRo5tMJQNTXNR5CzpByFkGbtg== X-Received: by 2002:a05:6638:438b:b0:33c:b617:fb46 with SMTP id bo11-20020a056638438b00b0033cb617fb46mr3370276jab.238.1657315483051; Fri, 08 Jul 2022 14:24:43 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id a13-20020a927f0d000000b002d8f50441absm16814624ild.10.2022.07.08.14.24.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Jul 2022 14:24:42 -0700 (PDT) Subject: Re: [PATCH v6 3/4] kunit: Taint the kernel when KUnit tests are run To: Daniel Latypov Cc: David Gow , Andrew Morton , Brendan Higgins , "Guilherme G . Piccoli" , Sebastian Reichel , John Ogness , Joe Fradley , Luis Chamberlain , Nathan Chancellor , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, Andy Shevchenko , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Jani Nikula , Lucas De Marchi , Aaron Tomlin , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, Michal Marek , Nick Desaulniers , Jonathan Corbet , linux-kbuild@vger.kernel.org, Greg KH , Masahiro Yamada , Kees Cook , Shuah Khan References: <20220708044847.531566-1-davidgow@google.com> <20220708044847.531566-3-davidgow@google.com> From: Shuah Khan Message-ID: Date: Fri, 8 Jul 2022 15:24:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/8/22 3:22 PM, Shuah Khan wrote: > On 7/8/22 3:00 PM, Daniel Latypov wrote: >> On Fri, Jul 8, 2022 at 1:22 PM Shuah Khan wrote: >>> >>> On 7/7/22 10:48 PM, David Gow wrote: >>>> Make KUnit trigger the new TAINT_TEST taint when any KUnit test is run. >>>> Due to KUnit tests not being intended to run on production systems, and >>>> potentially causing problems (or security issues like leaking kernel >>>> addresses), the kernel's state should not be considered safe for >>>> production use after KUnit tests are run. >>>> >>>> This both marks KUnit modules as test modules using MODULE_INFO() and >>>> manually taints the kernel when tests are run (which catches builtin >>>> tests). >>>> >>>> Acked-by: Luis Chamberlain >>>> Tested-by: Daniel Latypov >>>> Reviewed-by: Brendan Higgins >>>> Signed-off-by: David Gow >>>> --- >>>> >>>> No changes since v5: >>>> https://lore.kernel.org/linux-kselftest/20220702040959.3232874-3-davidgow@google.com/ >>>> >>>> No changes since v4: >>>> https://lore.kernel.org/linux-kselftest/20220701084744.3002019-3-davidgow@google.com/ >>>> >>> >>> David, Brendan, Andrew, >>> >>> Just confirming the status of these patches. I applied v4 1/3 and v4 3/4 >>> to linux-kselftest kunit for 5.20-rc1. >>> I am seeing v5 and v6 now. Andrew applied v5 looks like. Would you like >>> me to drop the two I applied? Do we have to refresh with v6? >> >> Just noting here that there'll be a merge conflict between this patch >> (3/4) and some other patches lined up to go through the kunit tree: >> https://patchwork.kernel.org/project/linux-kselftest/patch/20220625050838.1618469-2-davidgow@google.com/ >> >> Not sure how we want to handle that. >> > > I can go drop the two patches and have Andrew carry the series through > mm tree. > Sorry spoke too soon. Yes there are others that might have conflicts as Daniel pointed out: https://patchwork.kernel.org/project/linux-kselftest/patch/20220625050838.1618469-2-davidgow@google.com/ thanks, -- Shuah