Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759309AbXE3VrK (ORCPT ); Wed, 30 May 2007 17:47:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760107AbXE3Vq1 (ORCPT ); Wed, 30 May 2007 17:46:27 -0400 Received: from agminet01.oracle.com ([141.146.126.228]:11601 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760097AbXE3VqZ (ORCPT ); Wed, 30 May 2007 17:46:25 -0400 Message-ID: <465DF090.9090003@oracle.com> Date: Wed, 30 May 2007 14:45:52 -0700 From: Randy Dunlap User-Agent: Thunderbird 1.5.0.5 (X11/20060719) MIME-Version: 1.0 To: Christoph Lameter CC: Andrew Morton , linux-kernel@vger.kernel.org, hugh@veritas.com Subject: Re: [PATCH 1/3] hexdump: more output formatting References: <20070523004233.5ae5f6fd.akpm@linux-foundation.org> <46540DB2.5000605@googlemail.com> <4654AC94.6080601@googlemail.com> <20070523150122.f9946f37.akpm@linux-foundation.org> <20070523153730.e0e9e91d.akpm@linux-foundation.org> <20070523182145.7d7f1f7e.randy.dunlap@oracle.com> <20070524073131.GA17501@elte.hu> <20070524142908.f39f42ea.akpm@linux-foundation.org> <20070524145517.1f32cd94.randy.dunlap@oracle.com> <20070530143428.2f20446a.randy.dunlap@oracle.com> In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 927 Lines: 30 Christoph Lameter wrote: > On Wed, 30 May 2007, Randy Dunlap wrote: > >> Add an "ascii" output parameter. This causes ASCII data output >> following the hex data output. > > The ascii output is not properly aligned. Its simply thrown in > after the hex dump output. The last line of a multi line hexdump > will have the ascii output moved to the left. Its not properly adjusted. It was never a written requirement. :) but maybe it is now. >> + * >> * E.g.: >> * print_hex_dump(KERN_DEBUG, DUMP_PREFIX_ADDRESS, frame->data, frame->len); > > ^^^ needs to be updated? Yes, it does. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/