Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 8 Jul 2022 14:58:20 -0700
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Mattijs Korpershoek <mkorpershoek@baylibre.com>
Cc:     Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Fabien Parent <parent.f@gmail.com>,
        linux-input@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v3 0/2] Input: mt6779-keypad - fix hw code logic
 and row/col selection
Message-ID: <YsiofJQBZvLgQKSh@google.com>
References: <20220707075236.126631-1-mkorpershoek@baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220707075236.126631-1-mkorpershoek@baylibre.com>
Precedence: bulk

On Thu, Jul 07, 2022 at 09:52:34AM +0200, Mattijs Korpershoek wrote:
> Input: mt6779-keypad - fix hw code logic and row/col selection
> 
> This serie is the first follow-up on the mt6779-keypad in
> order to enable it on the MediaTek mt8183-pumpkin board.
> 
> To fully enable it on mt8183-pumpkin, we still need:
> * double key support
> * dts changes
> 
> To ease up reviewing, I preferred sending this first.
> 
> The first patch fixes a logic bug based on the (non-public) datasheet
> I have.
> The second patch configures the keypad correctly in order to not
> report bogus values.
> 
> Thank you,
> Mattijs
> 
> Changes in v3:
> * reworked row/column logic as discussed in [1]
> * Dropped Angelo's review since patch 1 changed
> 
> Changes in v2:
> * Simplified SEL_COL/ROW_MASK macros as suggested by Dmitry
> * Added Angelo's Reviewed-by on patch 1
> 
> Mattijs Korpershoek (2):
>   Input: mt6779-keypad - match hardware matrix organization
>   Input: mt6779-keypad - implement row/column selection
> 
>  drivers/input/keyboard/mt6779-keypad.c | 18 +++++++++++++++---
>  1 file changed, 15 insertions(+), 3 deletions(-)
> 
> [1] https://lore.kernel.org/r/YpMDZORAlHmg/x/0@google.com
> 
> base-commit: c4bcc1b99b8b8acdfe673e4701a9c2acb6b8b2fb
> -- 
> 2.34.1
> 

Applied the series, thank you.

-- 
Dmitry