Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220707135532.1783925-1-martin.blumenstingl@googlemail.com> <20220707222519.movgavbpbptncuu6@skbuf>
In-Reply-To: <20220707222519.movgavbpbptncuu6@skbuf>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Sat, 9 Jul 2022 00:28:51 +0200
Message-ID: <CAFBinCAcRDQQ51DUKr7K4Vtf3z61JTiNiB9saeKVsHs8qRJpXQ@mail.gmail.com>
Subject: Re: [PATCH 0/2] selftests: forwarding: Install two missing tests
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "edumazet@google.com" <edumazet@google.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "shuah@kernel.org" <shuah@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Vladimir,

On Fri, Jul 8, 2022 at 12:25 AM Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
>
> Hi Martin,
>
> On Thu, Jul 07, 2022 at 03:55:30PM +0200, Martin Blumenstingl wrote:
> > For some distributions (e.g. OpenWrt) we don't want to rely on rsync
> > to copy the tests to the target as some extra dependencies need to be
> > installed. The Makefile in tools/testing/selftests/net/forwarding
> > already installs most of the tests.
> >
> > This series adds the two missing tests to the list of installed tests.
> > That way a downstream distribution can build a package using this
> > Makefile (and add dependencies there as needed).
>
> Just for future reference, the netdev process is to mark patch sets such
> as this one with "PATCH net" since they fix a packaging problem with an
> rc kernel. There's more information about this in
> Documentation/process/maintainer-netdev.rst.
noted

> Do we need to create a Makefile for the selftests symlinked by DSA in
> tools/testing/selftests/drivers/net/dsa/, for the symlinks to be
> installed, or how do you see this?
Yes, we should have a Makefile there as well (IMO). I'll send a patch for this.

> The reason why I created the symlinks was to make use of the custom
> forwarding.config provided there, and also to reduce the clutter a bit
> and only focus on the selftests I felt were relevant for DSA for now.
Makes sense, I'll make sure that this one is installed by the Makefile as well


Best regards,
Martin