Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220708203549.3834790-1-justinstitt@google.com>
In-Reply-To: <20220708203549.3834790-1-justinstitt@google.com>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Fri, 8 Jul 2022 16:39:06 -0700
Message-ID: <CAKwvOdm9-pJ3AUzpkJwsssk9JCq1zWQt3DugQXF9rsi7YBQC2w@mail.gmail.com>
Subject: Re: [PATCH] mei: me: fix clang -Wformat warning
To:     Justin Stitt <justinstitt@google.com>
Cc:     Tomas Winkler <tomas.winkler@intel.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jul 8, 2022 at 1:36 PM Justin Stitt <justinstitt@google.com> wrote:
>
> When building with Clang we encounter the following warning:
> | drivers/misc/mei/hw-me.c:564:44: error: format specifies type 'unsigned
> | short' but the argument has type 'int' [-Werror,-Wformat]
> | dev_dbg(dev->dev, "empty slots = %hu.\n", empty_slots);
>
> The format specifier used is `%hu` which specifies an unsigned short,
> however, empty_slots is an int -- hence the warning.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/378
> Signed-off-by: Justin Stitt <justinstitt@google.com>

Thanks for the patch! This fixes the warning I observe when building
x86_64 allmodconfig with -Wno-format removed.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>

> ---
>  drivers/misc/mei/hw-me.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/mei/hw-me.c b/drivers/misc/mei/hw-me.c
> index befa491e3344..3a95fe7d4e33 100644
> --- a/drivers/misc/mei/hw-me.c
> +++ b/drivers/misc/mei/hw-me.c
> @@ -561,7 +561,7 @@ static int mei_me_hbuf_write(struct mei_device *dev,
>         dev_dbg(dev->dev, MEI_HDR_FMT, MEI_HDR_PRM((struct mei_msg_hdr *)hdr));
>
>         empty_slots = mei_hbuf_empty_slots(dev);
> -       dev_dbg(dev->dev, "empty slots = %hu.\n", empty_slots);
> +       dev_dbg(dev->dev, "empty slots = %d.\n", empty_slots);
>
>         if (empty_slots < 0)
>                 return -EOVERFLOW;
> --
> 2.37.0.rc0.161.g10f37bed90-goog
>


-- 
Thanks,
~Nick Desaulniers