Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 9 Jul 2022 02:10:49 +0200
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Laurent Vivier <laurent@vivier.eu>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        linux-m68k <linux-m68k@lists.linux-m68k.org>,
        Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] m68k: virt: Kconfig minor fixes
Message-ID: <YsjHiZeUxo7RXxAu@zx2c4.com>
References: <20220531174514.1586248-1-laurent@vivier.eu>
 <CAMuHMdUbUZU3YA6nDC_LDAfUYQVmHTuCzrCfxDqwF=ZZyR5fqw@mail.gmail.com>
 <YseHZq/u9OkVltxW@zx2c4.com>
 <CAMuHMdX7JPKJbth9xw4MbPbi29fgQNSva0r394JX-etEZiUJ_A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAMuHMdX7JPKJbth9xw4MbPbi29fgQNSva0r394JX-etEZiUJ_A@mail.gmail.com>
Precedence: bulk

Hi Geert,

On Fri, Jul 08, 2022 at 09:24:59AM +0200, Geert Uytterhoeven wrote:
> Hi Jason,
> 
> On Fri, Jul 8, 2022 at 3:25 AM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> > On Thu, Jun 02, 2022 at 09:13:14AM +0200, Geert Uytterhoeven wrote:
> > > On Tue, May 31, 2022 at 7:45 PM Laurent Vivier <laurent@vivier.eu> wrote:
> > > > Select VIRTIO_MENU as it is needed by VIRTIO_MMIO.
> > > >
> > > > Add an ending period at the end the virt machine help message.
> > > >
> > > > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > > > Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > > i.e. will queue in the m68k for-v5.20 branch.
> >
> > Shouldn't this fix make it for 5.19? It causes Kconfig warnings during
> > builds. So this seems like a ordinary mid-cycle bug that can be fixed.
> >
> > For example, if you ctrl+f for "unmet direct" in this log, you'll see
> > this splat in the wireguard CI:
> > https://build.wireguard.com/random/108f4fea7b6053dfd09039af74c0ac0c32c956be/m68k.log
> 
> These are merely configuration warnings, there is no build or runtime
> failure.
> I reverted this patch, disabled CONFIG_VIRTIO_MENU (which BTW defaults
> to y), built and booted a kernel fine, and could login on the console.
> 
> So IMHO it can wait.

Okay, no problem. I suppose 5.19 isn't likely to be an LTS anyway.

Jason