Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9f94800b-6c32-3fc0-97c4-728fc4641aef@linux.intel.com>
Date:   Fri, 8 Jul 2022 18:28:45 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [pdx86-platform-drivers-x86:review-hans 66/68]
 drivers/platform/x86/intel/vsec.c:475:6: warning: no previous prototype for
 'intel_vsec_pci_resume'
Content-Language: en-US
To:     Hans de Goede <hdegoede@redhat.com>,
        kernel test robot <lkp@intel.com>
Cc:     kbuild-all@lists.01.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-kernel@vger.kernel.org
References: <202207041814.S03OvoFK-lkp@intel.com>
 <c3982024-3351-956f-605f-ef8453848ff7@redhat.com>
From:   "Kammela, Gayatri" <gayatri.kammela@linux.intel.com>
In-Reply-To: <c3982024-3351-956f-605f-ef8453848ff7@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/8/2022 7:44 AM, Hans de Goede wrote:

> Hi,
>
> On 7/4/22 12:51, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-hans
>> head:   530ef2a6e81c74c19f918713e519e85652e53a83
>> commit: 1039bb2698ab299a1fc30a4fc2df237867c089e0 [66/68] platform/x86/intel/vsec: Add PCI error recovery support to Intel PMT
>> config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220704/202207041814.S03OvoFK-lkp@intel.com/config)
>> compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
>> reproduce (this is a W=1 build):
>>          # https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?id=1039bb2698ab299a1fc30a4fc2df237867c089e0
>>          git remote add pdx86-platform-drivers-x86 https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
>>          git fetch --no-tags pdx86-platform-drivers-x86 review-hans
>>          git checkout 1039bb2698ab299a1fc30a4fc2df237867c089e0
>>          # save the config file
>>          mkdir build_dir && cp config build_dir/.config
>>          make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/intel/
>>
>> If you fix the issue, kindly add following tag where applicable
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> drivers/platform/x86/intel/vsec.c:475:6: warning: no previous prototype for 'intel_vsec_pci_resume' [-Wmissing-prototypes]
>>       475 | void intel_vsec_pci_resume(struct pci_dev *pdev)
>>           |      ^~~~~~~~~~~~~~~~~~~~~
>>
>>
>> vim +/intel_vsec_pci_resume +475 drivers/platform/x86/intel/vsec.c
>>
>>     474	
>>   > 475	void intel_vsec_pci_resume(struct pci_dev *pdev)
>>     476	{
>>     477		dev_info(&pdev->dev, "Done resuming PCI device\n");
>>     478	}
>>     479	
>>
>
> I've squashed a patch marking intel_vsec_pci_resume() as static into my
> review-hans branch.
Thank you Hans!
>
> Regards,
>
> Hans
>