Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761611AbXE3Vwl (ORCPT ); Wed, 30 May 2007 17:52:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761163AbXE3Vv7 (ORCPT ); Wed, 30 May 2007 17:51:59 -0400 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:52506 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1761410AbXE3Vv5 (ORCPT ); Wed, 30 May 2007 17:51:57 -0400 Date: Wed, 30 May 2007 14:51:57 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Randy Dunlap cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3 -mm] slub: use lib/hexdump In-Reply-To: <465DF135.80202@oracle.com> Message-ID: References: <20070523004233.5ae5f6fd.akpm@linux-foundation.org> <46540DB2.5000605@googlemail.com> <4654AC94.6080601@googlemail.com> <20070523150122.f9946f37.akpm@linux-foundation.org> <20070523153730.e0e9e91d.akpm@linux-foundation.org> <20070523182145.7d7f1f7e.randy.dunlap@oracle.com> <20070524073131.GA17501@elte.hu> <20070524142908.f39f42ea.akpm@linux-foundation.org> <20070524145517.1f32cd94.randy.dunlap@oracle.com> <20070530143451.f4a844bc.randy.dunlap@oracle.com> <465DF135.80202@oracle.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 819 Lines: 21 On Wed, 30 May 2007, Randy Dunlap wrote: > > I'd like to keep print_section around as it also does some other things. > > Repeating the output formatting at the various call locations will make > > it difficult to change if you add another whizbang feature. > > I have no problems with keeping print_section() except that it's not used > in the current tree after this patch. :) > > > I have a patch here that I could sent out today if hexdump would work the > > right way. > > Please define "the right way." Align the ascii output so that it does not look that ugly. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/