Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp1173564imw; Fri, 8 Jul 2022 21:22:30 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sfPgOvdyPS8zkw/khDX7seCR1aCuUSx6XEpyfFfaMiughpMzltFuGYwIO8JmMOoVZl4gMO X-Received: by 2002:a05:6a00:2448:b0:528:7acc:363 with SMTP id d8-20020a056a00244800b005287acc0363mr6839800pfj.32.1657340550030; Fri, 08 Jul 2022 21:22:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657340550; cv=none; d=google.com; s=arc-20160816; b=QjhRA3aAG4sh99JiASZkEotxMXMZ9vaSWLrla/5gB+fK7EohhotRGbxwWS3ByJ3qrT WMYqnC5EtLf+qeaSmqRv14nbG4Mo4aU54DPJ3eSd8k4D5G1a/EKPpBqgyv42HoJsDaOo j7fS9lob0PEIOT339CtkOl2jTdKYgTd30YVLhQrgss11XHqM86F5h2zPSRmMKt2PngyZ 3Kh2BFgHtKJGJQnZtoys1WEucYnLynw0RV0uN/ROnI2M2J6NFdF0zOaEt7sq3ke/DtuM dY8HONiDiBBuBUckI34Mv9J4RX+YPYGY4bwu/xQfMJRThlFO4OdfhH1QAhnNQ5yzhlyH i+zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=t86QmQn8P9lUXSjWP8/f2AF2xCFy1NYjD46xzZ+Dd1c=; b=H0iTyY5qhWo5Wowz9mjBGi7HWcUp/PED4j7h2avRWKtCiIvumVsVKtsLeCxb+WiCac iB3gjYJRgM/dAIXRQMFFm2mkG34YBl7amGqBZ49obVW2T55yjfMqutHxXRmtgxW44/uC cj+pcI+XzH6ViI29/9dNpWX7Soe65noez6PaCeEFlXMLueD68h812uFUdp8j8v2GBJ0P aGeLBd+o8oxDCZTBJYH+t3CKiwDet/3LIjeQILD13G9QB+gSpwJMiGIGH50ZsFCPsPqC wty3ztQIAsL8TamDOj7c5o/wyuN0Cn74oi56ANLZAjtdHPIJ8S0PsvL8wfVYe7IcMOJV Jitw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nw13PnU9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m12-20020a17090a858c00b001eccd271cd1si4533959pjn.82.2022.07.08.21.22.17; Fri, 08 Jul 2022 21:22:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nw13PnU9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229534AbiGIDdN (ORCPT + 99 others); Fri, 8 Jul 2022 23:33:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbiGIDdL (ORCPT ); Fri, 8 Jul 2022 23:33:11 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D38A820C0; Fri, 8 Jul 2022 20:33:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DD9FAB82A1D; Sat, 9 Jul 2022 03:33:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D514C341C0; Sat, 9 Jul 2022 03:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657337587; bh=ugFiovc7m44b0FenhKNQS4eDQkaEmy5xYxTtkxV3VwE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nw13PnU9WR7nVwr7el2uN1RZQMij8FRaksYLlNZjlas3xs/v3QMXvhC/W8r+AjvMr Su18Ya3ikZDd1O+GYyzwqcn/kdbguZ6TyNNOkjqnfoqR7vcTxGIWWlCQOmTDVQC2Oy L18p8I24prY8mZMbvewHuVc/4Q9T5HzKNL7emS+Q/V2+BTBkTX/3YVEmu0mF+GucLi Zi3sW7VnL59wky7ZLF+fm4i0bUeAh9QYuSRgGezvJ/5bFGgpT9f3aTbDlTt8jvL0Bc uGpkvoHTfORaNYN8HsnGJY6/66X1xKUcW7CT09gzzNSSuGBcz24H4SApDqgXMAlmM7 GthpTEC8gObvw== Date: Fri, 8 Jul 2022 20:33:06 -0700 From: Jakub Kicinski To: Bo Liu Cc: , , , , , , , Subject: Re: [PATCH] net: wwan: call ida_free when device_register fails Message-ID: <20220708203306.599d1cda@kernel.org> In-Reply-To: <20220708020223.4234-1-liubo03@inspur.com> References: <20220708020223.4234-1-liubo03@inspur.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 7 Jul 2022 22:02:23 -0400 Bo Liu wrote: > Subject: [PATCH] net: wwan: call ida_free when device_register fails > Date: Thu, 7 Jul 2022 22:02:23 -0400 > X-Mailer: git-send-email 2.18.2 > > when device_register() fails, we should call ida_free(). We'll need a Fixes tag pointing to the commit where the problem was introduced. Please add it above your sign-off tag and repost.