Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp1336640imw; Sat, 9 Jul 2022 02:17:14 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vyK3BH+y/NeRbYTiRUuNBajhYKpT9IPXVFSbx9AURGphmZEjW56wkwKFAYsnP77Yp8xr7G X-Received: by 2002:a05:6402:248d:b0:437:dd4c:e70e with SMTP id q13-20020a056402248d00b00437dd4ce70emr10086634eda.75.1657358234100; Sat, 09 Jul 2022 02:17:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657358234; cv=none; d=google.com; s=arc-20160816; b=ZlzNX8+T+ql22AeKyx9XOimdlOg4uCIbVMOgvLDCq8IaWggklg7r5oNIsZ1bvdXB7B bCAuc7F0yu478teopV1BC/60mOvtdhtgneB/izwBdeeHzYRAE55Vid3BjYk2p7E0iy3V UQHKJ1UB+PzcWFvF7rnbLc7o4Tf1FXqwVUvBHFdWchAyz/iCkSqBq9yJiQwfw39Uhfk9 0Pgy2vf92HC3CM2lB656Bksa0gpuxGXjbWh3aNF410uJ9kw0DDOw+5HcIvQDAWReteEu +GUlHUmLDS1cYhXIvUM5Fomi3DRjEia6MBuMwW8s3Lnkg2bOEDZgqMpuYE2ipOXi76vj T4fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=X2E3cLpkzfo9Q9OxMt+7ijC7f1+hm9TUD/OSjcyYx04=; b=gZ6vuTbFaGCsjPsTg1tZy/loc2Mw1XltHUkPtfQ3qR++08S6IBjNz3X0F6w8urQLaN K3bJsznGEkNMCtHpeHtWFzhelR2hOfwK21XueUGzCivVin5YlZc/BFEL73KUZ/pNY4Tl nHc1FJSU19ffDM9kTeRwIRnFPF40J0EcS+cJ6YV6r8hBtZ2YAkI8rFY7qe/qEqWhI1c4 oqMjb2ifEXuj3+UpLocs2yLbSStofdnHX6NfIRkCI9m/TqeXO/8r4Gx3TevsrqztOJH5 Y/Klamj8nUTup6foex76nStbAyxAdhUYkJCZoPRU9SVs9Vk9N/Tt6z7HJUmPSRTT+B/u u/cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gentoo.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d16-20020a056402401000b0043ab4c9f831si1706681eda.26.2022.07.09.02.16.20; Sat, 09 Jul 2022 02:17:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gentoo.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229551AbiGIIsN (ORCPT + 99 others); Sat, 9 Jul 2022 04:48:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbiGIIsM (ORCPT ); Sat, 9 Jul 2022 04:48:12 -0400 X-Greylist: delayed 28006 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sat, 09 Jul 2022 01:48:11 PDT Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27E084E621; Sat, 9 Jul 2022 01:48:11 -0700 (PDT) Date: Sat, 9 Jul 2022 16:48:05 +0800 From: Yixun Lan To: Christoph Hellwig Cc: Yonghong Song , Andrii Nakryiko , Alan Maguire , Palmer Dabbelt , linux-riscv@lists.infradead.org, Paul Walmsley , Albert Ou , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , John Fastabend , KP Singh , open list , Networking , bpf Subject: Re: [PATCH] RISC-V/bpf: Enable bpf_probe_read{, str}() Message-ID: References: <20220703130924.57240-1-dlan@gentoo.org> <712c8fac-6784-2acd-66ca-d1fd393aef23@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph: On 23:24 Fri 08 Jul , Christoph Hellwig wrote: > On Sat, Jul 09, 2022 at 09:01:10AM +0800, Yixun Lan wrote: > > Please check the ongoing discussion [0] in the bcc tools if you're > > interested in, advice and comments are welcome > > > > [0] https://github.com/iovisor/bcc/pull/4085#issuecomment-1179446738 > > I can't find a way to post there, as replying eems to require a login. > Is there a mailing list discussion somewhere that is broadly accessible? never mind, I think the logic is quite clear, we can do something in bcc: 1) adopt new _{kernel,user} interface whenever possible, this will work fine for all arch with new kernel versions 2) for old kernel versions which lack the _{kernel,user} support, fall back to old bpf_probe_read(), but take care of the Archs which have overlaping address space - like s390, and just error out for it -- Yixun Lan (dlan) Gentoo Linux Developer GPG Key ID AABEFD55