Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220709000636.35550-1-andriy.shevchenko@linux.intel.com>
 <20220709000636.35550-2-andriy.shevchenko@linux.intel.com>
 <9826f272-ed7d-1daa-c852-6f353258bb2b@redhat.com> <CAHp75VfVoTcZD7vXxXckxu-crsXr7m4bx8F9D9cs2TtBbyeYqQ@mail.gmail.com>
 <154a12ef-29a7-8189-1a5d-648dc92cffd3@redhat.com>
In-Reply-To: <154a12ef-29a7-8189-1a5d-648dc92cffd3@redhat.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sat, 9 Jul 2022 13:34:08 +0200
Message-ID: <CAHp75Vcfr9mjgWPRwg8i5OatEyLCDR-vMazarSAtJXd_-Fee-w@mail.gmail.com>
Subject: Re: [PATCH v1 2/7] platform/x86: serial-multi-instantiate: Improve autodetection
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Mark Gross <markgross@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Jul 9, 2022 at 1:00 PM Hans de Goede <hdegoede@redhat.com> wrote:
> On 7/9/22 11:52, Andy Shevchenko wrote:
> > On Saturday, July 9, 2022, Hans de Goede <hdegoede@redhat.com <mailto:h=
degoede@redhat.com>> wrote:
> >     On 7/9/22 02:06, Andy Shevchenko wrote:

...

> >     So nack for this
> >
> > This effectively means nack to the series.

> > But it=E2=80=99s easy to fix. I can add check for ret =3D=3D 0.

So, are you okay with fixing it this way? See below how.

> I don't see how this is a nack for the series, just drop 1/7 + 2/7
> and rebase the rest. Yes there will be conflicts to resolve in
> the rebase, but the rest of the cleanups can still go upstream
> after the rebase.

Because patch 3 makes a little sense on its own if we drop the patch
2. The rest is the simple cleanups which I do not consider as a core
of this series.

> >     >       case SMI_AUTO_DETECT:
> >     > -             if (i2c_acpi_client_count(adev) > 0)
> >     > -                     return smi_i2c_probe(pdev, adev, smi, node-=
>instances);
> >     > -             else
> >     > -                     return smi_spi_probe(pdev, adev, smi, node-=
>instances);
> >     > +             ret =3D smi_i2c_probe(pdev, adev, smi, node->instan=
ces);
> >     > +             if (ret && ret !=3D -ENOENT)
> >     > +                     return ret;

/*
 * ...comment about why we do the following check...
 */
 if (ret =3D=3D 0)
  return ret;

> >     > +             ret =3D smi_spi_probe(pdev, adev, smi, node->instan=
ces);
> >     > +             if (ret && ret !=3D -ENOENT)
> >     > +                     return ret;
> >     > +             if (ret)
> >     > +                     return dev_err_probe(dev, ret, "Error No re=
sources found\n");
> >     > +             break;

if (ret =3D=3D -ENOENT)
  return dev_err_probe(...);
return ret;

--=20
With Best Regards,
Andy Shevchenko