Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220708084816.1140540-1-PaddyKP_Yao@asus.com> <20220708090731.1237488-1-PaddyKP_Yao@asus.com>
In-Reply-To: <20220708090731.1237488-1-PaddyKP_Yao@asus.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sat, 9 Jul 2022 13:44:16 +0200
Message-ID: <CAHp75Vc-5Py8heCJ4bKh1-7y+U+ycJxRuYdFwiT=NM5=gLqwQw@mail.gmail.com>
Subject: Re: [PATCH 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev support
To:     PaddyKP_Yao <ispaddy@gmail.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <mgross@linux.intel.com>,
        Corentin Chary <corentin.chary@gmail.com>,
        Luke Jones <luke@ljones.dev>, PaddyKP_Yao@asus.com,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        acpi4asus-user <acpi4asus-user@lists.sourceforge.net>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

You have sent two patches with the same version, your submission
confuses everybody, which one are we supposed to consider?

On Fri, Jul 8, 2022 at 11:08 AM PaddyKP_Yao <ispaddy@gmail.com> wrote:
>
> In some new ASUS devices, hotkey Fn+F13 is used for mic mute. If mic-mute
> LED is present by checking WMI ASUS_WMI_DEVID_MICMUTE_LED, we will add a
> mic-mute LED classdev, asus::micmute, in the asus-wmi driver to control
> it. The binding of mic-mute LED controls will be swithched with LED

switched

> trigger.

...

Not reviewing code because of the above.

Hint: `git format-patch -vX ...`, where X is a version number will
help. And when cooking a new version don't forget to add a changelog
between versions.

-- 
With Best Regards,
Andy Shevchenko