Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759990AbXE3WSS (ORCPT ); Wed, 30 May 2007 18:18:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756124AbXE3WSJ (ORCPT ); Wed, 30 May 2007 18:18:09 -0400 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:53660 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756012AbXE3WSI (ORCPT ); Wed, 30 May 2007 18:18:08 -0400 Date: Wed, 30 May 2007 15:18:07 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Satyam Sharma cc: Randy Dunlap , Andrew Morton , linux-kernel@vger.kernel.org, hugh@veritas.com Subject: Re: [PATCH 1/3] hexdump: more output formatting In-Reply-To: Message-ID: References: <20070523004233.5ae5f6fd.akpm@linux-foundation.org> <20070524073131.GA17501@elte.hu> <20070524142908.f39f42ea.akpm@linux-foundation.org> <20070524145517.1f32cd94.randy.dunlap@oracle.com> <20070530143428.2f20446a.randy.dunlap@oracle.com> <465DF49B.7040100@oracle.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 705 Lines: 21 On Thu, 31 May 2007, Satyam Sharma wrote: > Yes, you're right, but I was just wondering whether any users really > cared enough about the rowsize and groupsize, also seeing that > accommodating these two args leads to a lot of increase in code. Have two functions 1. A function that prints full lines with address and ascii This defaults to 16 bytes by default + ascii. hex_dump? 2. A function to convert a few bytes for use in other output. sprint_hex? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/