Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8b893c42-e514-bcef-0513-070b3723cdcc@redhat.com>
Date:   Sat, 9 Jul 2022 16:56:15 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly
 G2
Content-Language: en-US
To:     Alex Dewar <alex.dewar@gmx.co.uk>, dmitry.torokhov@gmail.com,
        tiwai@suse.de, markgross@kernel.org
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        platform-driver-x86@vger.kernel.org
References: <20220629094314.b7xmfb3xccj7vs6v@ic-alex-elitebook>
 <3fedf676645bfa638c9a6c656121083abc2c98ea.camel@gmx.co.uk>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <3fedf676645bfa638c9a6c656121083abc2c98ea.camel@gmx.co.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 7/5/22 19:25, Alex Dewar wrote:
> Friendly ping? ????
> 
> I'm also CC'ing the x86 platform people into this, as I'm not sure
> whether this problem is something more within their remit.

Please test the atbkd device with "sudo evemu-record" or "sudo evtest"
and if the brightness keys generate events there, write down the
raw event codes (MSC events).

Assuming the brightness keys indeed send events here, then:

After that you need to create an update to:
/lib/udev/hwdb.d/60-keyboard.hwdb to fix the mapping for your laptop.
See the "To update this file, create a new file ..." section.

You can find the DMI match pattern used in this file by doing:

cat /sys/class/dmi/id/modalias

Once you have things working, please submit a pull-req to upstream
systemd to get these quirk included in the offical hwdb. Or send
me a copy of the local 70-keyboard.hwdb override you have created
and I can submit it upstream for you.

Regards,

Hans


> 
> Best,
> Alex
> 
> On Wed, 2022-06-29 at 10:43 +0100, Alex Dewar wrote:
>> Hi,
>>
>> I'm running Linux 5.18.7 on an HP Elite Dragonfly G2 laptop, which
>> seems
>> to use the i8042 driver. Mostly things seem to work (including
>> hotkeys)
>> except that the increase/decrease brightness keys instead send the
>> "mic
>> mute" keycode. (The *actual* mic mute key works fine.)
>>
>> Any ideas? Do we need to add a quirk?
>>
>> Best,
>> Alex
>