Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp1737676imw; Sat, 9 Jul 2022 10:28:37 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vAs6Gm3NHuTEmIFsN1YPi656QAIX5fJTfuTJQgnKYq2Dy8fuWsJD2+Yq0yfKto9gjgaZgH X-Received: by 2002:a17:902:da82:b0:16a:7ca5:36df with SMTP id j2-20020a170902da8200b0016a7ca536dfmr9795039plx.91.1657387716771; Sat, 09 Jul 2022 10:28:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657387716; cv=none; d=google.com; s=arc-20160816; b=Z/U2f8DeTI7dL9Qnk/BSoKDAZ1qr3dpZRDytB8WP/4olwor3nAjvvloPDTCgNWnc8e dOminEZbtloir4hQEul1MtAT9C2Kvj5roZ/YUrUOKw1qaVRmpVVCl6s5w305jsevvYEd JYO1aZNUQWeSxwRylfS555cd5VJUghLRRjFmgU8iGn1tST6frVpX97sMsQa7Pot7OPf6 T063R59So/4sm4tmGgkdrM+V6KVCV5EJF8Iad017BvgJ9tULJNmePZTedBfc8fuv7rzN MS8oZYa9i91PEymF3e0Er5QLMvPTbxg8yC6Ew6z3HOCendSh5wshSYop7Ma5Y/NtncGr 3lRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=qpydmWu46Ig8j63BypKgQQomfOL3GkuxoIUJ5XeOGBI=; b=rvivBLY5K+lm9d6nIrDLQ27ClEAG5ADdg8diiofhEltWSPcXulzXxHquzvMzZi6FhA rryTAeaZy5/puUYk2G9p/opmSoxUrT8dkcHpBXdfBiuGgkETKCtqovuAYOhe3i8wTuxF F0V6nPgmvvLloj7BmV2Gz490HdQ5d3xSVff6Z/kEHgPdsuuwYEmeMsf0Ro1aikTkftr9 6C4jxY9JW6xemst0HbRzApw1a3w7rSf/Rf3XiZ9VMowX/MsiqJiog4o7mMuVUXAakJfH GsDdODj5SRRoGxEoxF2GTBh5viX3V0TkuxYlN7keu9wNxpKfuTU+gR+ALJKdl1ZTtmu2 L4Gg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p32-20020a631e60000000b00411806249d6si1931658pgm.762.2022.07.09.10.28.17; Sat, 09 Jul 2022 10:28:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229796AbiGIRK5 (ORCPT + 99 others); Sat, 9 Jul 2022 13:10:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbiGIRK3 (ORCPT ); Sat, 9 Jul 2022 13:10:29 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D138120BA for ; Sat, 9 Jul 2022 10:10:28 -0700 (PDT) Received: from dslb-188-096-144-007.188.096.pools.vodafone-ip.de ([188.96.144.7] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1oADyH-0005n0-BG; Sat, 09 Jul 2022 19:10:21 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 11/14] staging: r8188eu: offset is always 0 in iol_read_efuse Date: Sat, 9 Jul 2022 19:09:57 +0200 Message-Id: <20220709171000.180481-12-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220709171000.180481-1-martin@kaiser.cx> References: <20220709171000.180481-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The offset parameter of iol_read_efuse is always 0. Remove the parameter and use 0 in the function body. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c index 674ba420a272..f552b9adece3 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c @@ -299,7 +299,7 @@ static int efuse_read_phymap_from_txpktbuf( return 0; } -static s32 iol_read_efuse(struct adapter *padapter, u16 offset, u16 size_byte, u8 *logical_map) +static s32 iol_read_efuse(struct adapter *padapter, u16 size_byte, u8 *logical_map) { s32 status = _FAIL; u8 physical_map[512]; @@ -311,7 +311,7 @@ static s32 iol_read_efuse(struct adapter *padapter, u16 offset, u16 size_byte, u status = iol_execute(padapter, CMD_READ_EFUSE_MAP); if (status == _SUCCESS) efuse_read_phymap_from_txpktbuf(padapter, 0, physical_map, &size); - efuse_phymap_to_logical(physical_map, offset, size_byte, logical_map); + efuse_phymap_to_logical(physical_map, 0, size_byte, logical_map); return status; } @@ -538,7 +538,7 @@ void rtl8188e_ReadEFuse(struct adapter *Adapter, u16 _size_byte, u8 *pbuf) rtl8188eu_InitPowerOn(Adapter); iol_mode_enable(Adapter, 1); - ret = iol_read_efuse(Adapter, 0, _size_byte, pbuf); + ret = iol_read_efuse(Adapter, _size_byte, pbuf); iol_mode_enable(Adapter, 0); if (_SUCCESS == ret) -- 2.30.2