Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp1738076imw; Sat, 9 Jul 2022 10:29:18 -0700 (PDT) X-Google-Smtp-Source: AGRyM1usrM3LgeopNZUuA5ifV+WsnYz6P0oWjB1RlrKLY/Bht1/EQ/wBj87j+G5OBhAG2GTzGE1I X-Received: by 2002:a17:903:2450:b0:16c:1785:d814 with SMTP id l16-20020a170903245000b0016c1785d814mr9619721pls.20.1657387757868; Sat, 09 Jul 2022 10:29:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657387757; cv=none; d=google.com; s=arc-20160816; b=mmYwDHETP3qHUe9o0DQjbU/9/bu634QH05laAa2ukNKVKTXieOaiqXNvu9YD0FYk89 NQPxDfl7J/fMEWteC59UssrN/WI0JYJm8NCiud4XfCXMaKWuwOfVqYaksMLVItN0tK1x KDYrnclm81J0AbXySuLq+ARE3I0ffpCCbmyhSDV/E3mSmka5+dVA8ItsBmKOXz+rLlVd agSSf3onhHCkj/SystZ4tjzL9GUySP8BWTolMgGNIXqTVNW9Kxtt9N/IIWK98YsWcl+U iBnJjeUqGV0503G+H2Dz1cowElRmgL3VZQL8R26SMGdBZNuDEontB3JzxbUjYOCC2S0f 2Alg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Kec+EUocH6lVKfkYY+oc472gGXnX5WUojtsnsV4btY8=; b=g54XC5sKkvAwiuPGev6JEvPvTSIFMMok/krEmmVAqY7zDom+zfC4dvf+EOKmBL01BT 27q8N9Un9MSYMZYWzv38EmQpvy0mQwqYAEPEft//Nx6tH7iSveQZ7arsMBJOA40GiHpR bEoJRxnRJ+8x2Gx2ukJ5ui+q4ytYfYXCToFv+craxr4KeDaOs7YeRWdMjggH4feGB6wE lyPRLzJ3fPEPXetGNy/i3ycvkUtRmkISvHd8GvsXvabR3Rk01+8JEz7m5SgRFBpMhPgv D7ds9vU29Do59kz992feSC47k+qRyF2U9oH21GXA1kfZL4SK/8ElSE6fvVyE7Wq/pmW9 kJbg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m13-20020a17090ade0d00b001e684125756si2560187pjv.142.2022.07.09.10.29.06; Sat, 09 Jul 2022 10:29:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229791AbiGIRKv (ORCPT + 99 others); Sat, 9 Jul 2022 13:10:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229684AbiGIRK3 (ORCPT ); Sat, 9 Jul 2022 13:10:29 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 149521A3AD for ; Sat, 9 Jul 2022 10:10:26 -0700 (PDT) Received: from dslb-188-096-144-007.188.096.pools.vodafone-ip.de ([188.96.144.7] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1oADyJ-0005n0-0S; Sat, 09 Jul 2022 19:10:23 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 13/14] staging: r8188eu: efuse_utilized is never read Date: Sat, 9 Jul 2022 19:09:59 +0200 Message-Id: <20220709171000.180481-14-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220709171000.180481-1-martin@kaiser.cx> References: <20220709171000.180481-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The efuse_utilized variable in function efuse_phymap_to_logical is written to but never read. Remove it. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c index 87ebfb013193..ddda3f994fa7 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c @@ -91,7 +91,6 @@ efuse_phymap_to_logical(u8 *phymap, u16 _size_byte, u8 *pbuf) u8 offset, wren; u16 i, j; u16 **eFuseWord = NULL; - u16 efuse_utilized = 0; u8 u1temp = 0; efuseTbl = kzalloc(EFUSE_MAP_LEN_88E, GFP_KERNEL); @@ -113,7 +112,6 @@ efuse_phymap_to_logical(u8 *phymap, u16 _size_byte, u8 *pbuf) /* */ rtemp8 = *(phymap + eFuse_Addr); if (rtemp8 != 0xFF) { - efuse_utilized++; eFuse_Addr++; } else { goto exit; @@ -151,13 +149,11 @@ efuse_phymap_to_logical(u8 *phymap, u16 _size_byte, u8 *pbuf) if (!(wren & 0x01)) { rtemp8 = *(phymap + eFuse_Addr); eFuse_Addr++; - efuse_utilized++; eFuseWord[offset][i] = (rtemp8 & 0xff); if (eFuse_Addr >= EFUSE_REAL_CONTENT_LEN_88E) break; rtemp8 = *(phymap + eFuse_Addr); eFuse_Addr++; - efuse_utilized++; eFuseWord[offset][i] |= (((u16)rtemp8 << 8) & 0xff00); if (eFuse_Addr >= EFUSE_REAL_CONTENT_LEN_88E) @@ -170,7 +166,6 @@ efuse_phymap_to_logical(u8 *phymap, u16 _size_byte, u8 *pbuf) rtemp8 = *(phymap + eFuse_Addr); if (rtemp8 != 0xFF && (eFuse_Addr < EFUSE_REAL_CONTENT_LEN_88E)) { - efuse_utilized++; eFuse_Addr++; } } @@ -190,10 +185,6 @@ efuse_phymap_to_logical(u8 *phymap, u16 _size_byte, u8 *pbuf) /* */ memcpy(pbuf, efuseTbl, _size_byte); - /* */ - /* 5. Calculate Efuse utilization. */ - /* */ - exit: kfree(efuseTbl); kfree(eFuseWord); -- 2.30.2