Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp1738895imw; Sat, 9 Jul 2022 10:30:21 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sEVX6p1UVHZGpwsj8t//CQnr5fXgCM3IVNJpnuFLltO2lqWULA0IfI3IhzmJ5iR1hYbEMB X-Received: by 2002:a17:907:1c83:b0:726:2d64:6c5e with SMTP id nb3-20020a1709071c8300b007262d646c5emr9589267ejc.610.1657387821320; Sat, 09 Jul 2022 10:30:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657387821; cv=none; d=google.com; s=arc-20160816; b=ldP2sLxVC3Zom/6mrwZ53K+RTDDCfvtG7b2JfNILRdLgyiu9fptxqQpA5Fpcz6t3xJ ltaQrgjxI+6MjlHHQMBxN7mID8snHUNYY4jj+mjW70sCtyVdRK89sOf4JCZJWHLDwvsn HtoBRKj44NQtXnodSEU89niJHEfE4gGROQuoH/xCdSa8tZA/Xnuc81agmVwjIuq+OPPe jfufIW/riSIrNC+TvcY9RwJZjHh87S8CiJql691w+Up6s7iB+46cFYQz54yNTsoxbn/i 6rVZKDPlhzJMA2NWfsIupmRreMQz0xQWxXrl7t+psbNa/PdNLRuobIFeg/TuOUv8bPUx 5awg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=PilAgJ83dbB/7j3GySz1F682BmCKkv0HeRcmZg/V6gU=; b=Mlam1dcOY65ROmdhkha41YaTqNKB5Q9eyKFtnnTtYi36dYwpLUsf1sF9VKnp22LzFU LLYCglidI2E4jMnqNw6DjiikcbkubkBZAIxa5o9nJt+8zgt4bTXxmBSjv9vKgXijdZVC 1e+QkIztW0Yq1+gTUBt2kgC9WN2nyWrmwYLNEN+a/SPIwv9+1IX0Hz4YA44tlBawsjwm wqpY6lzsu5wExC3r/02hu5snSvKkOGv0Ddwbll3CLo0t5MMWQpogXdr4siGCuREhurnO ELNB3IT8ObbTsmbdAhqxMXEboN78UCcRN+ihQ+I0dtBEFZBMKbWRPzYmXxOaesY2QQOA huEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hc12-20020a170907168c00b0072afb8071d1si3434603ejc.633.2022.07.09.10.29.56; Sat, 09 Jul 2022 10:30:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229784AbiGIRKt (ORCPT + 99 others); Sat, 9 Jul 2022 13:10:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229680AbiGIRK2 (ORCPT ); Sat, 9 Jul 2022 13:10:28 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1499A1A3BB for ; Sat, 9 Jul 2022 10:10:27 -0700 (PDT) Received: from dslb-188-096-144-007.188.096.pools.vodafone-ip.de ([188.96.144.7] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1oADyF-0005n0-OR; Sat, 09 Jul 2022 19:10:19 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 09/14] staging: r8188eu: txpktbuf_bndy is always 0 Date: Sat, 9 Jul 2022 19:09:55 +0200 Message-Id: <20220709171000.180481-10-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220709171000.180481-1-martin@kaiser.cx> References: <20220709171000.180481-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The only caller of iol_read_efuse sets the txpktbuf_bndy parameter to 0. Remove the parameter from iol_read_efuse and use 0 in the function body. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c index 0cb653002660..24699e99edff 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c @@ -299,18 +299,18 @@ static int efuse_read_phymap_from_txpktbuf( return 0; } -static s32 iol_read_efuse(struct adapter *padapter, u8 txpktbuf_bndy, u16 offset, u16 size_byte, u8 *logical_map) +static s32 iol_read_efuse(struct adapter *padapter, u16 offset, u16 size_byte, u8 *logical_map) { s32 status = _FAIL; u8 physical_map[512]; u16 size = 512; - rtw_write8(padapter, REG_TDECTRL + 1, txpktbuf_bndy); + rtw_write8(padapter, REG_TDECTRL + 1, 0); memset(physical_map, 0xFF, 512); rtw_write8(padapter, REG_PKT_BUFF_ACCESS_CTRL, TXPKT_BUF_SELECT); status = iol_execute(padapter, CMD_READ_EFUSE_MAP); if (status == _SUCCESS) - efuse_read_phymap_from_txpktbuf(padapter, txpktbuf_bndy, physical_map, &size); + efuse_read_phymap_from_txpktbuf(padapter, 0, physical_map, &size); efuse_phymap_to_logical(physical_map, offset, size_byte, logical_map); return status; } @@ -538,7 +538,7 @@ void rtl8188e_ReadEFuse(struct adapter *Adapter, u16 _offset, u16 _size_byte, u8 rtl8188eu_InitPowerOn(Adapter); iol_mode_enable(Adapter, 1); - ret = iol_read_efuse(Adapter, 0, _offset, _size_byte, pbuf); + ret = iol_read_efuse(Adapter, _offset, _size_byte, pbuf); iol_mode_enable(Adapter, 0); if (_SUCCESS == ret) -- 2.30.2