Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760330AbXE3WaX (ORCPT ); Wed, 30 May 2007 18:30:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751370AbXE3WaB (ORCPT ); Wed, 30 May 2007 18:30:01 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:43046 "EHLO amd.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751017AbXE3WaA (ORCPT ); Wed, 30 May 2007 18:30:00 -0400 Date: Thu, 31 May 2007 00:29:56 +0200 From: Pavel Machek To: "Rafael J. Wysocki" Cc: Alan Stern , pm list , LKML , Matthew Garrett , Nigel Cunningham , Oliver Neukum Subject: Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers Message-ID: <20070530222956.GD27309@elf.ucw.cz> References: <20070530153740.GA4772@ucw.cz> <200705302244.25927.rjw@sisk.pl> <200705302311.40123.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705302311.40123.rjw@sisk.pl> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.11+cvs20060126 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1194 Lines: 28 Hi! > > I think the rule should be: If you need to do something _before_ tasks are > > frozen, do it in PM_PRE_FREEZE, but if you can do that after the tasks have > > been frozen, do it on PM_HIBERNATION_PREPARE (or PM_SUSPEND_PREPARE in the > > suspend case). > > OTOH, having considered it for a while, I think that for now I can add just > PM_PRE_FREEZE and PM_POST_THAW, as I don't have any user for the other ones. > The other events may be added in the future if need be (along with some users). > > I'll post revised patches in a new thread. Yes please. (Hmm, but you may create 4 of them PM_PRE_HIBERNATION, PM_PRE_SUSPEND, PM_POST_HIBERNATION, PM_POST_SUSPEND -- I'd call all of them before freeze and after thaw, but if we drop freezer for suspend, we won't have to rename anything.) Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/