Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 10 Jul 2022 10:29:26 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Hans Schultz <netdev@kapio-technology.com>
Cc:     davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
        Ivan Vecera <ivecera@redhat.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Shuah Khan <shuah@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org,
        linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v4 net-next 6/6] selftests: forwarding: add test of
 MAC-Auth Bypass to locked port tests
Message-ID: <Ysp/1k6uwcmJIon0@shredder>
References: <20220707152930.1789437-1-netdev@kapio-technology.com>
 <20220707152930.1789437-7-netdev@kapio-technology.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220707152930.1789437-7-netdev@kapio-technology.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rIFVUEMnobqTm4l/xPUx32vW3AaQdQoDcqOXAiRy3A0jOl1agaYads7MIgin?=
 =?us-ascii?Q?BGoNLucSfKfTzxCQ2sF7a3PpGJ6kFklX2CDRZv3fJBHWRWw5V1P7KIrKgefP?=
 =?us-ascii?Q?QdNRQ4yOkTP2Lr6t0Ia7hfFL7xcNWpj2lMgzme4TQ1+CziCBDgUyukNnOfIv?=
 =?us-ascii?Q?YldzqjEd3UGk7G7y50Zgb1l6lk2tAt/buMl6u8Ypq5EwQPSprZtMj3O6cxvV?=
 =?us-ascii?Q?inDtFPfuKc+0Bj9R9JsTc5Mtxmzx1cX7cYjOAJ1LjylAYvktpl5qYubWs4tA?=
 =?us-ascii?Q?jHTFYheNNg4bPSluQXn617J1PruOVaVBgJOmaLxPiVg6HEbBJccL6JITxNJR?=
 =?us-ascii?Q?+RTh0xba23bV95NPvQFlWq9c41dLOC/6QtL7SuVf/5vZNFC4V0YmMAJEXv8l?=
 =?us-ascii?Q?usvvzJREvnmuTTtEcUTSTPXJII/K29SmQ6yIaVnNc0ccSy3Ux/6ppQdtBwWU?=
 =?us-ascii?Q?lwaRWjIucI+mg7EBhQP9XewhJFWI8XmqgIwk/GJVaA0mA2Q5R08lGFzHm1G/?=
 =?us-ascii?Q?TtonP062Lotmea2sWj7PNfPp6YpZ86H9ilIcHcLtSv5KuHm6Lb6kxGn4cRwR?=
 =?us-ascii?Q?HUx2FyrGLI1uH8voyfdmwnHxbl6fLCf6iVLYBORdATyX7nVZNWypYGSGHTaq?=
 =?us-ascii?Q?fQfqC6L49zJu8MR5VjmlR2WtDO5l+ArjahNXgC64h34QETEHRx5EJUW/8+43?=
 =?us-ascii?Q?obsrtM3Yq94cj8eBCjIHXU0IcMIXy9NAPhpUJDiwUXp0lL4mUmS8/5KT6vwn?=
 =?us-ascii?Q?+ZC1j/i7+oZGfz+RKLg5H4hSltAV4saaomIJ1Qgu/OM0iRKkKcw5vbQ367vO?=
 =?us-ascii?Q?5LQ4eV8DpUnS9p1YPiTZcwWBD1yJH6KHoLWz11fRNNwizLhc6UXrDOiUpZb4?=
 =?us-ascii?Q?H5NIbAyi2YgO52UyGec1lXbhLDZ5+USOe/9MVGxqym5PsziCvEorxdn3VUhT?=
 =?us-ascii?Q?24Ip2EC3Temx/qR1oXPZwbxMg/slcrXU2YDznQ03lCcIo3pK6zAy0f/VQe5N?=
 =?us-ascii?Q?/SCF18ttFqa5gGHe0g2b/hPYjAlrvhD79ZyVJI+5DZfMNL7BafUKVrN3kxX5?=
 =?us-ascii?Q?Cr10Ibkdn7laCJIkWgl8uZgiYhC9axef8mKjdbATb0gazqdNrfPxgKlavUXB?=
 =?us-ascii?Q?Rzb3n+J2uaGZ/WJloPEJg+01Sv35HclkSUpn0KaYek1T42Het1qoZfYczqkn?=
 =?us-ascii?Q?8MHzMJGI/lUpqZGrM5vJtkG6RnDOpt5O+IjaDc6Kiz+VGwprVQ6+HcxlO0i7?=
 =?us-ascii?Q?X7+kOHrhev/x39+36IT2NWqIAasBIPZcHYEOp8kgtpinaJI1lFCktzNZ7ouI?=
 =?us-ascii?Q?ChxA2/q2qwxQiVBUS6ij4eLM+XGZArF3DJQKu3UZqIBoh21Je/lvV1W1w51Y?=
 =?us-ascii?Q?WfhFMoG3EZfZbXiSibAOpLA7Mtmi8wrmqWt+AMwQPV+sFfQY2eve+b7cb1gd?=
 =?us-ascii?Q?pbVVXgJWjzMaYNeRSdxKZz7nN0VKPNlDbqfjJ0+jlYsKDNiiU4UuA2CSzzo4?=
 =?us-ascii?Q?g3YpS11YN3EQL2VzkxrJdrPRc4xFVIC7ZpyvLXg/ol9RTAz9f2r28QwYPBIr?=
 =?us-ascii?Q?KSNLkjOPzomRwIABWSXCVij/SgiBY1Cv9uYWgv4w?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5615fcfe-9fd6-4a34-2a35-08da6245ee5c
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2022 07:29:32.0159
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e95Y+6uLouLBnq+IMseW3uc2WcA4bRkGU6NKZ6w/XLym1OgYXR/WKpXywUHwMEl4koK7FA6urijkuWmWOp47nA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5184
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 07, 2022 at 05:29:30PM +0200, Hans Schultz wrote:
> +locked_port_mab()
> +{
> +	RET=0
> +	check_locked_port_support || return 0
> +
> +	ping_do $h1 192.0.2.2
> +	check_err $? "MAB: Ping did not work before locking port"
> +
> +	bridge link set dev $swp1 locked on
> +	bridge link set dev $swp1 learning on

I was under the impression that we agreed that learning does not need to
be enabled in the bridge driver

> +
> +	ping_do $h1 192.0.2.2
> +	check_fail $? "MAB: Ping worked on locked port without FDB entry"
> +
> +	bridge fdb show | grep `mac_get $h1` | grep -q "locked"
> +	check_err $? "MAB: No locked fdb entry after ping on locked port"
> +
> +	bridge fdb replace `mac_get $h1` dev $swp1 master static
> +
> +	ping_do $h1 192.0.2.2
> +	check_err $? "MAB: Ping did not work with fdb entry without locked flag"
> +
> +	bridge fdb del `mac_get $h1` dev $swp1 master
> +	bridge link set dev $swp1 learning off
> +	bridge link set dev $swp1 locked off
> +
> +	log_test "Locked port MAB"
> +}
>  trap cleanup EXIT
>  
>  setup_prepare
> -- 
> 2.30.2
>