Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yevhen Orlov <yevhen.orlov@plvision.eu>
To:     netdev@vger.kernel.org
Cc:     Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        Yevhen Orlov <yevhen.orlov@plvision.eu>,
        Taras Chornyi <tchornyi@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
        linux-kernel@vger.kernel.org
Subject: [PATCH net] net: marvell: prestera: fix missed deinit sequence
Date:   Sun, 10 Jul 2022 15:20:21 +0300
Message-Id: <20220710122021.7642-1-yevhen.orlov@plvision.eu>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3M7epefWlI6VXkX7QR4jy61twP/U49pupiIxWhCVPDwJqMqZZMHU/h2usKTE?=
 =?us-ascii?Q?n6wdtB6W/svr1Wm3c5I35+643lLnWdhRt0nhW3jjo/pDvw3yk+q/ph2cL7Xk?=
 =?us-ascii?Q?zugDKT2hYYzIv3KgGCzXLhHWfJusF1DFefgAuI3rvPbUs5aJFIKW4H99ZQaU?=
 =?us-ascii?Q?fWxVdoYzlh0imRk5IJz0YDWlPTuulZDX7EZ7oAhA3nZra4Thww6n8Il6OFqD?=
 =?us-ascii?Q?lHeRX0licHYBlEqv/mxcxstsu20VXI1PYKexCCaM917lNhpGYEv9/WABSqA6?=
 =?us-ascii?Q?S7onRERgf9+XLsQscqA1qA4TNrTTELLPCHRwFCfjXDzXxPe3iHinFzgBB08t?=
 =?us-ascii?Q?Bb1ALAGnCXG2OaswoVtO5GEjB2bJZLWPi6aPnZpOaHMGK/fpMxfgnu0fX6kM?=
 =?us-ascii?Q?S8ra6QDJNhpfnxYdgTAmFqk/RYI8azz1+3U7Cj46KCD5rFLvzWiT3vbIQV13?=
 =?us-ascii?Q?2axc1nVqNeyF+pXFwv242wkhayeh0qIYw8ZUUlMozfYtmAYNO4yy4yF3/vD+?=
 =?us-ascii?Q?c2mWQNB+CKo8kAWPgpYv7vcnPXLk5yaTT7qetC6mi632g87cWL/uho5MK4TQ?=
 =?us-ascii?Q?LysqmNodIBWfZuEveZ2Stcp6pGPELyZybMhHixE25jTfjKIxDXiYzqUq/0lz?=
 =?us-ascii?Q?rHLhP1oubrVWYJunjZngNMoAGRyOOXPNebnNAogR/yQ2iJTrA2M/wU60UFeA?=
 =?us-ascii?Q?YeS4TMD/HphW4zMezT+edeUl/oDm+9pRe7ZxpYMuTdaqBY0cICmltUm6jnwt?=
 =?us-ascii?Q?tHPODIAu2RWkU+AyGnsEwPTA+gTdkmKTsKJBSMiRWKqYdwcNWxa0Bsb40AlA?=
 =?us-ascii?Q?/wk9hL9GoVbQY9C2+QuqJN0KhYuGzwqTK9hoKc4bo2MRBcSC0d1/m8xWr68x?=
 =?us-ascii?Q?RPswz7KnPozNBR72b9T9B1Rw7bQrAS7DhptadXqHN1DCHWsDXaN6JCPqnata?=
 =?us-ascii?Q?MWTIlQrgztPawcHUUdWSIE/Qz7ROAZ1+DN0VSNb+FNq5AulkEd3j+Hq8fr2r?=
 =?us-ascii?Q?SdPwRmn6Nmb8TgDgn1kQz3tQSvzc9Z1JKfrhXt5heNcGD2zjqRGu6TwhTRif?=
 =?us-ascii?Q?8kbJr4VHRNIPI1ZZhcdfX6N6a/qLOKRQ6b4afmv7J8FoSWntEmtQ0Toj86Uu?=
 =?us-ascii?Q?UMJj5LdeohaHjiZ5+QSuBijzzEjy+zRxuHGnxJhlQm5aVKNEKf4kZQhsAgat?=
 =?us-ascii?Q?i0Bw07gtRLSxWEWxH6NDxxZ3HsykvCqSS/rke760Xl2yz7IiEFQMZVA0qhoi?=
 =?us-ascii?Q?hffWNp4mA1onGcpCaKmxAzCoUH3ESw7dwIBhfoTa2VBd7M/3Ne0sh4V/971v?=
 =?us-ascii?Q?oqUZAG6h3fTBB/n0eAw3Z2CdWkugK1Q8STRsgxU+HRRDgPnPNnnfrNdpHVTe?=
 =?us-ascii?Q?Th/BVBfvG8bKA8oSVLPFU27lwsDHqleUGwEaTQTe7tJLwcdkHGlhkZhnjGPr?=
 =?us-ascii?Q?5ML9vVga/gFh+Nk7wu2fnrWUTpW65JfOuEmtJOwHpXa2lmTUSPyLEP4k9Q/U?=
 =?us-ascii?Q?wVWA7RLXK0rVlT6H280cagD9gNkCQzZLRpm43guFfvQ8wSaDwBB4/JQ8vfkx?=
 =?us-ascii?Q?s8QhAH4HVsDb3sVqDDDduQvEUUIOFCiLT1d1KP9r+8QK8EWW7swNvVGzwZ2V?=
 =?us-ascii?Q?hg=3D=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: 56b5e154-7395-4c4d-96fa-08da626e9827
X-MS-Exchange-CrossTenant-AuthSource: PAXP190MB1789.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2022 12:20:36.6720
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SfhyUUjD/81/f6UJ4Of/ipHshT96nbrAwQ7MFgN9c7ywU/niRaDlXfjBwxK+wAHGnKBkChWq3x8c09cpO5xp7779TnMacPXc8ZPQ240qbf4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5P190MB0276
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Add unregister_fib_notifier as rollback of register_fib_notifier.

Fixes: 4394fbcb78cf ("net: marvell: prestera: handle fib notifications")
Signed-off-by: Yevhen Orlov <yevhen.orlov@plvision.eu>
---
 drivers/net/ethernet/marvell/prestera/prestera_router.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_router.c b/drivers/net/ethernet/marvell/prestera/prestera_router.c
index 3754d8aec76d..3c8116f16b4d 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_router.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_router.c
@@ -588,6 +588,7 @@ int prestera_router_init(struct prestera_switch *sw)
 
 void prestera_router_fini(struct prestera_switch *sw)
 {
+	unregister_fib_notifier(&init_net, &sw->router->fib_nb);
 	unregister_inetaddr_notifier(&sw->router->inetaddr_nb);
 	unregister_inetaddr_validator_notifier(&sw->router->inetaddr_valid_nb);
 	rhashtable_destroy(&sw->router->kern_fib_cache_ht);
-- 
2.17.1