Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4483d1fe-417f-4279-3460-dca351ee42e2@intel.com>
Date:   Sun, 10 Jul 2022 09:04:47 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] platform/x86/intel/ifs: Allow non-default names for IFS
 image
Content-Language: en-US
To:     Hans de Goede <hdegoede@redhat.com>,
        Greg KH <gregkh@linuxfoundation.org>
CC:     <markgross@kernel.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <ravi.v.shankar@intel.com>,
        <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>
References: <20220708151938.986530-1-jithu.joseph@intel.com>
 <YshNAh6awfPFmxzU@kroah.com> <33a6193e-1084-ae5f-1f80-232274f71bd0@intel.com>
 <Ysqm1BRbCTtWfAcW@kroah.com>
 <79eae42f-50ca-c23c-9fd0-8c356b2d3783@redhat.com>
 <YsrZwc9P34lICS99@kroah.com>
 <c416b93b-8adc-d9a8-ef0d-594cce6d9a9d@redhat.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <c416b93b-8adc-d9a8-ef0d-594cce6d9a9d@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGtqR1RIVmhSMDdMUjMvSG02elR3bnNldUVRVGZZSUVUMVhNd3lkS1MzdVJB?=
 =?utf-8?B?NFJGUExiVTdUdFgrcW8yYUtsbW9UYWxsYUk2SUUybDN5TGozTDB4VU5OREM5?=
 =?utf-8?B?WDlaVkN0a0E0YmJ4WGE1YVRHSXlHeFgwcmlwbjZIK2tIQWQwYkM1cVJxQWNG?=
 =?utf-8?B?UHJLa0MvRytrTE8xenVZSGxCdkdsUVpadlVocU8wUzdudHVHQXdBVEZENEIw?=
 =?utf-8?B?QVRESGIzbmhuclBBN0dXUnJ2T2QyUzQ3Q2FWcExFeVdYalM3YWc0RE5FcUVQ?=
 =?utf-8?B?cDNYb3J5b3J1RHRwWjJuWFozL3JTSWRVWHoyaURRRnVOK3B2Y3crMEg2eFRD?=
 =?utf-8?B?UjV4dlhhc2srUmdJYzl1bUdiTmMzVE9DSkRGZUljckMyaTd5bm1QQWFpYk11?=
 =?utf-8?B?VEtPQ0pqajlETkxHR05rWE9vSUZoMno5QXd0QW5uNVQ0MUQwNmtlazhpWVdZ?=
 =?utf-8?B?NGpmdU1NbHNyNkE2MkRKY3hOaGNCMXowY2NZK083S1pQSld6T2Q3S0hWVk9k?=
 =?utf-8?B?UUpLNTJoWGMvMllZb2NNRUZFM1JlVENCNHFvNDd4NGNiZGZMZGx0d3gwUHY4?=
 =?utf-8?B?UzRFYUxpNnQyRzVNM0FUMFRnYWV1UzFuZ0FQNFArNXdzUXNTZHQ4TzNFblJH?=
 =?utf-8?B?aEZkWG9pVUZDY1FGR3NXYi92UTZlRWtZSEErSTVhQ0pvaE5kSWdObHhtaEh1?=
 =?utf-8?B?TEZKaEg4cFZUUXRCdFV2bzlzN25vMXJ1M2tvY012ZHpiL0xCSVpvQlBGZEZo?=
 =?utf-8?B?bFJGVWd1NEJLbVZ6QkMzaHBkNGUwVDNka0FXenBnczRVU0dKekJaZ3VuUDgr?=
 =?utf-8?B?V2FJWWFVQVJIVytEK3JWWDk1YVFvRDlMSHE5NFFCWEdtdDg5ZUswWmVBYW1P?=
 =?utf-8?B?MThiaGt3bDZJTXZOVFpOQjFkYkRLdWJLZlkrS3UxMXZNMWcrYW5IQUdIWTVl?=
 =?utf-8?B?a0tzZ21nbUVMenVrT0JNQWtmZ05iTkFVZm9yWVVpeTJjdTFoZkdtRmJTMGpw?=
 =?utf-8?B?MWNpSHp5WFhDdjkwam14VG9lZjdXQ2hqWWR2bkVaS3FxWU5NdWtNbWxkUTBM?=
 =?utf-8?B?MGlISjAyblZMMWcrSjRKRE5keXZkN2JwMmJ3TG1uK0FuN3RRU2I3YmU2MHg0?=
 =?utf-8?B?MmdnRVFBTVFwZmVFdWFObUpoRnExblFJdDhJRXhDaFdPVXQxMXhoaFNmMkhq?=
 =?utf-8?B?R1VyVm1WelpJaFRGcURjRGxWKzkzclYxa3V1L2V1d3lMY0Z0NmIwVUd3aVEr?=
 =?utf-8?B?R2tKKzR5MGJ2R3NSckNkZUhYc3lzYkRFa2JNeE9rcm52NHNQQWdGN21CR3Bx?=
 =?utf-8?B?Z1VBT21nS0ZrWUY5citrNldsZnByMHZkMXl0enJja1g0aWpXRzNmcllXNnFJ?=
 =?utf-8?B?QjVXZENFVzAwWG9rUC9LMThTcWY2WnkvVThhNGdINlgwVktFME8wSFFzelk3?=
 =?utf-8?B?Ny9SODRUdW5kSHQ4bzRSejJzQ3RNQ0tEeUlxbmRTZWZWSW8vMWk5T0ZmSGtH?=
 =?utf-8?B?bEVtSWovMzVkRlJHcU4xOWNtOWpZZCthMnFKTDE3dVh1ODFwNUhHQm5FaUxF?=
 =?utf-8?B?KzIvRHZyL1BXWE9meEhMMi9SSHpBQTJRcEZ3WE91L1ZqYmM0cWJadU42UkI5?=
 =?utf-8?B?QmFNaXRDcWJTNzN0UDg0K25jNUZ2dHVSWVZkZWRuNm1JeFhySzNFV1Iwckwy?=
 =?utf-8?B?RVp2dG0zZi9XcVl6UkErb3RGdGMyRzg2NVFieUkxeUZWWklVcW9ZakFQUEpp?=
 =?utf-8?B?Vnl2ajIzVmU3TXlZYW1ReDg1WDRrbklGdnJJc1M2dzg4aUJrREhzVEl1YzN4?=
 =?utf-8?B?T3lET3NZSnhpV3pOZXc0bDNMeXlFS3kwaGVxRi91aSsrWnJkc1ozd2pXam55?=
 =?utf-8?B?ZDZkc2kwcVk3UlYzUWRGM2RpaGp2cTNjOXExaUxzNXVEV1Awc0IxRHJ4eHlv?=
 =?utf-8?B?Q0VzMG41dHpWZTByQmd6cE0wamtOMkwxWGxJVkg2N1pFcFpleTlhVmR4cFNy?=
 =?utf-8?B?TVBhRXdmaldUL2RCalNVbmI2dGEvaWFzbXhkQzlWbmxRU3N1QTluYi9idzBR?=
 =?utf-8?B?aVluZFdPZ0Y5amc2aHY3eUdzYmVKano2STdUV2RGSDd0VVFxd1dvRFZGcFJV?=
 =?utf-8?Q?BwND4skr7R945lXWTDD4oyQom?=
X-MS-Exchange-CrossTenant-Network-Message-Id: de9fe211-651f-41cc-5240-08da628deb1e
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2022 16:04:50.2452
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7w9ETpY9g+w36lsgQxIxpw3EZc7zscOmc6jM9ltcw9xwMiq12NyUyoOtlQUjKfPQEeU6BnDazq8JqQsia/Y5wA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1945
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/10/2022 7:08 AM, Hans de Goede wrote:
> Hi Greg,
> 
> On 7/10/22 15:53, Greg KH wrote:
>> On Sun, Jul 10, 2022 at 03:42:29PM +0200, Hans de Goede wrote:
>>> Hi,
>>>
>>> On 7/10/22 12:15, Greg KH wrote:
>>>> On Fri, Jul 08, 2022 at 11:34:40AM -0700, Joseph, Jithu wrote:
>>>>>
>>>>>
>>>>> On 7/8/2022 8:28 AM, Greg KH wrote:
>>>>>> On Fri, Jul 08, 2022 at 08:19:38AM -0700, Jithu Joseph wrote:
>>>>>>> Existing implementation limits IFS image to be loaded only from

>>>>
>>>> Ick, you are overloading an existing sysfs file to do different things
>>>> based on random stuff.  This is a brand-new api that you are already
>>>> messing with in crazy ways.  Why not just revert the whole thing and
>>>> start over as obviously this was not tested well with real devices.
>>>>
>>>> And what is wrong with a firmware file called '1'?  :)
>>>
>>> Actually the Intel IFS stuff has landed in 5.19-rc# so it is
>>> a bit late(ish) for dropping it now.
>>
>> We can mark it BROKEN right now before -final happens as it seems that
>> the api in 5.19-rc is not correct for its users.
>>
>> Perhaps we should do that now to give people the chance to get it right?
> 
> That is a good idea. I've just send out a patch doing that.
> 
> I plan to submit one last pdx86 fixes pull-req to Linus once rc6 is out
> (prepping it now and want to give the builders some time to build test it).
> 
> I'll include this in this fixes pull-req.
> 

I did send a v2 just now, which removes treating 1 specially. Not sure
if it is too late, but just wanted to give it a shot


Jithu