Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <63640c73-1ff2-08a1-0a92-cc330b2d4f35@intel.com>
Date:   Sun, 10 Jul 2022 09:43:24 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v2] platform/x86/intel/ifs: Allow non-default names for
 IFS image
Content-Language: en-US
To:     Hans de Goede <hdegoede@redhat.com>, <markgross@kernel.org>
CC:     <ashok.raj@intel.com>, <tony.luck@intel.com>,
        <gregkh@linuxfoundation.org>, <ravi.v.shankar@intel.com>,
        <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>
References: <20220710160011.995800-1-jithu.joseph@intel.com>
 <535ccbeb-b6e5-b7ef-47b4-894af24c00b0@redhat.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <535ccbeb-b6e5-b7ef-47b4-894af24c00b0@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WFE5SFk4S1lBeVRyY2ZsMHZDT2ZQODQvREFNdjBJZS9UcEtUS3cveVRtOElE?=
 =?utf-8?B?OVJpYjlsSkRCcGU5UWVJY0g2bTNnK1JrR1ZzZlhUTUF0aXlBMVNsaWRPLytp?=
 =?utf-8?B?dnNDU2lCV1IrYWFFdy9rODRPMHg5emMxSHZnK3FYNWdGTU1kK0xrODR6UE5Q?=
 =?utf-8?B?OWlLd0ZpLzczczREVWhaRkRERDFWdFV3UHpGa09jWk84b2gwUldYL01uWHRr?=
 =?utf-8?B?Z0x0Um1iMlp1VWVYUE5YN043bC9aMXJKekVHSE85OGdoQ3k5cXNtVU9XNC8y?=
 =?utf-8?B?ektodnBjbnV0MEhLSDRhck1ESituVUt3NHpWQWYvdFJDWjRGZTF5MUU2ZDJr?=
 =?utf-8?B?eDZzN25hMDNucloxc1d6QnNPVFhZT3ZVQW83RnhRcGhGUnRoclZuZnpkT0F6?=
 =?utf-8?B?M0tlUFFNRTVsQldUb3FaQ0hSV2thd1pmeTFrRDZnemExajFaZ3dWK0d2eXNQ?=
 =?utf-8?B?UlVUVkwzdzRMenB2Nno1QkR5VWdOZmJ0dGlKelQyeUEwbEFueHpFcUg4RzY5?=
 =?utf-8?B?U2RzRitROUgzOC9FcjFPRDdyeExnZDRQQkdiRkNnK0l5ZkZDQVd4V3hQVGZm?=
 =?utf-8?B?NS9BT1pZZEw1b2ordGp4ZUR3NWc4ZDhHVUkwT3JnTy9Vb3BtSStWa2hKMkZK?=
 =?utf-8?B?Y0VwOFArS0xJUU1JWlF0WnJNcE5JYWJqcGk4cFArWGRqblMrN1UwaVQ1c25L?=
 =?utf-8?B?anoyUXZiODVBUnNSY0laR1A2S3lCTHpyNFMyUFFRSE1UTk94YUpTaHo0bW90?=
 =?utf-8?B?MExtbWE2WVNCejJIUmZUMmlhTEd3TlIwWnZ0dmI1bnArNUw3c0JJTXNVa0RO?=
 =?utf-8?B?S0VPVGxETWIrYkJiQVFad0JTNWxQNTBsdHFVa1JWTHljT1crRG1PODdmUytW?=
 =?utf-8?B?NGhROW8xMHlCSWJwcmNZdStQR2w2MHJ1Y0xYRXVScFVFa3BSL0xQNms2dDB2?=
 =?utf-8?B?RCtjbDF5MjhnLzlWMWo3WVFzN254RTY5SDhrdUUvYUxXeXp2V2x1cUU3K1lh?=
 =?utf-8?B?a2lmTUJxbllzakdXdmZqdzJhVnB1YVFYWUtUSjkrQitlODJod2JNZ3ZxVjZR?=
 =?utf-8?B?SkU2TWVJL3ZtQmN5S3FqRUVsSmdqWDM0NVBQVE9qejJnTGlYZG5DWmhrYVh3?=
 =?utf-8?B?eVdINlA2SXArai9rZ1JWdkhFVlc0Z2NwYXlkdjBmLzFCMExHcW9Va3J6VnlT?=
 =?utf-8?B?czloMWo4eVNVMEt3ZkllNnV6MkErWnhYN2lZUWRDN0kxejc5K1NKbTZld2lT?=
 =?utf-8?B?ckVlQTk0U1hWMlhNUFc2MmxZVEU2UkFlQjJwTzd1U3NIdVE2UGJ0aWR6VGhM?=
 =?utf-8?B?TVFpQkZMSVBaMVd1Q2hGVFVoMElGaDZmOXB1WkswQlV0TzFXam5PNHRQcS95?=
 =?utf-8?B?VTBTdkVKRUx5NmlnNXoweXlDOHlKbzBzWjlJMDNrUlZ1LzF4U0VkdlhoWm1u?=
 =?utf-8?B?RTNJNUcxUlRRV0NORUV3TTVMOUUzK3dTVm1lbEtpU3NmQmNsQWNrWFg1T2Rq?=
 =?utf-8?B?cmhrUzRWZG9td3ZJS1Yzc1RwWFRreHdWRWw0NWJNZGFLMFhoamIyZHVXb0ZS?=
 =?utf-8?B?Z2dsTVZ5dkg4NXVZclhTcmhoMzRnT3l3YzM4U1VhQUt2dDUwY09JZlZ4Q3Zm?=
 =?utf-8?B?dC9LVTdhZnZiMzc5c2hscUVRMG1EUmh6dS9XelFhakwwUitMUGRHcHRBZHFi?=
 =?utf-8?B?Nkhmb1VDQytmOEpQZjk0SUYxSndqdUJ0ZVNRZjdrTW9ZdTg5dzNLWlRRVk9i?=
 =?utf-8?B?NFdoL1V6bCttdzl6cEwrNEo3dmtJSzhnUXppWUx5YzN5Yit2dkdhRUVaVlFx?=
 =?utf-8?B?UVF4eHZ5U0VxRzcxU25iaWNaOHZNU2MzNFUrRkJoeWtQWWw3NXY4WE1XQTJy?=
 =?utf-8?B?YkNSMmZ6ekoxZ2VSdlRDSXcrSnRYdHpWbnBCZVp0Y3djemI0YVI5czJ5Q0Z4?=
 =?utf-8?B?YnBwZFVvcjZmMTN2dWx0M2xyQ0NDT3ZjcFp2a3ZPUTRxTU1CVXVqZ2lseDE0?=
 =?utf-8?B?aVlCR0lvdWNDZTFWaFVZTUV1QW5jTlZHTUhwTkltZkQzNWVSc3lLMC9DTGov?=
 =?utf-8?B?enoxYXFPTEQ0ZzRyMVByOHlDV1VaT29QS0tLclJuZk5DOVZYN2JpRE5GWjVj?=
 =?utf-8?B?eVo3RlE3MHZiTXoxRjBaTGVKb3JrSXplTTRycmZYcThWa29OOTRBd3Q1Y3J5?=
 =?utf-8?B?Q0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 52fde8cd-f8b6-4806-a9c1-08da62935069
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2022 16:43:27.6569
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pKqyvtOAuO2K3Gq6556IXehedajHNzmkQrOFEspdOimaeDqhKyYQhHaHmqCjqtSoeVhlVDsKZhpewmZih2a3Xg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2242
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/10/2022 9:12 AM, Hans de Goede wrote:
> Hi,
> 
> On 7/10/22 18:00, Jithu Joseph wrote:
>> Existing implementation limits IFS images to be loaded only from
>> a default file-name /lib/firmware/intel/ifs/ff-mm-ss.scan.
>>
>> But there are situations where there may be multiple scan files
>> that can be run on a particular system stored in /lib/firmware/intel/ifs
>>
>> E.g.
>> 1. Because test contents are larger than the memory reserved for IFS by BIOS
>> 2. To provide increased test coverage
>> 3. Custom test files to debug certain specific issues in the field
>>
>> Renaming each of these to ff-mm-ss.scan and then loading might be
>> possible in some environments. But on systems where /lib is read-only
>> this is not a practical solution.
>>
>> Modify the semantics of the driver file
>> /sys/devices/virtual/misc/intel_ifs_0/reload such that,
>> it interprets the input as the filename to be loaded.
> 
> Much better, but I do wonder about the behavior of still loading
> the default filename at module-init?   If there can be multiple
> different "test-patterns" then does it not make more sense to
> let the user always load the desired pattern before testing first?

The default image provides bulk of the test coverage and the additional ones
provide marginal additional test coverage. That is why, we still kept
loading it by default

> 
> Not doing the initial load at module-load time will also speed-up
> the module initialization and thus booting the system. Especially
> on many-core servers this might make a measurable difference
> in module-init time.

Thanks for these inputs Hans, I do see your concern. Let me take these
concerns to internal folks, before I get back on this.

Jithu