Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alan Maguire <alan.maguire@oracle.com>
To:     ast@kernel.org, andrii@kernel.org, daniel@iogearbox.net
Cc:     kafai@fb.com, songliubraving@fb.com, haoluo@google.com, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org, jolsa@kernel.org,
        mhiramat@kernel.org, akpm@linux-foundation.org, void@manifault.com,
        swboyd@chromium.org, ndesaulniers@google.com,
        9erthalion6@gmail.com, kennyyu@fb.com, geliang.tang@suse.com,
        kuniyu@amazon.co.jp, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v5 bpf-next 0/2] bpf: add a ksym BPF iterator
Date:   Sun, 10 Jul 2022 23:09:56 +0100
Message-Id: <1657490998-31468-1-git-send-email-alan.maguire@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?o6MC6D1bQCRczaYeJgag3lan+pr4dLuCcrymgKac9OoePRdT83W8o0hO4qqK?=
 =?us-ascii?Q?lBlawvda2JQNHvk3FKTNcEgmVTQcy0O6NNxBMvJiqsPzj43ZxdjaCx94CTh7?=
 =?us-ascii?Q?QUGMSHldlTVadq4/dCCOdwnycARJobkDaKWmhTTZ4YSma/oiB837PkHiClfX?=
 =?us-ascii?Q?Mrdq0Cw+OEusHvDVeST0a/LnBgUU5CnvgWoNPC+8+iqDHFsQEK+WAzkrRgFa?=
 =?us-ascii?Q?OuvqcClthyu8jydm4XtBFPkgVfb4v/jzuBy6Eu7WhH2E7rKNhQjcb4yhlSNS?=
 =?us-ascii?Q?5ZsYN7jTbk2pUgxsA71vYiiMtR6UcQuFNJ26gnR1EVfzU+uqIt3ekNO74Tp7?=
 =?us-ascii?Q?zclqtLvubUSjXGayInHZvId9gKrENME4iusNV2MH/TwqglF77ZNhMmb40Hi+?=
 =?us-ascii?Q?bEfWkSfjsh89n42GwkiXx/3jh3G2c3YXx9vX8f1p70K+Vi77jHBQRvhzI/eV?=
 =?us-ascii?Q?IJ9HD+S11TzcSAeYASh8gZb1gC2/Gbr2R7PaowpnhF6wxHMdgIdLTbsFGVXX?=
 =?us-ascii?Q?DNAC0bWfsfuf5YxCfALXZ72QW9BaL4TZgCS4GMcbSRwL4QcUoTSgbWYw6g9m?=
 =?us-ascii?Q?wBME0hUfNvjQwffc/3idCu3s86wpOIi2cVMX6+xyPo3tyRZe52INxBnwQFbE?=
 =?us-ascii?Q?JSJ/F45y6OoOfdrCLpoB8hh0Uc1KH8BoTYGlG5p6bFeet802NLCKENRcVV7I?=
 =?us-ascii?Q?O0j1vHn0DhAZPLYeg5v5/WKvPy8u50x5KWqS/TzCiGHqrhFNZbw0TPvncr3w?=
 =?us-ascii?Q?sxghvH0YvEQcD1vITrAbzQmIFewnkyJ2XdIBJM5HMei3myueXnYLzpDya0fC?=
 =?us-ascii?Q?QwLCSl1x/JwjCdzDwI4LtBWsrUpEu+uneOKLAG97oMZxXNC6cjH7qhNvA4FO?=
 =?us-ascii?Q?llUWZxLrun+24wD56KjqLk28BE9FQwUHgiWsqGCn0R8/M2eo9Rk/KXQqLh5E?=
 =?us-ascii?Q?Yp+omPPDEG7Y3ubYe/CxM1pPAbAM8+VBplfilOvpC1mNQU+FZ4LVHrUj6G2f?=
 =?us-ascii?Q?fTMiDEEUdd18mawuq2qx8EvRSRqf9KZsZd07EBSOUm/9tbg42JmC9JkPjleY?=
 =?us-ascii?Q?b5G47WnkRZ4/BbI7Os8COpfCELAOvR0PMjyQ+Sp37sGMGHYjqSwJSE8aXhhV?=
 =?us-ascii?Q?P8xxaWkVVyETzTZ/6T51tfxxtp2X9Ibnr7Tjs0JyRDUyvk1JnXlgbtw1Q1Zm?=
 =?us-ascii?Q?fhSx1s8TrPpfH7FZDlk9cc501+BqwV97GtWO0AdlfT19zf/yScWYrHM9lQOU?=
 =?us-ascii?Q?qtaJMeO9/fFSwSdGlE/X1q0jzDdrrwPAmGzEe3tJfvP4F9PgPZfWVF4P7L0E?=
 =?us-ascii?Q?nA9r1XMSM1RyTHA7nLHScahonEZG2NOVis1fIPlcwOBhB8jZswNs2pnqaB0t?=
 =?us-ascii?Q?0lU86ITLCyCEUdI5SMwtlevRzRbALDloDHxB3Z2Sci7/yO8b13sjj+DnNirs?=
 =?us-ascii?Q?X8WadmDGLBQAKh8YziXGhWxQw7R+aDJxIIm3UqaXwJ6l1Jhivq3QC520gOgq?=
 =?us-ascii?Q?fJUbzAtb5ox9sE8lJGiMiuRTGXhHtuoERBkrO4TS/Jiw+k1pCELjKL8dVAkC?=
 =?us-ascii?Q?srt2mA0SoBGJm0eeg2Jjgc6jukVHgxCZmKngGvGW?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07cfaa31-2f66-4484-3562-08da62c0f06d
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5267.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2022 22:10:03.5777
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OV4y4nNa2Mt5oCLlzjkfJNn3AmH2lb5gyqw7T/pkQmJM+cRwNDAKd3Rl6FfT5U/15lcHpN4zCd5jXdZ1Iu2tWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5207
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-10_18:2022-07-08,2022-07-10 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 mlxlogscore=754 suspectscore=0 adultscore=0 mlxscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207100102
X-Proofpoint-GUID: gpCWj-_3v4dtSeVfUXU4Xv_Xok8etHrH
X-Proofpoint-ORIG-GUID: gpCWj-_3v4dtSeVfUXU4Xv_Xok8etHrH
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

a ksym BPF iterator would be useful as it would allow more flexible
interactions with kernel symbols than are currently supported; it could
for example create more efficient map representations for lookup,
speed up symbol resolution etc.

The idea was initially discussed here [1].

Changes since v4 [2]:

- add BPF_ITER_RESCHED to improve responsiveness (Hao, patch 1)
- remove pr_warn to be consistent with other iterators (Andrii, patch 1)
- add definitions to bpf_iter.h to ensure iter tests build on older
  kernels (Andrii, patch 2)

Changes since v3 [3]:

- use late_initcall() to register iter; means we are both consistent
  with other iters and can encapsulate all iter-specific code in
  kallsyms.c in CONFIG_BPF_SYSCALL (Alexei, Yonghong, patch 1).

Changes since v2 [4]:

- set iter->show_value on initialization based on current creds
  and use it in selftest to determine if we show values
  (Yonghong, patches 1/2)
- inline iter registration into kallsyms_init (Yonghong, patch 1)

Changes since RFC [5]:

- change name of iterator (and associated structures/fields) to "ksym"
  (Andrii, patches 1, 2)
- remove dependency on CONFIG_PROC_FS; it was used for other BPF
  iterators, and I assumed it was needed because of seq ops but I
  don't think it is required on digging futher (Andrii, patch 1)

[1] https://lore.kernel.org/all/YjRPZj6Z8vuLeEZo@krava/
[2] https://lore.kernel.org/bpf/1657113391-5624-1-git-send-email-alan.maguire@oracle.com/
[3] https://lore.kernel.org/bpf/1656942916-13491-1-git-send-email-alan.maguire@oracle.com
[4] https://lore.kernel.org/bpf/1656667620-18718-1-git-send-email-alan.maguire@oracle.com/
[5] https://lore.kernel.org/all/1656089118-577-1-git-send-email-alan.maguire@oracle.com/

Alan Maguire (2):
  bpf: add a ksym BPF iterator
  selftests/bpf: add a ksym iter subtest

 kernel/kallsyms.c                                 | 91 +++++++++++++++++++++++
 tools/testing/selftests/bpf/prog_tests/bpf_iter.c | 16 ++++
 tools/testing/selftests/bpf/progs/bpf_iter.h      | 32 ++++++++
 tools/testing/selftests/bpf/progs/bpf_iter_ksym.c | 74 ++++++++++++++++++
 4 files changed, 213 insertions(+)
 create mode 100644 tools/testing/selftests/bpf/progs/bpf_iter_ksym.c

-- 
1.8.3.1