Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alan Maguire <alan.maguire@oracle.com>
To:     ast@kernel.org, andrii@kernel.org, daniel@iogearbox.net
Cc:     kafai@fb.com, songliubraving@fb.com, haoluo@google.com, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org, jolsa@kernel.org,
        mhiramat@kernel.org, akpm@linux-foundation.org, void@manifault.com,
        swboyd@chromium.org, ndesaulniers@google.com,
        9erthalion6@gmail.com, kennyyu@fb.com, geliang.tang@suse.com,
        kuniyu@amazon.co.jp, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v5 bpf-next 1/2] bpf: add a ksym BPF iterator
Date:   Sun, 10 Jul 2022 23:09:57 +0100
Message-Id: <1657490998-31468-2-git-send-email-alan.maguire@oracle.com>
In-Reply-To: <1657490998-31468-1-git-send-email-alan.maguire@oracle.com>
References: <1657490998-31468-1-git-send-email-alan.maguire@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7OYGa0QSyQIM9lzeY9OWlFc3vCo93d6ZIsV7E4a2nu8zDoZnsUCjWQiTBq5g?=
 =?us-ascii?Q?UGOYRgC68XHhxrulOPbM9zmMga80jI5oVBb25qUxyVyvvOW4l8BegrB3caQa?=
 =?us-ascii?Q?wluwSClUGiH0VbQmbDoWNZGJYT5+7AKTZq2KTyqb/mS64/8a3LxTsfooKCbX?=
 =?us-ascii?Q?SPPKmcOxFiLFU9PpiFK0dnlUBzo40gGGBO3Giit1e9elH+whycrdDRGCcBQP?=
 =?us-ascii?Q?0Akw61ICvOCdD5ZdES/GIWYBUG+QHNmlySYL8oF3AKdECZNNeG7il+zW6rcM?=
 =?us-ascii?Q?M+d9JuqPfAvOqwDHibCAnfd4FVp2i8lpLA/CWVWNAsZMHE4NQPH+VTt9rVf1?=
 =?us-ascii?Q?AkIrqzGAhcstwnisSAKlNZEOUmqPxhNgN8odSHr0GuuJBphNU0ZjpSsLf5vv?=
 =?us-ascii?Q?hfV++GinN7Y26F479yd9irI9xC8cFjSBFA0SxXghxKIplTDZ2oZCdoR32T+W?=
 =?us-ascii?Q?1/Ctfw9qADwEVBZSaFuushoIJjDtakG/2dSAMPfT21loYogmyMmoQYaX52mR?=
 =?us-ascii?Q?KdBgyilwFODTf/HiSiF2V4VIBf0W2cOmB5+jr61J61/O/Gg0imvRmKBWl5be?=
 =?us-ascii?Q?79I51siIN9ifi1PbyEEXouL+1RMU+eVdwCrddTentlwuZYeDdeRdvZ2JjICi?=
 =?us-ascii?Q?Ezes3MoJI9x/1+kx5ouQatKxrwb87qWViphsWJzdAxHMAdEuvIC1exO/vn9p?=
 =?us-ascii?Q?HutjBNgkS+MX+ycGJRzrLF/mXR7qMGoKAfO82xn3J1CYmHOAFZqIj6cSWj2E?=
 =?us-ascii?Q?D7dzoheIg7K0OkETEhlwurByIJk+DwGDdTKNwiNVxM4GJjel3HGV055IOdhR?=
 =?us-ascii?Q?dzOXEki2fOsWrD+xC5ngvKfJBl1UvfklqsNMAuNo/eMDlf599I3F2zdZpTx2?=
 =?us-ascii?Q?aPkDxtpZPk6Mz1A1rZlcOmnzKH7e0cKTKwGzh6cqHgAR0V13orJMuziGCZJx?=
 =?us-ascii?Q?rM7JTSkxN7rbBLtCdUtlwFKIp7lmXTP8RT4B0CvV7sydDBeVIyi/xDpTTHvI?=
 =?us-ascii?Q?OCqp9b+GU5nYm3nC8nfnaGe++05teoCHxtHHUhRtmf38zaMx8jsnn0moSM4P?=
 =?us-ascii?Q?kjwN0HBnwnrq5D+dleHm62ohlI+3e/WWlRTUKwulipW9Y4ftHIj0sK5wLQw2?=
 =?us-ascii?Q?6iMueRvCeZeAh1GlcB7Jsh7nvtgXgta4yV+XMl9vadzwLtdYAMrByp9ObYHs?=
 =?us-ascii?Q?Hm83g8sSASIY6iX9jlQkuEia5KR6NHY+s1kKIHd88NX4VZnQPmPKvsNwGqE1?=
 =?us-ascii?Q?sK5+M8eomju92Xx643bdtTREGfg4nlPTtomv7KXz2Ijfu/v7HajAKzW/p4Cy?=
 =?us-ascii?Q?LuqL6/gpTzaiW/me8ns4rOUJcZiTz4Hxu4jySun0OpLtbJzCAB8JVoPSOmdJ?=
 =?us-ascii?Q?6KpUt1Zu0ByVAcHUcPvbCfadxDGpQzgNZ/ucD+8PKiH3knJyb0yqMtsPg1NO?=
 =?us-ascii?Q?gv3Gi7UTWCclzuKUYGZu3ElK/Yx4NkO21rpon+R3W3Nt06XpBBsLaTWIeUiq?=
 =?us-ascii?Q?RHeS1tt2Zi1rkbWtgtxKFASzpO1Y38OFsQgwIVGesZtMKpe0gQqQgDap21eP?=
 =?us-ascii?Q?CZP2Z4dpmOPGZL7NIu13HnygHBd4b7a+o3P1B/yW?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df608e25-9c49-45a1-8d20-08da62c0f1d5
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5267.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2022 22:10:05.9406
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1ek246sBb6dFJzKZQcKcYmr/+5w23vGKV6jtKXlvfS3eLLULI+8Gfo9QuANuUHa5xXnJXBc6rCYhF/4vJc/mXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5207
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-10_18:2022-07-08,2022-07-10 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 mlxscore=0
 suspectscore=0 adultscore=0 spamscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207100102
X-Proofpoint-GUID: -2w1wpQCYnHeZniZeZKsXxCSis1u3mD-
X-Proofpoint-ORIG-GUID: -2w1wpQCYnHeZniZeZKsXxCSis1u3mD-
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

add a "ksym" iterator which provides access to a "struct kallsym_iter"
for each symbol.  Intent is to support more flexible symbol parsing
as discussed in [1].

[1] https://lore.kernel.org/all/YjRPZj6Z8vuLeEZo@krava/

Suggested-by: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
Acked-by: Yonghong Song <yhs@fb.com>
---
 kernel/kallsyms.c | 91 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 91 insertions(+)

diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c
index fbdf8d3..79a8583 100644
--- a/kernel/kallsyms.c
+++ b/kernel/kallsyms.c
@@ -30,6 +30,7 @@
 #include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/bsearch.h>
+#include <linux/btf_ids.h>
 
 /*
  * These will be re-linked against their real values
@@ -799,6 +800,96 @@ static int s_show(struct seq_file *m, void *p)
 	.show = s_show
 };
 
+#ifdef CONFIG_BPF_SYSCALL
+
+struct bpf_iter__ksym {
+	__bpf_md_ptr(struct bpf_iter_meta *, meta);
+	__bpf_md_ptr(struct kallsym_iter *, ksym);
+};
+
+static int ksym_prog_seq_show(struct seq_file *m, bool in_stop)
+{
+	struct bpf_iter__ksym ctx;
+	struct bpf_iter_meta meta;
+	struct bpf_prog *prog;
+
+	meta.seq = m;
+	prog = bpf_iter_get_info(&meta, in_stop);
+	if (!prog)
+		return 0;
+
+	ctx.meta = &meta;
+	ctx.ksym = m ? m->private : NULL;
+	return bpf_iter_run_prog(prog, &ctx);
+}
+
+static int bpf_iter_ksym_seq_show(struct seq_file *m, void *p)
+{
+	return ksym_prog_seq_show(m, false);
+}
+
+static void bpf_iter_ksym_seq_stop(struct seq_file *m, void *p)
+{
+	if (!p)
+		(void) ksym_prog_seq_show(m, true);
+	else
+		s_stop(m, p);
+}
+
+static const struct seq_operations bpf_iter_ksym_ops = {
+	.start = s_start,
+	.next = s_next,
+	.stop = bpf_iter_ksym_seq_stop,
+	.show = bpf_iter_ksym_seq_show,
+};
+
+static int bpf_iter_ksym_init(void *priv_data, struct bpf_iter_aux_info *aux)
+{
+	struct kallsym_iter *iter = priv_data;
+
+	reset_iter(iter, 0);
+
+	/* cache here as in kallsyms_open() case; use current process
+	 * credentials to tell BPF iterators if values should be shown.
+	 */
+	iter->show_value = kallsyms_show_value(current_cred());
+
+	return 0;
+}
+
+DEFINE_BPF_ITER_FUNC(ksym, struct bpf_iter_meta *meta, struct kallsym_iter *ksym)
+
+static const struct bpf_iter_seq_info ksym_iter_seq_info = {
+	.seq_ops		= &bpf_iter_ksym_ops,
+	.init_seq_private	= bpf_iter_ksym_init,
+	.fini_seq_private	= NULL,
+	.seq_priv_size		= sizeof(struct kallsym_iter),
+};
+
+static struct bpf_iter_reg ksym_iter_reg_info = {
+	.target                 = "ksym",
+	.feature		= BPF_ITER_RESCHED,
+	.ctx_arg_info_size	= 1,
+	.ctx_arg_info		= {
+		{ offsetof(struct bpf_iter__ksym, ksym),
+		  PTR_TO_BTF_ID_OR_NULL },
+	},
+	.seq_info		= &ksym_iter_seq_info,
+};
+
+BTF_ID_LIST(btf_ksym_iter_id)
+BTF_ID(struct, kallsym_iter)
+
+static int __init bpf_ksym_iter_register(void)
+{
+	ksym_iter_reg_info.ctx_arg_info[0].btf_id = *btf_ksym_iter_id;
+	return bpf_iter_reg_target(&ksym_iter_reg_info);
+}
+
+late_initcall(bpf_ksym_iter_register);
+
+#endif /* CONFIG_BPF_SYSCALL */
+
 static inline int kallsyms_for_perf(void)
 {
 #ifdef CONFIG_PERF_EVENTS
-- 
1.8.3.1