Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alan Maguire <alan.maguire@oracle.com>
To:     ast@kernel.org, andrii@kernel.org, daniel@iogearbox.net
Cc:     kafai@fb.com, songliubraving@fb.com, haoluo@google.com, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org, jolsa@kernel.org,
        mhiramat@kernel.org, akpm@linux-foundation.org, void@manifault.com,
        swboyd@chromium.org, ndesaulniers@google.com,
        9erthalion6@gmail.com, kennyyu@fb.com, geliang.tang@suse.com,
        kuniyu@amazon.co.jp, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v5 bpf-next 2/2] selftests/bpf: add a ksym iter subtest
Date:   Sun, 10 Jul 2022 23:09:58 +0100
Message-Id: <1657490998-31468-3-git-send-email-alan.maguire@oracle.com>
In-Reply-To: <1657490998-31468-1-git-send-email-alan.maguire@oracle.com>
References: <1657490998-31468-1-git-send-email-alan.maguire@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TAwnXJBrtqh0mzDnaWh5b8TyBdBfdh0slzckPFqs09rg6XAgTCPjnlfBEgLu?=
 =?us-ascii?Q?bgmXaGe3We7yMWQVBacx4jrV21Y0Nak//SRzScOTI7wZvmOpY5vN55DvIw7i?=
 =?us-ascii?Q?MM2F1bKspfGTuNP22oq4RY2M6uLjkegHz6lCvIrfOHbXwPAZpZIMEWtSA5ml?=
 =?us-ascii?Q?cZJ5T1KZ0d8A58rWsF3JtVTxufdjE4l4cUvKool4YQWR4OHVosxWAIf+c0th?=
 =?us-ascii?Q?V/UBaa6MezikuIItDAow9TRspua0Hk+fKR3jqVFjLD+v1/1HBf1CS22eV8ge?=
 =?us-ascii?Q?ymZN11WGmyQKBRmAOZ1oS0gpwcjWGo8m9IC5sn05GgS9mpzfrY+p13/hJCf4?=
 =?us-ascii?Q?2jx5IAs9A8PHZ7xk6Ts+sH7lPGQpf65Zz8okiuGX24Gaj+XX0haVUcPv4wB7?=
 =?us-ascii?Q?4SgSDaAxuUw7cWnWj3KIpDtTeM4+ePfhGkE9vb9w8z8On1uKw5IFhsBzqIUG?=
 =?us-ascii?Q?Wy9XLnjYcqeR2kbz4yCGszMfarTm+af2zlsREQ7rXx/y8m/QRJaACMQYIezf?=
 =?us-ascii?Q?Ym5Hxn1A2Dyzjfigkb1lZmUwJ6wvV+kyIlwRIs7HVukVoObjxaIy038wGXTY?=
 =?us-ascii?Q?5dd5jk9/Nw9/LODchBY8oMPMjLDg+yct3udLLqCCcc2EwGDcIl7plV6ALk52?=
 =?us-ascii?Q?kJzcAzefFpEKRAXwNFJsbTyumvPXeKETO62jLuoskzJdl+5j6iVWnUTJtOqS?=
 =?us-ascii?Q?FVturpVtdbT/+4Nm6bjSrLDeBHfhbXfeEiGDaQTmmU5sis/naqrRQkvQAkct?=
 =?us-ascii?Q?kH1oV8ge+2kwx+5PcVUdQ5MfDJzYXYEZoYu1fpNUqVDr5+uyZ++bQzZJaMlq?=
 =?us-ascii?Q?xeUeX0gIyWqMmn5Dvumqotp9fxZqiR13GTxvGAeWHgzC5EDBjjNiDZ+/KouO?=
 =?us-ascii?Q?aJuunUVbbSzZrNwQHo95w227MF0BuvhthWrr7wEg+SMzs7YSH2efxrCZY2gu?=
 =?us-ascii?Q?U09iFIP6cxQ+Wy7x4qM6wxIyMkud3fNTG2S+5WR/I8ELT/ErsHb85IcTIkjV?=
 =?us-ascii?Q?f8ImvCjCNTwWMchNjp1+//bItysJlJTFsXmfGCy+qJh8ck7XNVAKVdqBTPOr?=
 =?us-ascii?Q?fhoHao/hIZyCcsnTSabKtAP1b7TmzeWlCzgnR6AZ/YM5BzhS64V8HbrRtUxR?=
 =?us-ascii?Q?Ve8D/x//T4WI2mos6S10AJUCgDhjFjJ0tlJdtOE5wIhqpjyqrsmcVLzoX7x5?=
 =?us-ascii?Q?F9mKf7b3FXu5ZhBrB3DLsuAvqK1ott9XBJohQz18Z+Ni9CLKfPfpcQckM2Hh?=
 =?us-ascii?Q?K3GyVMdoNDyX80x4Nz1OQpRNO999hn6+3CgxMWWWGkGU+Bb1jW89Pu0KF18F?=
 =?us-ascii?Q?MiyYqeet64X2keeO6cUpP7pe6PeXoTh9vUJxf4kbcE0grTu6D2bNb0Jb5bux?=
 =?us-ascii?Q?5j0dkhvpdTNSYrMPKbxDdmdeelb5VxKIxy0c0hh8qqVnw8rE4kijkQdvLdUe?=
 =?us-ascii?Q?ZAJ22q6n/f0hgf3QEoa0YHWyEcmuZgTQVys1gYZRQ2qj9PKYXNyJLyKXNNi/?=
 =?us-ascii?Q?xwBdhru66MMrqQV+149yYv2RzLo7C316XVTQMWBySBQPdz9U9IsWTnE9SPRn?=
 =?us-ascii?Q?yVZHtLPcfj8niRP0EbZE7TblPlhXGN3UHh/4c80m?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2918a020-4e9f-4080-7f71-08da62c0f33b
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5267.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2022 22:10:08.3007
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zzBYrfX6qb0ff9vTvtH67M5E6K9mYRvj1G0/fbiz34/5+7rEpH83gkVcGecKtMCXZOn7Ea+5wKE/FoZCstf9Zw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5207
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-10_18:2022-07-08,2022-07-10 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 malwarescore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207100102
X-Proofpoint-GUID: q1BmFoZE6iXT7r_X0hDBSBX6KhMuGkQP
X-Proofpoint-ORIG-GUID: q1BmFoZE6iXT7r_X0hDBSBX6KhMuGkQP
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

add subtest verifying BPF ksym iter behaviour.  The BPF ksym
iter program shows an example of dumping a format different to
/proc/kallsyms.  It adds KIND and MAX_SIZE fields which represent the
kind of symbol (core kernel, module, ftrace, bpf, or kprobe) and
the maximum size the symbol can be.  The latter is calculated from
the difference between current symbol value and the next symbol
value.

The key benefit for this iterator will likely be supporting in-kernel
data-gathering rather than dumping symbol details to userspace and
parsing the results.

Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
Acked-by: Yonghong Song <yhs@fb.com>
---
 tools/testing/selftests/bpf/prog_tests/bpf_iter.c | 16 +++++
 tools/testing/selftests/bpf/progs/bpf_iter.h      | 32 ++++++++++
 tools/testing/selftests/bpf/progs/bpf_iter_ksym.c | 74 +++++++++++++++++++++++
 3 files changed, 122 insertions(+)
 create mode 100644 tools/testing/selftests/bpf/progs/bpf_iter_ksym.c

diff --git a/tools/testing/selftests/bpf/prog_tests/bpf_iter.c b/tools/testing/selftests/bpf/prog_tests/bpf_iter.c
index 7ff5fa9..a33874b 100644
--- a/tools/testing/selftests/bpf/prog_tests/bpf_iter.c
+++ b/tools/testing/selftests/bpf/prog_tests/bpf_iter.c
@@ -27,6 +27,7 @@
 #include "bpf_iter_test_kern5.skel.h"
 #include "bpf_iter_test_kern6.skel.h"
 #include "bpf_iter_bpf_link.skel.h"
+#include "bpf_iter_ksym.skel.h"
 
 static int duration;
 
@@ -1120,6 +1121,19 @@ static void test_link_iter(void)
 	bpf_iter_bpf_link__destroy(skel);
 }
 
+static void test_ksym_iter(void)
+{
+	struct bpf_iter_ksym *skel;
+
+	skel = bpf_iter_ksym__open_and_load();
+	if (!ASSERT_OK_PTR(skel, "bpf_iter_ksym__open_and_load"))
+		return;
+
+	do_dummy_read(skel->progs.dump_ksym);
+
+	bpf_iter_ksym__destroy(skel);
+}
+
 #define CMP_BUFFER_SIZE 1024
 static char task_vma_output[CMP_BUFFER_SIZE];
 static char proc_maps_output[CMP_BUFFER_SIZE];
@@ -1267,4 +1281,6 @@ void test_bpf_iter(void)
 		test_buf_neg_offset();
 	if (test__start_subtest("link-iter"))
 		test_link_iter();
+	if (test__start_subtest("ksym"))
+		test_ksym_iter();
 }
diff --git a/tools/testing/selftests/bpf/progs/bpf_iter.h b/tools/testing/selftests/bpf/progs/bpf_iter.h
index 97ec8bc..4b23a08 100644
--- a/tools/testing/selftests/bpf/progs/bpf_iter.h
+++ b/tools/testing/selftests/bpf/progs/bpf_iter.h
@@ -22,6 +22,8 @@
 #define BTF_F_NONAME BTF_F_NONAME___not_used
 #define BTF_F_PTR_RAW BTF_F_PTR_RAW___not_used
 #define BTF_F_ZERO BTF_F_ZERO___not_used
+#define bpf_iter__ksym bpf_iter__ksym___not_used
+#define kallsym_iter kallsym_iter___not_used
 #include "vmlinux.h"
 #undef bpf_iter_meta
 #undef bpf_iter__bpf_map
@@ -44,6 +46,8 @@
 #undef BTF_F_NONAME
 #undef BTF_F_PTR_RAW
 #undef BTF_F_ZERO
+#undef bpf_iter__ksym
+#undef kallsym_iter
 
 struct bpf_iter_meta {
 	struct seq_file *seq;
@@ -151,3 +155,31 @@ enum {
 	BTF_F_PTR_RAW	=	(1ULL << 2),
 	BTF_F_ZERO	=	(1ULL << 3),
 };
+
+#ifndef KSYM_NAME_LEN
+#define KSYM_NAME_LEN 128
+#endif
+
+#ifndef MODULE_NAME_LEN
+#define MODULE_NAME_LEN (64 - sizeof(unsigned long))
+#endif
+
+struct kallsym_iter {
+	loff_t pos;
+	loff_t pos_arch_end;
+	loff_t pos_mod_end;
+	loff_t pos_ftrace_mod_end;
+	loff_t pos_bpf_end;
+	unsigned long value;
+	unsigned int nameoff; /* If iterating in core kernel symbols. */
+	char type;
+	char name[KSYM_NAME_LEN];
+	char module_name[MODULE_NAME_LEN];
+	int exported;
+	int show_value;
+};
+
+struct bpf_iter__ksym {
+	struct bpf_iter_meta *meta;
+	struct kallsym_iter *ksym;
+};
diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_ksym.c b/tools/testing/selftests/bpf/progs/bpf_iter_ksym.c
new file mode 100644
index 0000000..285c008
--- /dev/null
+++ b/tools/testing/selftests/bpf/progs/bpf_iter_ksym.c
@@ -0,0 +1,74 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (c) 2022, Oracle and/or its affiliates. */
+#include "bpf_iter.h"
+#include <bpf/bpf_helpers.h>
+
+char _license[] SEC("license") = "GPL";
+
+unsigned long last_sym_value = 0;
+
+static inline char tolower(char c)
+{
+	if (c >= 'A' && c <= 'Z')
+		c += ('a' - 'A');
+	return c;
+}
+
+static inline char toupper(char c)
+{
+	if (c >= 'a' && c <= 'z')
+		c -= ('a' - 'A');
+	return c;
+}
+
+/* Dump symbols with max size; the latter is calculated by caching symbol N value
+ * and when iterating on symbol N+1, we can print max size of symbol N via
+ * address of N+1 - address of N.
+ */
+SEC("iter/ksym")
+int dump_ksym(struct bpf_iter__ksym *ctx)
+{
+	struct seq_file *seq = ctx->meta->seq;
+	struct kallsym_iter *iter = ctx->ksym;
+	__u32 seq_num = ctx->meta->seq_num;
+	unsigned long value;
+	char type;
+	int ret;
+
+	if (!iter)
+		return 0;
+
+	if (seq_num == 0) {
+		BPF_SEQ_PRINTF(seq, "ADDR TYPE NAME MODULE_NAME KIND MAX_SIZE\n");
+		return 0;
+	}
+	if (last_sym_value)
+		BPF_SEQ_PRINTF(seq, "0x%x\n", iter->value - last_sym_value);
+	else
+		BPF_SEQ_PRINTF(seq, "\n");
+
+	value = iter->show_value ? iter->value : 0;
+
+	last_sym_value = value;
+
+	type = iter->type;
+
+	if (iter->module_name[0]) {
+		type = iter->exported ? toupper(type) : tolower(type);
+		BPF_SEQ_PRINTF(seq, "0x%llx %c %s [ %s ] ",
+			       value, type, iter->name, iter->module_name);
+	} else {
+		BPF_SEQ_PRINTF(seq, "0x%llx %c %s ", value, type, iter->name);
+	}
+	if (!iter->pos_arch_end || iter->pos_arch_end > iter->pos)
+		BPF_SEQ_PRINTF(seq, "CORE ");
+	else if (!iter->pos_mod_end || iter->pos_mod_end > iter->pos)
+		BPF_SEQ_PRINTF(seq, "MOD ");
+	else if (!iter->pos_ftrace_mod_end || iter->pos_ftrace_mod_end > iter->pos)
+		BPF_SEQ_PRINTF(seq, "FTRACE_MOD ");
+	else if (!iter->pos_bpf_end || iter->pos_bpf_end > iter->pos)
+		BPF_SEQ_PRINTF(seq, "BPF ");
+	else
+		BPF_SEQ_PRINTF(seq, "KPROBE ");
+	return 0;
+}
-- 
1.8.3.1