Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 11 Jul 2022 05:52:58 +0300
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Li zeming <zeming@nfschina.com>
Cc:     dhowells@redhat.com, jmorris@namei.org, serge@hallyn.com,
        keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@nfschina.com
Subject: Re: [PATCH] keys/keyring: Fix typo in string
Message-ID: <YsuQihEKR8DC+Pnm@kernel.org>
References: <20220704025610.3834-1-zeming@nfschina.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220704025610.3834-1-zeming@nfschina.com>
Precedence: bulk

On Mon, Jul 04, 2022 at 10:56:10AM +0800, Li zeming wrote:
> Remove the repeated ',' from string
> 
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>  security/keys/keyring.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/security/keys/keyring.c b/security/keys/keyring.c
> index 5e6a90760753..c6c47ca9b57d 100644
> --- a/security/keys/keyring.c
> +++ b/security/keys/keyring.c
> @@ -460,7 +460,7 @@ static int keyring_read_iterator(const void *object, void *data)
>  	struct keyring_read_iterator_context *ctx = data;
>  	const struct key *key = keyring_ptr_to_key(object);
>  
> -	kenter("{%s,%d},,{%zu/%zu}",
> +	kenter("{%s,%d},{%zu/%zu}",
>  	       key->type->name, key->serial, ctx->count, ctx->buflen);
>  
>  	if (ctx->count >= ctx->buflen)
> @@ -484,7 +484,7 @@ static long keyring_read(const struct key *keyring,
>  	struct keyring_read_iterator_context ctx;
>  	long ret;
>  
> -	kenter("{%d},,%zu", key_serial(keyring), buflen);
> +	kenter("{%d},%zu", key_serial(keyring), buflen);
>  
>  	if (buflen & (sizeof(key_serial_t) - 1))
>  		return -EINVAL;
> -- 
> 2.18.2
> 

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko